Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable sorting in sources and destinations page #11308

Closed
wants to merge 2 commits into from

Conversation

harshithmullapudi
Copy link
Contributor

@harshithmullapudi harshithmullapudi commented Mar 22, 2022

What

Enable sorting for the name in sources and destination page

@harshithmullapudi harshithmullapudi requested a review from a team as a code owner March 22, 2022 10:14
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Mar 22, 2022
@timroes
Copy link
Collaborator

timroes commented Mar 22, 2022

The linked issue here is asking for sorting also on the Connector and Destination column. We should either make sure this functionality is added to this PR, or not close the original issue with this PR, please.

@harshithmullapudi
Copy link
Contributor Author

Makes sense not closing it.

@harshithmullapudi
Copy link
Contributor Author

@timroes If you can help with this question: In the sources page if a source has multiple destinations is there any good way to handle sorting?

@timroes
Copy link
Collaborator

timroes commented Mar 23, 2022

@harshithmullapudi It's a good question, and I think we might not want to have sorting on it, but I'd let Andy answer that on the issue where you posted the question.

@harshithmullapudi
Copy link
Contributor Author

in favor of this #12302

@swyxio swyxio deleted the harshith/sorting-ui branch October 12, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants