feat: added sorting for name, connector and lastsync field #12302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
|
@timroes can you review this when you get time? |
|
|
|
Tested locally and feature works as expected 👍 |
teallarson
approved these changes
May 6, 2022
|
@timroes can we merge the PR? |
|
@dizel852 usually we have it on the author (if a member of airbyte) to merge that PR. Given that this PR is now rather outdated with master, I'd suggest we bring it once more up to date with master and have CI pass on it before merging. |
|
@timroes gotcha gotcha 😄 |
harshithmullapudi
force-pushed
the
harshith/sorting-con-des-sou
branch
from
a7b5cfb
to
bf52122
Compare
|
Hey I have rebased it with latest master @timroes is it ok if I merge now |
|
Good to go, since you got your reviews :) |
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* feat: added sorting for name, connector and lastsync field * fix: remove console.log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #8754