Build FE on FE changes #11422
Merged
Build FE on FE changes #11422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davinchia
reviewed
Mar 25, 2022
.github/workflows/gradle.yml
Outdated
| needs: start-frontend-test-runner # required to start the main job when the runner is ready | ||
| runs-on: ${{ needs.start-frontend-test-runner.outputs.label }} # run the job on the newly created runner | ||
| timeout-minutes: 120 | ||
| frontend-prepare: |
There was a problem hiding this comment.
nit: I recommend combing the frontend-prepare with the frontend-build job into a single frontend-build job. I don't think there is value to separating these out as jobs. This helps declutter the github actions summary & simplifies the needs block in the stop runner job.
davinchia
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Builds the :airbyte-webapp project (via gradle), when FE code changes. This was not happening since we split the builds and thus accidentally the FE unit tests (jest) was never running on any PR.