-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build FE on FE changes #11422
Merged
Merged
Build FE on FE changes #11422
Changes from 3 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8b33679
Build FE on FE changes
timroes a77ecda
Serialize build and E2E tests
timroes 9bb0865
Small job name fix
timroes 54f7750
Fix step dependencies
timroes ff1ba4d
Combine build & prepare job
timroes bb21723
Fix typo
timroes edab16f
Merge branch 'master' into tim/fe-build
timroes b1fb985
Merge branch 'master' into tim/fe-build
timroes 2635b9a
Parallelize FE jobs
timroes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: I recommend combing the
frontend-prepare
with thefrontend-build
job into a singlefrontend-build
job. I don't think there is value to separating these out as jobs. This helps declutter the github actions summary & simplifies theneeds
block in the stop runner job.