Move from rest-hooks to react-query

[jamakase]

What

Last piece that finally fixes #10400

• removes rest-hook library 🎉
• removes unnecessary service injections
• removes rest-hook from tests and storybook
• sets set initialSetupComplete in /workspaces/get call instead of workspaces/list call in e2e tests.

[timroes]

(leaving some half-way-through comments, while reviewing the remaining files)

[timroes]

Trying to understand this change (and the same a few lines below): The tests in this file are all skipped for now anyway, is there any specific reason we changed those IDs to overlap with the sourceDefinitionIds above? Or is this some artifact from trying to get those tests unskipped again?

[jamakase]

This test was disabled before. I tried to make it as close to working as possible, but the issue is that it is difficult to test that useUpdateDestinationDefinition was called, as we need to mock mutateAsync. I thought, that we need to improve DI a bit, so we could inject DefinitionService with mocks later and check the call there.

Right now, it is not that easy to fix this test ( or a bit more investigation is required ).

[timroes]

There is currently one a bit weird behavior, where loading the connection list in one workspace and switching over to another workspace and going back to the connection page (of course works with other resources the same way), will shortly show the connection list of the old workspace before updating them. I think we'll still need to make sure that all queries are invaldiated once the workspace is switched.

[jamakase]

There is currently one a bit weird behavior, where loading the connection list in one workspace and switching over to another workspace and going back to the connection page (of course works with other resources the same way), will shortly show the connection list of the old workspace before updating them. I think we'll still need to make sure that all queries are invaldiated once the workspace is switched.

Hmm, indeed, we may need to invalidate all list queries. Do you think we should prepend all workspace specific queries with workspaceId in filters, or we should just invalidate all queries?

[timroes]

I think it would make sense adding the workspace ID to the query key for at least all list queries. That said I'd still additionally invalidate all queries I think when switching, since we have most things scoped to workspaces for now (definitions aren't yet,but that will change soon), so I don't think it's a huge problem invalidating all queries, and leaves us on the safe side of not accidentally missing a query.

[jamakase]

I think it would make sense adding the workspace ID to the query key for at least all list queries. That said I'd still additionally invalidate all queries I think when switching, since we have most things scoped to workspaces for now (definitions aren't yet,but that will change soon), so I don't think it's a huge problem invalidating all queries, and leaves us on the safe side of not accidentally missing a query.

As per our discussion offline - added invalidation of scopes. If required - later workspaceId could be added ( in case smoother behaviour is preferred while switching between workspaces ).

Also there was an issue, that queries were reset instead of deleting on changing workspaces.

[timroes]

Tested every page locally, everything seems to work as expected. Looked through the code, looks good to me.