Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add react-query devtools #11617

Merged
merged 2 commits into from
Mar 31, 2022
Merged

Add react-query devtools #11617

merged 2 commits into from
Mar 31, 2022

Conversation

jamakase
Copy link
Contributor

What

Adds react-query devtools. After the merge of #11524 which removes rest-hooks and migrates everything to react-query, it will be very convenient to use builtin dev-tools.

@jamakase jamakase requested a review from a team as a code owner March 31, 2022 09:42
@jamakase jamakase self-assigned this Mar 31, 2022
@github-actions github-actions bot added area/frontend area/platform issues related to the platform labels Mar 31, 2022
@@ -14,7 +15,10 @@ const queryClient = new QueryClient({

const StoreProvider: React.FC = ({ children }) => (
<CacheProvider>
<QueryClientProvider client={queryClient}>{children}</QueryClientProvider>
<QueryClientProvider client={queryClient}>
<ReactQueryDevtools initialIsOpen={false} />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nitpick. Could we make it position="bottom-right" so it's a bit more "out of the way" and not overlapping with the side navigation.

Copy link
Collaborator

@timroes timroes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jamakase jamakase merged commit 676f454 into master Mar 31, 2022
@jamakase jamakase deleted the jamakase/add-react-query-devtools branch March 31, 2022 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants