-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generated API Client #12071
Generated API Client #12071
Conversation
airbyte-webapp/src/pages/ConnectionPage/pages/AllConnectionsPage/AllConnectionsPage.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Vladimir <volodymyr.s.petrov@globallogic.com>
Co-authored-by: Vladimir <volodymyr.s.petrov@globallogic.com>
This is def not desired behavior and will look to get this fixed |
Another bug: the logs view with multiple attempts should not be working atm, since the current code only pulls of the latest logs always. Going to look into that as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested the whole app thoroughly with this PR active. OSS as well as in Cloud. Looked at the code overall and the specific core files like apiOverride (have not reviewed the type only changes in every single file on detail). This looks as safe as we can get it before merging for me.
I'm not sure if this issue relates to changes in this PR, but after the creation of a new connection, the sync job starts automatically(does it should?). Double-checked on |
@dizel852 The start behavior is expected, that we immediately start a new job when creating a connection (and I verified it against prod). The repeating when cancelling the initial sync sounds weird (but also present on prod). I'll check with the other platform teams, because that does indeed look suspicious (but since both are present on prod, not a problem with this PR). |
@timroes ok, then. |
Our service layer is now auto-generated from the OpenApi spec.
Closes #10181