use /list instead of /list_for_workspace #13341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
git-phu
force-pushed
the
peter/use-original-definition-list-apis
branch
from
1b2b9e5 to
f2eacc1
Compare
git-phu
force-pushed
the
peter/use-original-definition-list-apis
branch
2 times, most recently
from
237ae8e to
f6d785b
Compare
git-phu
force-pushed
the
peter/use-original-definition-list-apis
branch
from
f6d785b to
984887a
Compare
/list_for_workspace is still wip, part of #9652
git-phu
force-pushed
the
peter/use-original-definition-list-apis
branch
from
984887a to
7b9f2d4
Compare
teallarson
approved these changes
May 31, 2022
jscottpolevault
pushed a commit
to jscottpolevault/airbyte
that referenced
this pull request
Jun 1, 2022
/list_for_workspace is still wip, part of airbytehq#9652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
As part of #12071, the api calls for getting all definitions changed from
/v1/(source|destination)_definitions/listto/v1/(source|destination)_definitions/list_for_workspaceThe
list_for_workspaceAPIs are part of this epic that is not yet completed however so we can't use them atm (they depend on us also migrating to new APIs for creating definitions that set some new fields introduced in the epic).This change will revert the frontend behavior back to using the existing definition list APIs.