Resolve cyclic dependency between analytics files #12339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
Merged
teallarson
approved these changes
Apr 26, 2022
suhomud
pushed a commit
that referenced
this pull request
May 23, 2022
* Resolve cyclic dependency between analytics files * Refactor tracking component to hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes the problem that
npm startdoesn't work on master atm, because there's a cyclic dependency, e.g via:src/hooks/services/Analytics/index.tsx
->src/hooks/services/Analytics/TrackPageAnalytics.tsx
->src/hooks/services/Analytics/pageNameUtils.tsx
->src/pages/SettingsPage/SettingsPage.tsx
->src/pages/SettingsPage/pages/AccountPage/index.tsx
->src/pages/SettingsPage/pages/AccountPage/AccountPage.tsx
->src/pages/SettingsPage/components/useWorkspaceEditor.tsx
->src/hooks/services/useWorkspace.tsx
->src/hooks/services/Analytics/index.tsx
Easiest fix for that atm is to simply not reexport the
TrackPageAnalyticshook which is only used in our routes file. The cloud routes.tsx was already importing it directly from that file.