Source Amazon Seller Partner: Add GET_XML_BROWSE_TREE_DATA report #12663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_XML_BROWSE_TREE_DATA
|
|
github-actions
bot
added
area/connectors
|
Hi @manescianera thank you for this contribution! I'll run the tests and go for a first review soon! |
|
/test connector=connectors/source-amazon-seller-partner
|
|
/test connector=connectors/source-amazon-seller-partner
|
alafanechere
suggested changes
May 16, 2022
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "properties": { | ||
| "browseNodeId": { | ||
| "type": ["null", "string"] |
There was a problem hiding this comment.
Suggested change
| "type": ["null", "string"] | |
| "type": "string" |
As an identifier, I'm not sure this field can be null.
| "name": "GET_XML_BROWSE_TREE_DATA", | ||
| "json_schema": { | ||
| "title": "XML Browse Tree Data", | ||
| "description": "XML Browse Tree Data", |
There was a problem hiding this comment.
I think this field is redundant.
Suggested change
| "description": "XML Browse Tree Data", |
Comment on lines
19
to
29
| "anyOf": [ | ||
| { | ||
| "$ref": "#/definitions/attribute" | ||
| }, | ||
| { | ||
| "type": ["array"], | ||
| "items": { | ||
| "$ref": "#/definitions/attribute" | ||
| } | ||
| } | ||
| ] |
There was a problem hiding this comment.
It will make it easier for a destination to pick the right column type if you stick to arrays rather than anyOf, but this will require a small transformation in the parsing.
| } | ||
| ] | ||
| }, | ||
| "@count": { |
There was a problem hiding this comment.
Could we avoid special characters like @ for safety in case they are not supported in some destinations?
…Field type to array
…nera/airbyte into sp-api-GET_XML_BROWSE_TREE_DATA
…_XML_BROWSE_TREE_DATA
|
hey, @alafanechere ! made changes based on your review. although looks that there's a small problem. while unit and integration tests pass no problem; after pulling from master acceptance tests fail and I'm not sure why (it passes before the pull). maybe I've missed something? Acceptance tests |
|
/test connector=connectors/source-amazon-seller-partner
|
Let's try running these in the CI (☝️ ) and to check if it's related to your environment. |
alafanechere
suggested changes
May 23, 2022
| } | ||
| } | ||
| }, | ||
| "count": { |
There was a problem hiding this comment.
@manescianera I saw you renamed to count but I'm not sure you changed the parsing logic to rename the @count to count in the XML output. Did I miss something?
There was a problem hiding this comment.
attr_prefix argument takes care of the json prefixes from parsed XML node properties, so I've changed attr_prefix to a blank string over here
alafanechere
approved these changes
May 23, 2022
|
/publish connector=connectors/source-amazon-seller-partner
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
GET_XML_BROWSE_TREE_DATAreport to Amazon Seller Partner source connector.How
Get Browse Tree Report XML data and then parse it into a dictionary.
Pre-merge Checklist
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereTests
Unit
Integration
Acceptance