-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Amazon Seller Partner: Add GET_XML_BROWSE_TREE_DATA report #12663
Merged
alafanechere
merged 28 commits into
airbytehq:master
from
manescianera:sp-api-GET_XML_BROWSE_TREE_DATA
May 23, 2022
Merged
Changes from 27 commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
914b495
Added: GET_XML_BROWSE_TREE_DATA schema
manescianera 85b3e11
Added: GET_XML_BROWSE_TREE_DATA configured json
manescianera aba0b9e
Added: sample_state.json -> GET_XML_BROWSE_TREE_DATA
manescianera 1cad3ef
Added: GET_XML_BROWSE_TREE_DATA stream
manescianera b1bb6fa
Added: GET_XML_BROWSE_TREE_DATA -> acceptance-test-config.yml
manescianera 95fd7e2
Added: xmltodict requirement
manescianera da4d019
Fixed: incorrect json schema
manescianera da15987
Fixed: formatting
manescianera ee91b3b
Removed: result_key
manescianera 0b0f423
Changed: DRY up json schema
manescianera 6b6b79b
Merge branch 'master' of github.com:airbytehq/airbyte into sp-api-GET…
manescianera 917e07f
Added: browse tree report docs
manescianera 41502b8
Changed: update browse tree configured catalog json schema
manescianera 60ccdb7
Fixed: acceptance test config
manescianera e10f2fd
Fixed: integration_tests.acceptance test_match_expected() failure
manescianera 0bca7a0
Added: changelog entry to amazon seller partner source doc
manescianera b21ba11
Merge branch 'master' of github.com:airbytehq/airbyte into sp-api-GET…
manescianera 814bc61
Merge branch 'master' into sp-api-GET_XML_BROWSE_TREE_DATA
alafanechere 7a413ea
consistent description
alafanechere cb590be
Changed: schema -> browseNodeId not nullable
manescianera fcf21b3
Removed: redundant schema description
manescianera fd1bc65
Fixed: formatting
manescianera 6a8d50e
Removed: schema anyOf; Changed: schema keys attribute, id, refinement…
manescianera cb362e6
Merge branch 'sp-api-GET_XML_BROWSE_TREE_DATA' of github.com:manescia…
manescianera 78725d9
Merge branch 'master' of github.com:airbytehq/airbyte into sp-api-GET…
manescianera 754c2bb
Fixed: code formatting
manescianera 8299ffa
bump version in dockerfile
alafanechere 8276bd3
auto-bump connector version
octavia-squidington-iii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
106 changes: 106 additions & 0 deletions
106
...s/source-amazon-seller-partner/integration_tests/configured_catalog_browse_tree_data.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| { | ||
| "streams": [ | ||
| { | ||
| "stream": { | ||
| "name": "GET_XML_BROWSE_TREE_DATA", | ||
| "json_schema": { | ||
| "title": "XML Browse Tree Data", | ||
| "type": "object", | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "properties": { | ||
| "browseNodeId": { | ||
| "type": ["string"] | ||
| }, | ||
| "browseNodeAttributes": { | ||
| "type": ["null", "object"], | ||
| "properties": { | ||
| "attribute": { | ||
| "type": ["array"], | ||
| "items": { | ||
| "type": ["null", "object"] | ||
| }, | ||
| "properties": { | ||
| "name": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "text": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| }, | ||
| "count": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| }, | ||
| "browseNodeName": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "browseNodeStoreContextName": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "browsePathById": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "browsePathByName": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "hasChildren": { | ||
| "type": ["string"] | ||
| }, | ||
| "childNodes": { | ||
| "type": ["null", "object"], | ||
| "properties": { | ||
| "count": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "id": { | ||
| "type": ["array"], | ||
| "items": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "productTypeDefinitions": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "refinementsInformation": { | ||
| "type": ["array"], | ||
| "items": { | ||
| "type": ["null", "object"] | ||
| }, | ||
| "properties": { | ||
| "refinementName": { | ||
| "type": ["object"], | ||
| "properties": { | ||
| "refinementField": { | ||
| "type": ["null", "object"], | ||
| "properties": { | ||
| "acceptedValues": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "hasModifier": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "modifiers": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "refinementAttribute": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "supported_sync_modes": ["full_refresh"] | ||
| }, | ||
| "sync_mode": "full_refresh", | ||
| "destination_sync_mode": "overwrite" | ||
| } | ||
| ] | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
94 changes: 94 additions & 0 deletions
94
...-amazon-seller-partner/source_amazon_seller_partner/schemas/GET_XML_BROWSE_TREE_DATA.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,94 @@ | ||
| { | ||
| "title": "XML Browse Tree Data", | ||
| "type": "object", | ||
| "$schema": "http://json-schema.org/draft-07/schema#", | ||
| "properties": { | ||
| "browseNodeId": { | ||
| "type": ["string"] | ||
| }, | ||
| "browseNodeAttributes": { | ||
| "type": ["null", "object"], | ||
| "properties": { | ||
| "attribute": { | ||
| "type": ["array"], | ||
| "items": { | ||
| "type": ["null", "object"] | ||
| }, | ||
| "properties": { | ||
| "name": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "text": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| }, | ||
| "count": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| }, | ||
| "browseNodeName": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "browseNodeStoreContextName": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "browsePathById": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "browsePathByName": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "hasChildren": { | ||
| "type": ["string"] | ||
| }, | ||
| "childNodes": { | ||
| "type": ["null", "object"], | ||
| "properties": { | ||
| "count": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "id": { | ||
| "type": ["array"], | ||
| "items": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| } | ||
| }, | ||
| "productTypeDefinitions": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "refinementsInformation": { | ||
| "type": ["array"], | ||
| "items": { | ||
| "type": ["null", "object"] | ||
| }, | ||
| "properties": { | ||
| "refinementName": { | ||
| "type": ["object"], | ||
| "properties": { | ||
| "refinementField": { | ||
| "type": ["null", "object"], | ||
| "properties": { | ||
| "acceptedValues": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "hasModifier": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "modifiers": { | ||
| "type": ["null", "string"] | ||
| }, | ||
| "refinementAttribute": { | ||
| "type": ["null", "string"] | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@manescianera I saw you renamed to
countbut I'm not sure you changed the parsing logic to rename the@counttocountin the XML output. Did I miss something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
attr_prefixargument takes care of the json prefixes from parsed XML node properties, so I've changedattr_prefixto a blank string over here