Source Hubspot: ensure all oauth2.0 scopes in "check" command

[grubberr]

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Check that oauth2.0 token has all needed scopes

Recommended reading order

1. x.java
2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

• Grant edit access to maintainers (instructions)
• Secrets in the connector's spec are annotated with airbyte_secret
• Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
• Code reviews completed
• Documentation updated
  • Connector's README.md
  • Connector's bootstrap.md. See description and examples
  • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
• PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

• Create a non-forked branch based on this PR and test the below items on it
• Build is successful
• If new credentials are required for use in CI, add them to GSM. Instructions.
• /test connector=connectors/<name> command is passing
• New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@559b638). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #12711   +/-   ##
=========================================
  Coverage          ?   89.36%           
=========================================
  Files             ?        4           
  Lines             ?      809           
  Branches          ?        0           
=========================================
  Hits              ?      723           
  Misses            ?       86           
  Partials          ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 559b638...f629c39. Read the comment docs.

[grubberr]

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2298698650
❌ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2298698650
🐛 https://gradle.com/s/ctmvpryctgyw2
Python short test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs1] - AssertionError: as...
=================== 1 failed, 26 passed in 118.71s (0:01:58) ===================

[grubberr]

/test connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2299830746
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2299830746
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        74      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/tests/test_core.py              285    106    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
source_acceptance_test/tests/test_incremental.py        69     38    45%
------------------------------------------------------------------------
TOTAL                                                  896    259    71%
Name                         Stmts   Miss  Cover
------------------------------------------------
source_hubspot/errors.py         6      0   100%
source_hubspot/__init__.py       2      0   100%
source_hubspot/streams.py      714     61    91%
source_hubspot/source.py        87     25    71%
------------------------------------------------
TOTAL                          809     86    89%

[bazarnov]

Looks nice, however we're not testing the actual data fetch using the granted scopes. Is it possible that access_token has the right granted scopes, but the user still cannot fetch the data due to role or permission limitations?
The analogy is source salesforce, where you can have all the scopes granted, but due to data object limitations, the data could not be fetched until the user assigned to that object or the user's role gives such an opportunity.

[grubberr]

@bazarnov I did not saw such cases like for salesforce,
where some data not accessible even if we have needed scopes,
but I will continue to watch.

[girarda]

looks good! Approved pending updating as per denis' suggestion

[grubberr]

/publish connector=connectors/source-hubspot

🕑 connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2312446979
🚀 Successfully published connectors/source-hubspot
🚀 Auto-bumped version for connectors/source-hubspot
✅ connectors/source-hubspot https://github.com/airbytehq/airbyte/actions/runs/2312446979