Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements #13388

Merged
merged 19 commits into from
Jun 3, 2022
Merged

Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements #13388

merged 19 commits into from
Jun 3, 2022

Commits on Jun 1, 2022

  1. turn on "curly" rule

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5b0ebc9 View commit details
    Browse the repository at this point in the history

  2. set a loading state for 'Cancel' button if user clicked

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    88b9d61 View commit details
    Browse the repository at this point in the history

  3. extend ToolTip component to support 'not-allowed' cursor

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    e50ac47 View commit details
    Browse the repository at this point in the history

  4. disable 'Reset data' and 'Sync now' buttons if sync is in 'pending' o… 

    …r 'running' status
    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    14f5f20 View commit details
    Browse the repository at this point in the history

  5. set loading state and disable buttons in ResetDataModal if reset proc… 

    …ess is launched
    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    0228d48 View commit details
    Browse the repository at this point in the history

  6. extend ToolTip component - shoe desired cursor type when tooltip is a… 

    …ctive
    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b5ceaa7 View commit details
    Browse the repository at this point in the history

  7. refactored: control tooltips showing this props

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    2c0402c View commit details
    Browse the repository at this point in the history

  8. replace functions call in jsx with components

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    97fdbb5 View commit details
    Browse the repository at this point in the history

  9. add style for loading 'danger' button

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    ba51478 View commit details
    Browse the repository at this point in the history

  10. minor improvements - use ternary operator conditionally setting the d… 

    …esired text
    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    f82e1c0 View commit details
    Browse the repository at this point in the history

  11. set loading state to 'false' if async action has failed

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    435c0d2 View commit details
    Browse the repository at this point in the history

  12. extend ConfirmationModal - to support optional cancelButtonText prop

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    932f56d View commit details
    Browse the repository at this point in the history

  13. extend useLoadingState component - to show an error notification if a… 

    …sync action is failed
    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    22fb670 View commit details
    Browse the repository at this point in the history

  14. show notification message on top

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    b46a8e2 View commit details
    Browse the repository at this point in the history

  15. replace using ResetData modal with default text with useConfirmationM… 

    …odalService
    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    40597fb View commit details
    Browse the repository at this point in the history

  16. replace ResetDataModal (refresh schema) with useConfirmationModalService

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    99dc460 View commit details
    Browse the repository at this point in the history

  17. remove obsolete ResetDataModal component

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    6fa7422 View commit details
    Browse the repository at this point in the history

  18. updated tests

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    5d41409 View commit details
    Browse the repository at this point in the history

  19. replace ResetDataModal (changed column) with useConfirmationModalService

    @dizel852
    dizel852 committed Jun 1, 2022
    Configuration menu
    Copy the full SHA
    30fc6e3 View commit details
    Browse the repository at this point in the history