Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements #13388

Merged
merged 19 commits into from
Jun 3, 2022

Conversation

dizel852
Copy link
Contributor

@dizel852 dizel852 commented Jun 1, 2022

What

Closes #12091
Replaces #12569

  • Improve UX

Original description

#12569

CPT2206012204-500x396
(sorry for low quality - Github file size restrictions)

@github-actions github-actions bot added area/platform issues related to the platform area/frontend Related to the Airbyte webapp labels Jun 1, 2022
@dizel852 dizel852 self-assigned this Jun 1, 2022
@dizel852
Copy link
Contributor Author

dizel852 commented Jun 1, 2022

Tested on OSS env with multiple sources(GitHub, PokeAPI)

@dizel852 dizel852 marked this pull request as ready for review June 1, 2022 20:22
@dizel852 dizel852 requested a review from a team as a code owner June 1, 2022 20:22
@teallarson
Copy link
Contributor

Improve UX

Could you be more specific in the description about what improvements this PR makes? Hopefully most of our PRs are improving UX!

@dizel852
Copy link
Contributor Author

dizel852 commented Jun 2, 2022

Improve UX

Could you be more specific in the description about what improvements this PR makes? Hopefully most of our PRs are improving UX!

Sure, but I'm already described them in the reverted PR: #12569. Should I move the original description here also?

Copy link
Contributor

@edmundito edmundito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good to me. Tested locally by refreshing the schema, resetting and refreshing the schema, and reloading the page.

@edmundito edmundito requested a review from a team June 3, 2022 14:04
@dizel852 dizel852 merged commit bdeadfc into master Jun 3, 2022
@dizel852 dizel852 deleted the vlad/fixed-reverted-pr-cancel-button-loading-state branch June 3, 2022 14:06
@dizel852
Copy link
Contributor Author

dizel852 commented Jun 3, 2022

Gosh, missed that you've requested other guys 🤦‍♂️
image

chebalski added a commit to BluestarGenomics/airbyte that referenced this pull request Jul 25, 2022
* master: (142 commits)
  Highlight removed and added streams in Connection form (airbytehq#13392)
  🐛  Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373)
  🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450)
  Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388)
  🎉 Source Freshdesk: Added new streams (airbytehq#13332)
  Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384)
  helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467)
  airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370)
  Change stage to `beta` (airbytehq#13422)
  🐛 Source Google Sheets: Retry on server errors (airbytehq#13446)
  Improve kube deploy process. (airbytehq#13397)
  Helm chart dependencies fix (airbytehq#13432)
  🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218)
  airbytehq#11758: Source Google Ads to GA (airbytehq#13441)
  Add more pr actions to tag pull requests (airbytehq#13437)
  Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423)
  Updates error view with new design (airbytehq#13197)
  Source MSSQL: correct enum Standard method (airbytehq#13419)
  Update postgres doc about cdc publication (airbytehq#13433)
  run source acceptance tests against image built from branch (airbytehq#13401)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Related to the Airbyte webapp area/platform issues related to the platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The cancel button doesn't seem to work or provide feedback to the user
3 participants