[#13026] run source acceptance tests against image built from branch #13401

brianjlai · 2022-06-02T02:35:37Z

What

When making changes to /bases/source-acceptance-test, testing against real connectors using Gradle (./gradlew :airbyte-integrations:connectors:source-<connector>:sourceAcceptanceTest) or Github Actions tests against the latest image instead of the current branch. This effectively makes it very difficult to test changes or quickly iterate on the source-acceptance-test module itself.

How

As part of source-acceptance-test runs against connectors using /test connector=connectors/source-<connector>, we are actually already testing and building the source-acceptance-test image tagged as :dev. We might as well use it and this small change to airbyte-source-acceptance-test.gradle does just that.

Note: I have some auto-fail tests added so that I can verify test runs kicked off via GH will pickup the local branch changes and fail. I will remove these before a merge.

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

…il tests for validation

brianjlai · 2022-06-02T02:40:33Z

/test connector=connectors/source-paypal-transaction

🕑 connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/2425699706
❌ connectors/source-paypal-transaction https://github.com/airbytehq/airbyte/actions/runs/2425699706
🐛 https://gradle.com/s/ceedoypfaunqq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - Failed: Testing th...
FAILED test_core.py::TestConnection::test_check[inputs1] - Failed: Testing th...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: failing to t...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 3 failed, 17 passed, 2 skipped in 4.93s ====================

brianjlai · 2022-06-02T02:54:47Z

nice, this test failure is expected since the auto fail code is only on my current branch

brianjlai · 2022-06-02T04:33:55Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2426078405
❌ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2426078405
🐛 https://gradle.com/s/koi5sjy5r62zq

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestConnection::test_check[inputs0] - Failed: Testing th...
FAILED test_core.py::TestConnection::test_check[inputs1] - Failed: Testing th...
FAILED test_core.py::TestConnection::test_check[inputs2] - Failed: Testing th...
FAILED test_core.py::TestConnection::test_check[inputs3] - Failed: Testing th...
FAILED test_core.py::TestBasicRead::test_read[inputs0] - Failed: failing to t...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 5 failed, 18 passed, 1 skipped in 30.59s ===================

brianjlai · 2022-06-02T05:24:06Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2426207807
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2426207807
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
google_sheets_source/models/spreadsheet_values.py      12      0   100%
google_sheets_source/models/spreadsheet.py             34      0   100%
google_sheets_source/models/__init__.py                 2      0   100%
google_sheets_source/__init__.py                        2      0   100%
google_sheets_source/helpers.py                       139     26    81%
google_sheets_source/client.py                         22      5    77%
google_sheets_source/google_sheets_source.py          106     84    21%
-----------------------------------------------------------------------
TOTAL                                                 317    115    64%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 168.00s (0:02:47) ===================

* master: (142 commits) Highlight removed and added streams in Connection form (airbytehq#13392) 🐛 Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373) 🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450) Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388) 🎉 Source Freshdesk: Added new streams (airbytehq#13332) Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384) helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467) airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370) Change stage to `beta` (airbytehq#13422) 🐛 Source Google Sheets: Retry on server errors (airbytehq#13446) Improve kube deploy process. (airbytehq#13397) Helm chart dependencies fix (airbytehq#13432) 🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218) airbytehq#11758: Source Google Ads to GA (airbytehq#13441) Add more pr actions to tag pull requests (airbytehq#13437) Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423) Updates error view with new design (airbytehq#13197) Source MSSQL: correct enum Standard method (airbytehq#13419) Update postgres doc about cdc publication (airbytehq#13433) run source acceptance tests against image built from branch (airbytehq#13401) ...

run source acceptance tests against image built from branch + auto fa…

b14a3c7

…il tests for validation

remove auto fail tests used for validation

3ed14b1

brianjlai marked this pull request as ready for review June 2, 2022 05:01

brianjlai requested a review from sherifnada June 2, 2022 05:01

brianjlai temporarily deployed to more-secrets June 2, 2022 05:04 Inactive

sherifnada approved these changes Jun 2, 2022

View reviewed changes

brianjlai merged commit b73713e into master Jun 2, 2022

brianjlai deleted the brian/use_branch_source_acceptance_tests branch June 2, 2022 16:22

octavia-squidington-iii mentioned this pull request Jun 3, 2022

Bump Airbyte version from 0.39.8-alpha to 0.39.9-alpha #13454

Merged

brianjlai changed the title ~~run source acceptance tests against image built from branch~~ [#13026] run source acceptance tests against image built from branch Jul 19, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#13026] run source acceptance tests against image built from branch #13401

[#13026] run source acceptance tests against image built from branch #13401

brianjlai commented Jun 2, 2022

brianjlai commented Jun 2, 2022 •

edited by github-actions bot

Loading

brianjlai commented Jun 2, 2022

brianjlai commented Jun 2, 2022 •

edited by github-actions bot

Loading

brianjlai commented Jun 2, 2022 •

edited by github-actions bot

Loading

[#13026] run source acceptance tests against image built from branch #13401

[#13026] run source acceptance tests against image built from branch #13401

Conversation

brianjlai commented Jun 2, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

brianjlai commented Jun 2, 2022 • edited by github-actions bot Loading

Build Failed

brianjlai commented Jun 2, 2022

brianjlai commented Jun 2, 2022 • edited by github-actions bot Loading

Build Failed

brianjlai commented Jun 2, 2022 • edited by github-actions bot Loading

Build Passed

brianjlai commented Jun 2, 2022 •

edited by github-actions bot

Loading

brianjlai commented Jun 2, 2022 •

edited by github-actions bot

Loading

brianjlai commented Jun 2, 2022 •

edited by github-actions bot

Loading