Source MSSQL: correct enum Standard method #13419

marcosmarxm · 2022-06-02T12:59:39Z

What

#13168 changes the replication spec and add enum in MSSQLHelper but expect STANDARD value instead Standard.

How

Change Standard to STANDARD to follow guideline Java for enum

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

marcosmarxm · 2022-06-02T12:59:59Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2428377099
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2428377099
No Python unittests run

Build Passed

Test summary info:

All Passed

alafanechere · 2022-06-02T13:21:13Z

airbyte-integrations/connectors/source-mssql/src/main/resources/spec.json

-                "enum": ["Standard"],
-                "default": "Standard",
+                "const": "STANDARD",
+                "enum": ["STANDARD"],


Suggested change

"enum": ["STANDARD"],

I a const is declared I think an enum is redundant.

I think it's better to only pick enum in case other options appear in the future

@alafanechere agree with you but our spec-linter expect to have the const/enum/default values.

validate connectors spec files...........................................Failed - hook id: spec-linter - exit code: 1 airbyte-integrations/connectors/source-mssql/src/main/resources/spec.json: Check failed for field replication.0.replication_type airbyte-integrations/connectors/source-mssql/src/main/resources/spec.json: Check failed for field replication.1.replication_type

after removing the const value

marcosmarxm · 2022-06-02T15:35:52Z

/publish connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2429279530
🚀 Successfully published connectors/source-mssql
🚀 Auto-bumped version for connectors/source-mssql
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/2429279530

marcosmarxm · 2022-06-02T15:36:38Z

/publish connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2429283770
❌ Failed to publish connectors/source-mssql-strict-encrypt
❌ Couldn't auto-bump version for connectors/source-mssql-strict-encrypt

marcosmarxm · 2022-06-02T16:24:16Z

/publish connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2429540956
🚀 Successfully published connectors/source-mssql-strict-encrypt
❌ Couldn't auto-bump version for connectors/source-mssql-strict-encrypt

…hq/airbyte into marcos/source-mssql-spec

marcosmarxm · 2022-06-02T16:45:42Z

/publish connector=connectors/source-mssql-strict-encrypt

🕑 connectors/source-mssql-strict-encrypt https://github.com/airbytehq/airbyte/actions/runs/2429642471
🚀 Successfully published connectors/source-mssql-strict-encrypt
❌ Couldn't auto-bump version for connectors/source-mssql-strict-encrypt

marcosmarxm · 2022-06-02T17:16:20Z

Well bump strict-encrypt doesn't work yet: #13176 (comment)

tuliren · 2022-06-02T21:35:18Z

Thank you for the fix. Sorry about the bug.

bump strict-encrypt doesn't work yet

The strict-encrypt connector only eixsts on cloud. So its version can only be bumped in airbyte-cloud.

* master: (142 commits) Highlight removed and added streams in Connection form (airbytehq#13392) 🐛 Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373) 🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450) Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388) 🎉 Source Freshdesk: Added new streams (airbytehq#13332) Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384) helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467) airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370) Change stage to `beta` (airbytehq#13422) 🐛 Source Google Sheets: Retry on server errors (airbytehq#13446) Improve kube deploy process. (airbytehq#13397) Helm chart dependencies fix (airbytehq#13432) 🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218) airbytehq#11758: Source Google Ads to GA (airbytehq#13441) Add more pr actions to tag pull requests (airbytehq#13437) Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423) Updates error view with new design (airbytehq#13197) Source MSSQL: correct enum Standard method (airbytehq#13419) Update postgres doc about cdc publication (airbytehq#13433) run source acceptance tests against image built from branch (airbytehq#13401) ...

correct enum MSSQL source

199681b

marcosmarxm requested review from tuliren and alafanechere June 2, 2022 12:59

github-actions bot added the area/connectors Connector related issues label Jun 2, 2022

bump strict version and update doc

5be484d

marcosmarxm mentioned this pull request Jun 2, 2022

🐛 Source MsSql: Source connection setup failure #13361

Closed

github-actions bot added the area/documentation Improvements or additions to documentation label Jun 2, 2022

alafanechere requested changes Jun 2, 2022

View reviewed changes

alafanechere approved these changes Jun 2, 2022

View reviewed changes

correct expect spec test

e0cda60

octavia-squidington-iii added 2 commits June 2, 2022 16:40

auto-bump connector version

5efed7b

Merge branch 'marcos/source-mssql-spec' of https://github.com/airbyte…

c1b26b7

…hq/airbyte into marcos/source-mssql-spec

marcosmarxm merged commit b5b43d3 into master Jun 2, 2022

marcosmarxm deleted the marcos/source-mssql-spec branch June 2, 2022 17:16

octavia-squidington-iii mentioned this pull request Jun 3, 2022

Bump Airbyte version from 0.39.8-alpha to 0.39.9-alpha #13454

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source MSSQL: correct enum Standard method #13419

Source MSSQL: correct enum Standard method #13419

marcosmarxm commented Jun 2, 2022 •

edited

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

alafanechere Jun 2, 2022

alafanechere Jun 2, 2022 •

edited

Loading

marcosmarxm Jun 2, 2022

marcosmarxm Jun 2, 2022

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited

Loading

tuliren commented Jun 2, 2022

Source MSSQL: correct enum Standard method #13419

Source MSSQL: correct enum Standard method #13419

Conversation

marcosmarxm commented Jun 2, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Jun 2, 2022 • edited by github-actions bot Loading

Build Passed

alafanechere Jun 2, 2022

Choose a reason for hiding this comment

alafanechere Jun 2, 2022 • edited Loading

Choose a reason for hiding this comment

marcosmarxm Jun 2, 2022

Choose a reason for hiding this comment

marcosmarxm Jun 2, 2022

Choose a reason for hiding this comment

marcosmarxm commented Jun 2, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jun 2, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jun 2, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jun 2, 2022 • edited by github-actions bot Loading

marcosmarxm commented Jun 2, 2022 • edited Loading

tuliren commented Jun 2, 2022

marcosmarxm commented Jun 2, 2022 •

edited

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

alafanechere Jun 2, 2022 •

edited

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Jun 2, 2022 •

edited

Loading