Updates error view with new design #13197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
Add the ability to set CTA button text and click handler Migrate to SCSS module Signed-off-by: Edmundo Ruiz Ghanem <edmundo@airbyte.io>
Update error views to have go back cta
edmundito
force-pushed
the
edmundito/update-error-state-design
branch
from
a82765c
to
1b13814
Compare
teallarson
approved these changes
May 27, 2022
vincentkoc
approved these changes
May 29, 2022
|
Looks great @edmundito |
timroes
reviewed
May 31, 2022
timroes
reviewed
May 31, 2022
| message={<FormattedMessage id="errorView.unknownError" />} | ||
| ctaButtonText={<FormattedMessage id="ui.goBack" />} | ||
| onCtaButtonClick={() => { | ||
| navigate(".."); |
There was a problem hiding this comment.
❓ Could you clarify why we're always wanting to go one level app, no matter where we are? This error boundary could be rendered in a lot of different pathes. Are we sure we're even having a valid route registered for all "one level" up navigations?
There was a problem hiding this comment.
Thanks for pointing this up. I rested the app and we do support one level-up navigation on all routes. The reasoning is that this will get users to the nearest area to where they currently are.
Co-authored-by: Tim Roes <tim@airbyte.io>
timroes
reviewed
May 31, 2022
airbyte-webapp/src/views/common/ErrorOccurredView/ErrorOccurredView.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Roes <tim@airbyte.io>
timroes
reviewed
May 31, 2022
| ); | ||
|
|
||
| .content { | ||
| margin-top: -17px; // Offset for octavia image padding |
There was a problem hiding this comment.
To my understanding this is just caused by a larger transparent border around the image? Could we instead just crop the image properly, to not require to hack in SCSS some negative margin to move the div?
chebalski
added a commit
to BluestarGenomics/airbyte
that referenced
this pull request
Jul 25, 2022
* master: (142 commits) Highlight removed and added streams in Connection form (airbytehq#13392) 🐛 Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373) 🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450) Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388) 🎉 Source Freshdesk: Added new streams (airbytehq#13332) Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384) helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467) airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370) Change stage to `beta` (airbytehq#13422) 🐛 Source Google Sheets: Retry on server errors (airbytehq#13446) Improve kube deploy process. (airbytehq#13397) Helm chart dependencies fix (airbytehq#13432) 🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218) airbytehq#11758: Source Google Ads to GA (airbytehq#13441) Add more pr actions to tag pull requests (airbytehq#13437) Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423) Updates error view with new design (airbytehq#13197) Source MSSQL: correct enum Standard method (airbytehq#13419) Update postgres doc about cdc publication (airbytehq#13433) run source acceptance tests against image built from branch (airbytehq#13401) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Updates error view with new design:
Onboarding example:
Full screen:
Figma:
https://www.figma.com/file/I5WCr153LfpLUuPTwsZZdD/ERROR_MESSAGES
Closes #12172
How
Applies the new design, migrates error view to use scss over styled components, and removes old error view navigation that have been replaced with a direct button instead of clicking on the Airbyte logo.
Recommended reading order
ErrorOccurredView.tsx/.scss