🐛 Source Google Sheets: Retry on server errors #13446

girarda · 2022-06-02T23:41:46Z

What

Google sheets sometimes throw 503 errors (see https://github.com/airbytehq/oncall/issues/254)
This PR updates the connector to retry requests resulting in server error

How

Update the error handler to retry on HTTP errors that are [500, 600)

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

girarda · 2022-06-02T23:42:46Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2431555909
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2431555909
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
google_sheets_source/models/spreadsheet_values.py      12      0   100%
google_sheets_source/models/spreadsheet.py             34      0   100%
google_sheets_source/models/__init__.py                 2      0   100%
google_sheets_source/__init__.py                        2      0   100%
google_sheets_source/helpers.py                       139     26    81%
google_sheets_source/client.py                         23      5    78%
google_sheets_source/google_sheets_source.py          106     84    21%
-----------------------------------------------------------------------
TOTAL                                                 318    115    64%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 116.01s (0:01:56) ===================

girarda · 2022-06-02T23:59:10Z

/test connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2431609529
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2431609529
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                                Stmts   Miss  Cover
-----------------------------------------------------------------------
google_sheets_source/models/spreadsheet_values.py      12      0   100%
google_sheets_source/models/spreadsheet.py             34      0   100%
google_sheets_source/models/__init__.py                 2      0   100%
google_sheets_source/__init__.py                        2      0   100%
google_sheets_source/helpers.py                       139     26    81%
google_sheets_source/client.py                         24      6    75%
google_sheets_source/google_sheets_source.py          106     84    21%
-----------------------------------------------------------------------
TOTAL                                                 319    116    64%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 23 passed, 1 skipped in 167.06s (0:02:47) ===================

codecov · 2022-06-03T00:33:30Z

Codecov Report

❗ No coverage uploaded for pull request base (master@88390f2). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13446   +/-   ##
=========================================
  Coverage          ?   63.52%           
=========================================
  Files             ?        7           
  Lines             ?      318           
  Branches          ?        0           
=========================================
  Hits              ?      202           
  Misses            ?      116           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88390f2...e5fe0e5. Read the comment docs.

brianjlai

looks good to me!

girarda · 2022-06-03T00:42:10Z

/publish connector=connectors/source-google-sheets

🕑 connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2431773453
🚀 Successfully published connectors/source-google-sheets
🚀 Auto-bumped version for connectors/source-google-sheets
✅ connectors/source-google-sheets https://github.com/airbytehq/airbyte/actions/runs/2431773453

* master: (142 commits) Highlight removed and added streams in Connection form (airbytehq#13392) 🐛 Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373) 🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450) Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388) 🎉 Source Freshdesk: Added new streams (airbytehq#13332) Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384) helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467) airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370) Change stage to `beta` (airbytehq#13422) 🐛 Source Google Sheets: Retry on server errors (airbytehq#13446) Improve kube deploy process. (airbytehq#13397) Helm chart dependencies fix (airbytehq#13432) 🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218) airbytehq#11758: Source Google Ads to GA (airbytehq#13441) Add more pr actions to tag pull requests (airbytehq#13437) Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423) Updates error view with new design (airbytehq#13197) Source MSSQL: correct enum Standard method (airbytehq#13419) Update postgres doc about cdc publication (airbytehq#13433) run source acceptance tests against image built from branch (airbytehq#13401) ...

Retry on server errors

9a67109

github-actions bot added the area/connectors Connector related issues label Jun 2, 2022

octavia-squidington-iii added the connectors/source/google-sheets label Jun 2, 2022

retry on any 5XX

ee4ea4e

bump version

fb060f4

github-actions bot added the area/documentation Improvements or additions to documentation label Jun 3, 2022

girarda changed the title ~~Retry on server errors~~ 🐛 Source Google Sheets: Retry on server errors Jun 3, 2022

girarda added 3 commits June 2, 2022 17:22

rename function for clarity

1c5e539

reset

c3c1c84

delete unused code

3bbee97

girarda marked this pull request as ready for review June 3, 2022 00:26

Merge branch 'master' into alex/googleSheetsRetry

2b8e911

girarda requested a review from brianjlai June 3, 2022 00:26

brianjlai approved these changes Jun 3, 2022

View reviewed changes

auto-bump connector version

e5fe0e5

octavia-squidington-iii temporarily deployed to more-secrets June 3, 2022 01:03 Inactive

girarda merged commit 19a20f0 into master Jun 3, 2022

girarda deleted the alex/googleSheetsRetry branch June 3, 2022 01:28

octavia-squidington-iii mentioned this pull request Jun 3, 2022

Bump Airbyte version from 0.39.8-alpha to 0.39.9-alpha #13454

Merged

davydov-d mentioned this pull request Apr 6, 2023

Google Sheets Source CHECK method should retry #13771

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 Source Google Sheets: Retry on server errors #13446

🐛 Source Google Sheets: Retry on server errors #13446

girarda commented Jun 2, 2022 •

edited

Loading

girarda commented Jun 2, 2022 •

edited by github-actions bot

Loading

girarda commented Jun 2, 2022 •

edited by github-actions bot

Loading

codecov bot commented Jun 3, 2022 •

edited

Loading

brianjlai left a comment

girarda commented Jun 3, 2022 •

edited by github-actions bot

Loading

🐛 Source Google Sheets: Retry on server errors #13446

🐛 Source Google Sheets: Retry on server errors #13446

Conversation

girarda commented Jun 2, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

girarda commented Jun 2, 2022 • edited by github-actions bot Loading

Build Passed

girarda commented Jun 2, 2022 • edited by github-actions bot Loading

Build Passed

codecov bot commented Jun 3, 2022 • edited Loading

Codecov Report

brianjlai left a comment

Choose a reason for hiding this comment

girarda commented Jun 3, 2022 • edited by github-actions bot Loading

girarda commented Jun 2, 2022 •

edited

Loading

girarda commented Jun 2, 2022 •

edited by github-actions bot

Loading

girarda commented Jun 2, 2022 •

edited by github-actions bot

Loading

codecov bot commented Jun 3, 2022 •

edited

Loading

girarda commented Jun 3, 2022 •

edited by github-actions bot

Loading