Highlight removed and added streams in Connection form #13392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
teallarson
force-pushed
the
teal/highlight-removed-and-added-streams
branch
from
e56c669
to
b46ef2a
Compare
teallarson
changed the title
teallarson
changed the title
teallarson
changed the title
teallarson
commented
Jun 3, 2022
| @@ -223,7 +223,7 @@ export const CreationFormPage: React.FC = () => { | |||
|
|
|||
| return ( | |||
| <> | |||
| <HeadTitle titles={[{ id: "sources.newSourceTitle" }]} /> | |||
| <HeadTitle titles={[{ id: "connection.newConnectionTitle" }]} /> | |||
There was a problem hiding this comment.
Oops! Tiny bug fix.
edmundito
approved these changes
Jun 3, 2022
airbyte-webapp/src/views/Connection/CatalogTree/StreamHeader.module.scss
Outdated
Show resolved
Hide resolved
| margin-bottom: 29px; | ||
| max-height: 600px; | ||
| overflow-y: auto; | ||
| --webkit-overlay: true; |
There was a problem hiding this comment.
A bit weary of using this specific style. I couldn't find anything online about it. How does it work? Although it looks like this was copied over from the styled component.
There was a problem hiding this comment.
This was copied from what was originally there. I tried out Chrome, Firefox, and Safari and don't see that it makes any change if I remove the --webkit-overlay rule. Let's get it out of there.
airbyte-webapp/src/views/Connection/CatalogTree/StreamHeader.module.scss
Show resolved
Hide resolved
…thub.com/airbytehq/airbyte into teal/highlight-removed-and-added-streams
chebalski
added a commit
to BluestarGenomics/airbyte
that referenced
this pull request
Jul 25, 2022
* master: (142 commits) Highlight removed and added streams in Connection form (airbytehq#13392) 🐛 Source Amplitude: Fixed JSON Validator `date-time` validation (airbytehq#13373) 🐛 Source Mixpanel: publish v0.1.17 (airbytehq#13450) Fixed reverted PR: Fix cancel button when it doesn't provide feedback to the user + UX improvements (airbytehq#13388) 🎉 Source Freshdesk: Added new streams (airbytehq#13332) Prepare YamlSeedConfigPersistence for dependency injection (airbytehq#13384) helm chart: Support nodeSelector, tolerations and affinity on the booloader pod (airbytehq#11467) airbyte-api: add jackson model annotations to remove null values from responses (airbytehq#13370) Change stage to `beta` (airbytehq#13422) 🐛 Source Google Sheets: Retry on server errors (airbytehq#13446) Improve kube deploy process. (airbytehq#13397) Helm chart dependencies fix (airbytehq#13432) 🐛 Source HubSpot: Transform `contact_lists` data to comply with schema (airbytehq#13218) airbytehq#11758: Source Google Ads to GA (airbytehq#13441) Add more pr actions to tag pull requests (airbytehq#13437) Source Google Ads: drop schema field that filters out the data from stream (airbytehq#13423) Updates error view with new design (airbytehq#13197) Source MSSQL: correct enum Standard method (airbytehq#13419) Update postgres doc about cdc publication (airbytehq#13433) run source acceptance tests against image built from branch (airbytehq#13401) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Gives the user feedback on the Connection Replication view as to what streams will be enabled or disabled from their Sync upon saving their changes.
Also does some minor adjustments to spacing/sizing to match Figma more closely.
Closes #13326
How
The
CatalogTreenow calculatesvaluesagainstinitialValueson render and passes whether each stream's "enabled" state has changed to the stream's row in the table. The row uses that + whether or not it is enabled to render red/green and add the icon.Also migrated these components to .scss. For now, some of the shared components exist in two forms: in some places using styled components and in some using .scss as I didn't want to dive into making unrelated changes in this PR.
Recommended reading order
CatalogTree.tsxCatalogSection(.tsx and .module.scss)StreamHeader(.tsx and .module.scss)Notes for testing:
This feature is only turned on for editing (not creating) a connection. So you will need to create and save a connection, then revisit the Replication page.