-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlight removed and added streams in Connection form #13392
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
16b6f75
ugly but works
teallarson c2f7621
make it prettier
teallarson b46ef2a
move StreamHeader to scss modules, add CatalogSection scss
teallarson b8a53df
better... todo: spacing between rows, border radii
teallarson 3ce2149
fix size/spacing to match figma
teallarson b7f908c
bug fix - page title
teallarson 2702934
only show on edit mode
teallarson de19ba9
improve spacing of header rows
teallarson 9d340b4
fix styling for dropdown section
teallarson 7c288df
adjust styles for readonly mode
teallarson 2321610
Merge branch 'master' into teal/highlight-removed-and-added-streams
teallarson 336a575
Changes from PR review
teallarson f7a6532
Merge branch 'teal/highlight-removed-and-added-streams' of https://gi…
teallarson 36b6ab2
justify flex-end instead of end
teallarson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
airbyte-webapp/src/views/Connection/CatalogTree/CatalogSection.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
@use "../../../scss/colors"; | ||
|
||
.streamFieldTableContainer { | ||
margin-left: 83px; | ||
background: colors.$greyColor0; | ||
} | ||
|
||
.catalogSection:first-of-type > div:nth-child(1) > div:nth-child(3) { | ||
border-radius: 8px 8px 0 0; | ||
} | ||
|
||
.catalogSection:last-of-type > div:nth-child(1) > div:nth-child(3) { | ||
border-radius: 0 0 8px 8px; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
airbyte-webapp/src/views/Connection/CatalogTree/CatalogTree.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
// These are utility classes that will be used by multiple sub-components | ||
// of the CatalogTree component once we finish migrating to scss, | ||
// not only styles used directly in CatalogTree | ||
|
||
.headerCell { | ||
font-size: 10px; | ||
line-height: 13px; | ||
} | ||
|
||
.checkboxCell { | ||
@extend .headerCell; | ||
max-width: 43px; | ||
text-align: center; | ||
display: flex; | ||
flex-direction: row; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
airbyte-webapp/src/views/Connection/CatalogTree/StreamHeader.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
@use "../../../scss/colors"; | ||
@use "../../../scss/variables"; | ||
@forward "./CatalogTree.module.scss"; | ||
|
||
.removedStream { | ||
color: colors.$dangerColor; | ||
} | ||
|
||
.icon { | ||
margin-right: 7px; | ||
margin-top: -1px; | ||
&.plus { | ||
color: colors.$successColor; | ||
} | ||
&.minus { | ||
color: colors.$dangerColor; | ||
} | ||
} | ||
|
||
.streamRowCheckboxCell { | ||
width: 100%; | ||
display: flex; | ||
flex-direction: row; | ||
justify-content: flex-end; | ||
} | ||
|
||
.streamHeaderContent { | ||
background: colors.$greyColor0; | ||
teallarson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
transition: background-color variables.$transition; | ||
width: 100%; | ||
padding: 2px; | ||
padding-left: 10px; | ||
display: flex; | ||
flex-direction: row; | ||
align-items: center; | ||
vertical-align: middle; | ||
height: 50px; | ||
} | ||
|
||
.catalogSectionRow { | ||
height: 100%; | ||
white-space: nowrap; | ||
font-size: 12px; | ||
display: flex; | ||
flex-direction: row; | ||
margin-top: 18px; | ||
margin-bottom: 9px; | ||
} | ||
|
||
.redBackground { | ||
background-color: colors.$dangerColor14; | ||
} | ||
|
||
.greenBackground { | ||
background-color: colors.$successColor14; | ||
} | ||
|
||
.redBorder { | ||
border: 1px solid colors.$dangerColor; | ||
} | ||
|
||
.purpleBackground { | ||
background-color: colors.$primaryColor10; | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops! Tiny bug fix.