Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Source Recurly: adds state_checkpoint_interval to streams #13685

Merged

Conversation

mohamagdy
Copy link
Contributor

What

Add state_checkpoint_interval to Recurly source connector

🚨 User Impact 🚨

No user impact expected

Pre-merge Checklist

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Tests

Unit
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_account_coupon_redemptions_read_records ✓                                                                                           5% ▌
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_account_notes_read_records ✓                                                                                                       10% ▉
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_accounts_methods_client_method_name ✓                                                                                              14% █▌
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_add_ons_client_method_name ✓                                                                                                       19% █▉
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_billing_infos_client_method_name ✓                                                                                                 24% ██▍
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_coupons_methods_client_method_name ✓                                                                                               29% ██▉
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_credit_payments_read_records ✓                                                                                                     33% ███▍
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_export_dates_read_records ✓                                                                                                        38% ███▊
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_get_updated_state ✓                                                                                                                43% ████▍
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_invoices_methods_client_method_name ✓                                                                                              48% ████▊
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_line_items_methods_client_method_name ✓                                                                                            52% █████▎
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_measured_unit_client_method_name ✓                                                                                                 57% █████▊
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_plans_client_method_name ✓                                                                                                         62% ██████▎
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_read_records ✓                                                                                                                     67% ██████▋
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_read_records_with_begin_time ✓                                                                                                     71% ███████▎
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_read_records_with_end_time ✓                                                                                                       76% ███████▋
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_shipping_addresses_client_method_name ✓                                                                                            81% ████████▏
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_shipping_methods_client_method_name ✓                                                                                              86% ████████▋
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_subscriptions_client_method_name ✓                                                                                                 90% █████████▏
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_transactions_client_method_name ✓                                                                                                  95% █████████▌
 airbyte-integrations/connectors/source-recurly/unit_tests/test_streams.py::TestStreams.test_unique_coupons_read_records ✓                                                                                                     100% ██████████

Results (0.69s):
      21 passed
Integration
(3.9.7/envs/airbyte-recurly) ➜  source-recurly git:(add-state-checkpoint-to-recurly-stream) ✗ python -m pytest integration_tests.acceptance
Test session starts (platform: darwin, Python 3.9.7, pytest 6.1.2, pytest-sugar 0.9.4)
cachedir: .pytest_cache
rootdir: /Users/mohamedmagdy/projects/airbyte/airbyte, configfile: pytest.ini
plugins: sugar-0.9.4, timeout-1.4.2
collecting ...

Results (0.02s):

Copy link
Member

@marcosmarxm marcosmarxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please bump the Dockerfile version and the documentation.

@github-actions github-actions bot added the area/documentation Improvements or additions to documentation label Jun 12, 2022
@mohamagdy
Copy link
Contributor Author

please bump the Dockerfile version and the documentation.

Thanks @marcosmarxm for the review. Bumped the version of the Recurly connector to 0.4.1 here d8c462b

@marcosmarxm marcosmarxm self-assigned this Jun 14, 2022
@marcosmarxm
Copy link
Member

marcosmarxm commented Jun 14, 2022

/test connector=connectors/source-recurly

🕑 connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/2496855982
❌ connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/2496855982
🐛 https://gradle.com/s/dhdr72l4v3l7i

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_incremental.py::TestIncremental::test_read_sequential_slices[inputs0]
FAILED test_incremental.py::TestIncremental::test_state_with_abnormally_large_values[inputs0]
=================== 2 failed, 22 passed in 151.09s (0:02:31) ===================

@marcosmarxm
Copy link
Member

Sorry @mohamagdy havving problems with our CI.

@marcosmarxm
Copy link
Member

Our CI is failing because isn't possible to implement retry policy using current implementation.

@marcosmarxm
Copy link
Member

@mohamagdy I'm blocked to merge this waiting https://github.com/airbytehq/airbyte-internal-issues/issues/751. I'll be on vacation and only return 26-jul maybe after I'll have some time to fix that

@marcosmarxm
Copy link
Member

marcosmarxm commented Aug 10, 2022

/test connector=connectors/source-recurly

🕑 connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/2834035370
❌ connectors/source-recurly https://github.com/airbytehq/airbyte/actions/runs/2834035370
🐛 https://gradle.com/s/4lkvtexhsf6um

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED unit_tests/test_backward_compatibility.py::test_validate_previous_configs[Nested level: Narrowing a field enum should fail.]
	 
	 Results (160.10s):
	 �[32m     296 passed�[0m
	 �[31m       1 failed�[0m
	          - �[36m�[0mtest_backward_compatibility.py�[0m:918 �[31mtest_validate_previous_configs[Nested level: Narrowing a field enum should fail.]�[0m
	 /actions-runner/_work/airbyte/airbyte/airbyte-integrations/bases/source-acceptance-test/.venv/lib/python3.9/site-packages/coverage/control.py:788: CoverageWarning: No data was collected. (no-data-collected)
	   self._warn("No data was collected.", slug="no-data-collected")

> Task :airbyte-integrations:bases:source-acceptance-test:_unitTestCoverage FAILED

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.4/userguide/command_line_interface.html#sec:command_line_warnings

Execution optimizations have been disabled for 1 invalid unit(s) of work during this build to ensure correctness.
Please consult deprecation warnings for more details.
44 actionable tasks: 31 executed, 13 up-to-date

Publishing build scan...
https://gradle.com/s/4lkvtexhsf6um

@marcosmarxm marcosmarxm force-pushed the add-state-checkpoint-to-recurly-stream branch from d8c462b to 910133b Compare August 10, 2022 16:03
@marcosmarxm
Copy link
Member

marcosmarxm commented Aug 11, 2022

/publish connector=connectors/source-recurly run-tests=false

🕑 Publishing the following connectors:
connectors/source-recurly
https://github.com/airbytehq/airbyte/actions/runs/2840254239


Connector Did it publish? Were definitions generated?
connectors/source-recurly

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@marcosmarxm marcosmarxm changed the title Add state_checkpoint_interval to Recurly stream Source Recurly: adds state_checkpoint_interval to streams Aug 11, 2022
@marcosmarxm marcosmarxm merged commit 273537a into airbytehq:master Aug 11, 2022
girarda pushed a commit that referenced this pull request Aug 11, 2022
* Add `state_checkpoint_interval` to Recurly stream

* Bumpg Recurly source version to `0.4.1`
girarda added a commit that referenced this pull request Aug 12, 2022
* greenhouse minus pagination

* jobs

* first substream

* rename field

* applications_demographics_answers_stream

* interviews

* All streams are implemented

* fix check

* fix spec

* disable backward compatibility tests

* disable backward compatibility tests

* unit tests

* definitions

* only use config.json

* bump version

* expected records

* delete stream classes

* Handle extracting no records from root

* handle missing keys

* Remove unused field from JsonSchema (#15425)

* few fixes from working with sendgrid

* reset to master

* only update the docstring

* reset

* 🎉 Source File - add support for custom encoding (#15293)

* added support for custom encoding

* fixed unit test for utf16

* updated docs

* bumped connector version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* change query frequency to 1hour (#15499)

* [low-code connectors]: Assert there are no custom top-level fields (#15489)

* move components to definitions field

* Also update the references

* validate the top level fields and add version

* raise exception on unknown fields

* newline

* unit tests

* set version to 0.1.0

* newline

* 🐞 Postgres source: fix bug in intermediate state emission (#15496)

* Rename record counter

* Rename method

* Emit intermediate state after all cursor records

* Emit intermediate state only when it is ready

* Merge two checks

* Add a testing message

* Fix unit tests

* Add one more testing record and add comments

* Add test case for multiple records with the same cursor value

* Revert irrelevant change

* Add explanation in javadoc

* Format code

* Rename testing methods

* Fix comment

* Bump version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* 🪟 🔧 Add testing and storybook component for CatalogDiffModal (#15426)

* wip diff modal test setup

* starting storybook add

* storybook working now

* cleanup

* aria labels

* test syncmode string

* 🎉 New Source: Hubplanner (#15521)

* added hubplanner source connector

* feat: added more streams to read from

* cleaned up some unneeded integration tests

* fix hubplanner schema

* changes

* update dockerfile

* add seed and doc

* update spec

* run source spec seed file

Co-authored-by: Ricky Renner <renner@amendllc.com>

* Make it possible to specify normalization pod resources. (#15495)

Today we are running into OOM exceptions with normalization. Normalization itself also inherits the destination's resource requirements. After work to bring destination memory usage down, this is no longer ideal, since most destinations use less memory than normalization needs.

This PR makes it possible to specify the general resource the normalization pod is provided via env vars.

Notes:
- Add env vars. Default to the various job main container resources if these are not set.
- Instead of using the destination's memory, use the normalization specify env vars.

* [low-code connectors] Extract datetime parser and handle %s format directive (#15429)

* fix parse

* Revert "fix parse"

This reverts commit 3c76c5a.

* fix parse timestamp

* extract datetime parser

* remove print

* use parser

* top level docstring

* rename variable

* do not use timestamp()

* Revert "do not use timestamp()"

This reverts commit 016cb69.

* update comment

* bump cdk version

* Update template

* source-file-secure bump to 0.2.16 (#15528)

* update Dockerfile version

* update init to accept additional args

* unit test sendgrid messages stream (#15331)

* unit test sendgrid messages stream

* reset

* Update airbyte-integrations/connectors/source-sendgrid/unit_tests/unit_test.py

Co-authored-by: Augustin <augustin.lafanechere@gmail.com>

Co-authored-by: Augustin <augustin.lafanechere@gmail.com>

* record extractor interface

* dpath extractor

* docstring

* 🎉 Source File: cache binary stream to file (#15501)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

* Docs: update posthog.md (#15541)

* Source Stripe: implement slicing (#15292)

* #45 oncall - source Stripe: implement slicing

* #45 source stripe: upd changelog

* #45 source stripe: upd changelog

* #45 source stripe: make slice range configurable

* #45 source stripe: move generating a single slice into a mixin

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* fix: revert extraEnv delition in values.yaml for bootloader (#15548)

* fix: revert extraEnv delition in values.yaml for bootloader

* add newline

* SAT: backward compatibility - check that cursor fields were not changed (#15520)

* Replace twttr repo to the root build.gradle (#15544)

* Fixed bucket naming for S3

* replaced twttr repo to the root build.gradle

* replaced twttr repo to the root build.gradle

Co-authored-by: Oleksandr Sheheda <alexandr-shegeda@users.noreply.github.com>

* Generate separate server endpoints per domain (#15513)

* 🐛 Backward compatibility test: Don't fail on updating additionalProperties (#15532)

* Source Recurly: adds `state_checkpoint_interval` to streams (#13685)

* Add `state_checkpoint_interval` to Recurly stream

* Bumpg Recurly source version to `0.4.1`

* reset

* use dpath

* enable backward compatibility test

* infer types

* Revert "infer types"

This reverts commit b4de8d6.

* infer some of the types

* some drying

* more drying

* auto-bump connector version [ci skip]

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Co-authored-by: midavadim <midavadim@yahoo.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Xiaohan Song <xiaohan@airbyte.io>
Co-authored-by: Liren Tu <tuliren.git@outlook.com>
Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: Ricky Renner <renner@amendllc.com>
Co-authored-by: Davin Chia <davinchia@gmail.com>
Co-authored-by: Brian Lai <51336873+brianjlai@users.noreply.github.com>
Co-authored-by: Augustin <augustin.lafanechere@gmail.com>
Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
Co-authored-by: juliatournant <39640564+juliatournant@users.noreply.github.com>
Co-authored-by: Denys Davydov <davydov.den18@gmail.com>
Co-authored-by: Kyryl Skobylko <xpuska513@gmail.com>
Co-authored-by: VitaliiMaltsev <39538064+VitaliiMaltsev@users.noreply.github.com>
Co-authored-by: Oleksandr Sheheda <alexandr-shegeda@users.noreply.github.com>
Co-authored-by: Jonathan Pearlin <jonathan@airbyte.io>
Co-authored-by: Mohamed Magdy <mohamed.magdy@canary.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation bounty community connectors/source/recurly
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants