Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉 Source File: cache binary stream to file #15501

Merged
merged 8 commits into from
Aug 11, 2022

Conversation

grubberr
Copy link
Contributor

@grubberr grubberr commented Aug 10, 2022

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

  1. pd.read_excel is Random Access Read, it does a lot of read, seek calls.
  2. All this seek and after read calls under the hood are separate HTTP requests with different byte-ranges.
  3. Because a lot of HTTP requests, after some time we get HTTP Response: 429, Too Many Requests
  4. smart_open cannot handle it
    https://github.com/RaRe-Technologies/smart_open/blob/develop/smart_open/http.py#L314
    for upper level it looks like read call returned empty buffer

How

To avoid multiple HTTP requests, we can cache binary streams to file

Recommended reading order

  1. x.java
  2. y.python

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

  • Grant edit access to maintainers (instructions)
  • Secrets in the connector's spec are annotated with airbyte_secret
  • Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
  • Code reviews completed
  • Documentation updated
    • Connector's README.md
    • Connector's bootstrap.md. See description and examples
    • Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
  • PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

  • Create a non-forked branch based on this PR and test the below items on it
  • Build is successful
  • If new credentials are required for use in CI, add them to GSM. Instructions.
  • /test connector=connectors/<name> command is passing
  • New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@github-actions github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Aug 10, 2022
@grubberr
Copy link
Contributor Author

grubberr commented Aug 10, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2830567139
❌ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2830567139
🐛 https://gradle.com/s/pwyykwn6t6moi

Build Failed

Test summary info:

	 =========================== short test summary info ============================
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[ssh-files/test.csv-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[scp-files/test.csv-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[sftp-files/test.csv-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_ssh[ssh-files/test.csv.gz-csv]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[HTTPS-https:/storage.googleapis.com/covid19-open-data/v2/latest/epidemiology.csv-10-,-True]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[HTTPS-storage.googleapis.com/covid19-open-data/v2/latest/epidemiology.csv-10-,-True]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[local-injected by tests-10-,-True]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[GCS-gs:/gcp-public-data-landsat/index.csv.gz-18-,-True0]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[GCS-gs:/gcp-public-data-landsat/index.csv.gz-18-,-True1]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[S3-s3:/gdelt-open-data/events/20190914.export.csv-58-\\t-False0]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_provider[S3-s3:/gdelt-open-data/events/20190914.export.csv-58-\\t-False1]
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_gcs
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_aws
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_public_azblob
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_azblob_shared_key
	 FAILED integration_tests/client_storage_providers_test.py::test__read_from_private_azblob_sas_token
	 FAILED integration_tests/file_formats_test.py::test_local_file_read[csv-csv-8-5000-demo]
	 �[31m================== �[31m�[1m17 failed�[0m, �[32m15 passed�[0m�[31m in 645.61s (0:10:45)�[0m�[31m ===================�[0m

@grubberr grubberr linked an issue Aug 10, 2022 that may be closed by this pull request
@grubberr grubberr self-assigned this Aug 10, 2022
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Aug 10, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2830929646
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2830929646
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        82      6    93%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  77     17    78%
source_acceptance_test/tests/test_core.py              355    107    70%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                 1023    247    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       265     39    85%
source_file/source.py        50     35    30%
---------------------------------------------
TOTAL                       317     74    77%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/source.py        50     27    46%
source_file/client.py       265    165    38%
---------------------------------------------
TOTAL                       317    192    39%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 29 passed, 1 skipped in 54.50s ========================

…e with SAT tests

move boto3==1.21.21 to main reqs

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Aug 10, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2831003994
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2831003994
Python tests coverage:

	 Name                                                     Stmts   Miss  Cover   Missing
	 --------------------------------------------------------------------------------------
	 source_acceptance_test/base.py                              10      4    60%   15-18
	 source_acceptance_test/config.py                            82      6    93%   75-77, 81-83
	 source_acceptance_test/conftest.py                         153    153     0%   6-263
	 source_acceptance_test/plugin.py                            48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py                  320    105    67%   40, 60-68, 73-80, 84-85, 89-90, 174, 216-233, 240-245, 251, 284-289, 314-321, 361-363, 366, 426-435, 464-465, 471, 474, 507-517, 530-555, 560-564
	 source_acceptance_test/tests/test_full_refresh.py           52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py           121     25    79%   21-23, 29-31, 36-43, 48-61, 208-214
	 source_acceptance_test/utils/asserts.py                     37      2    95%   57-58
	 source_acceptance_test/utils/backward_compatibility.py      77      8    90%   66-73, 93, 95, 105, 152-153
	 source_acceptance_test/utils/common.py                      77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                     62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py           110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py         105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 --------------------------------------------------------------------------------------
	 TOTAL                                                     1266    454    64%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       265     39    85%
source_file/source.py        50     35    30%
---------------------------------------------
TOTAL                       317     74    77%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/source.py        50     27    46%
source_file/client.py       265    165    38%
---------------------------------------------
TOTAL                       317    192    39%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 25 passed, 1 skipped in 59.38s ========================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
@grubberr
Copy link
Contributor Author

grubberr commented Aug 11, 2022

/test connector=connectors/source-file

🕑 connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2838092747
✅ connectors/source-file https://github.com/airbytehq/airbyte/actions/runs/2838092747
Python tests coverage:

Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       262     39    85%
source_file/source.py        50     35    30%
---------------------------------------------
TOTAL                       314     74    76%
Name                      Stmts   Miss  Cover
---------------------------------------------
source_file/__init__.py       2      0   100%
source_file/client.py       262    123    53%
source_file/source.py        50     27    46%
---------------------------------------------
TOTAL                       314    150    52%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              338    111    67%   40, 60-68, 73-80, 84-85, 89-90, 174, 216-233, 253-261, 265-270, 276, 309-314, 356-363, 403-405, 408, 468-477, 506-507, 513, 516, 549-559, 572-597, 602-606
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-214
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1311    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
=================== 26 passed, 1 skipped in 60.67s (0:01:00) ===================

@grubberr grubberr changed the title 🎉 Source File: cache stream to file 🎉 Source File: cache binary stream to file Aug 11, 2022
@grubberr
Copy link
Contributor Author

grubberr commented Aug 11, 2022

/publish connector=connectors/source-file

🕑 Publishing the following connectors:
connectors/source-file
https://github.com/airbytehq/airbyte/actions/runs/2838227228


Connector Did it publish? Were definitions generated?
connectors/source-file

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr
Copy link
Contributor Author

grubberr commented Aug 11, 2022

/test connector=connectors/source-file-secure

🕑 connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/2838375568
✅ connectors/source-file-secure https://github.com/airbytehq/airbyte/actions/runs/2838375568
Python tests coverage:

Name                                                                                                        Stmts   Miss  Cover
-------------------------------------------------------------------------------------------------------------------------------
source_file_secure/__init__.py                                                                                  2      0   100%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/__init__.py       2      0   100%
source_file_secure/source.py                                                                                   45     10    78%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/source.py        50     31    38%
/actions-runner/_work/airbyte/airbyte/airbyte-integrations/connectors/source-file/source_file/client.py       262    196    25%
-------------------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                                         361    237    34%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              338    111    67%   40, 60-68, 73-80, 84-85, 89-90, 174, 216-233, 253-261, 265-270, 276, 309-314, 356-363, 403-405, 408, 468-477, 506-507, 513, 516, 549-559, 572-597, 602-606
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-214
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1311    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:60: Skipping TestIncremental.test_two_sequential_reads because not found in the config
======================== 26 passed, 2 skipped in 47.94s ========================

@grubberr
Copy link
Contributor Author

grubberr commented Aug 11, 2022

/publish connector=connectors/source-file-secure

🕑 Publishing the following connectors:
connectors/source-file-secure
https://github.com/airbytehq/airbyte/actions/runs/2838464953


Connector Did it publish? Were definitions generated?
connectors/source-file-secure

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@grubberr grubberr merged commit 5eef51a into master Aug 11, 2022
@grubberr grubberr deleted the grubberr/5537-source-file-cache-stream branch August 11, 2022 08:56
girarda pushed a commit that referenced this pull request Aug 11, 2022
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
girarda added a commit that referenced this pull request Aug 12, 2022
* greenhouse minus pagination

* jobs

* first substream

* rename field

* applications_demographics_answers_stream

* interviews

* All streams are implemented

* fix check

* fix spec

* disable backward compatibility tests

* disable backward compatibility tests

* unit tests

* definitions

* only use config.json

* bump version

* expected records

* delete stream classes

* Handle extracting no records from root

* handle missing keys

* Remove unused field from JsonSchema (#15425)

* few fixes from working with sendgrid

* reset to master

* only update the docstring

* reset

* 🎉 Source File - add support for custom encoding (#15293)

* added support for custom encoding

* fixed unit test for utf16

* updated docs

* bumped connector version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* change query frequency to 1hour (#15499)

* [low-code connectors]: Assert there are no custom top-level fields (#15489)

* move components to definitions field

* Also update the references

* validate the top level fields and add version

* raise exception on unknown fields

* newline

* unit tests

* set version to 0.1.0

* newline

* 🐞 Postgres source: fix bug in intermediate state emission (#15496)

* Rename record counter

* Rename method

* Emit intermediate state after all cursor records

* Emit intermediate state only when it is ready

* Merge two checks

* Add a testing message

* Fix unit tests

* Add one more testing record and add comments

* Add test case for multiple records with the same cursor value

* Revert irrelevant change

* Add explanation in javadoc

* Format code

* Rename testing methods

* Fix comment

* Bump version

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* 🪟 🔧 Add testing and storybook component for CatalogDiffModal (#15426)

* wip diff modal test setup

* starting storybook add

* storybook working now

* cleanup

* aria labels

* test syncmode string

* 🎉 New Source: Hubplanner (#15521)

* added hubplanner source connector

* feat: added more streams to read from

* cleaned up some unneeded integration tests

* fix hubplanner schema

* changes

* update dockerfile

* add seed and doc

* update spec

* run source spec seed file

Co-authored-by: Ricky Renner <renner@amendllc.com>

* Make it possible to specify normalization pod resources. (#15495)

Today we are running into OOM exceptions with normalization. Normalization itself also inherits the destination's resource requirements. After work to bring destination memory usage down, this is no longer ideal, since most destinations use less memory than normalization needs.

This PR makes it possible to specify the general resource the normalization pod is provided via env vars.

Notes:
- Add env vars. Default to the various job main container resources if these are not set.
- Instead of using the destination's memory, use the normalization specify env vars.

* [low-code connectors] Extract datetime parser and handle %s format directive (#15429)

* fix parse

* Revert "fix parse"

This reverts commit 3c76c5a.

* fix parse timestamp

* extract datetime parser

* remove print

* use parser

* top level docstring

* rename variable

* do not use timestamp()

* Revert "do not use timestamp()"

This reverts commit 016cb69.

* update comment

* bump cdk version

* Update template

* source-file-secure bump to 0.2.16 (#15528)

* update Dockerfile version

* update init to accept additional args

* unit test sendgrid messages stream (#15331)

* unit test sendgrid messages stream

* reset

* Update airbyte-integrations/connectors/source-sendgrid/unit_tests/unit_test.py

Co-authored-by: Augustin <augustin.lafanechere@gmail.com>

Co-authored-by: Augustin <augustin.lafanechere@gmail.com>

* record extractor interface

* dpath extractor

* docstring

* 🎉 Source File: cache binary stream to file (#15501)

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

* Docs: update posthog.md (#15541)

* Source Stripe: implement slicing (#15292)

* #45 oncall - source Stripe: implement slicing

* #45 source stripe: upd changelog

* #45 source stripe: upd changelog

* #45 source stripe: make slice range configurable

* #45 source stripe: move generating a single slice into a mixin

* auto-bump connector version [ci skip]

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

* fix: revert extraEnv delition in values.yaml for bootloader (#15548)

* fix: revert extraEnv delition in values.yaml for bootloader

* add newline

* SAT: backward compatibility - check that cursor fields were not changed (#15520)

* Replace twttr repo to the root build.gradle (#15544)

* Fixed bucket naming for S3

* replaced twttr repo to the root build.gradle

* replaced twttr repo to the root build.gradle

Co-authored-by: Oleksandr Sheheda <alexandr-shegeda@users.noreply.github.com>

* Generate separate server endpoints per domain (#15513)

* 🐛 Backward compatibility test: Don't fail on updating additionalProperties (#15532)

* Source Recurly: adds `state_checkpoint_interval` to streams (#13685)

* Add `state_checkpoint_interval` to Recurly stream

* Bumpg Recurly source version to `0.4.1`

* reset

* use dpath

* enable backward compatibility test

* infer types

* Revert "infer types"

This reverts commit b4de8d6.

* infer some of the types

* some drying

* more drying

* auto-bump connector version [ci skip]

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
Co-authored-by: midavadim <midavadim@yahoo.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Co-authored-by: Xiaohan Song <xiaohan@airbyte.io>
Co-authored-by: Liren Tu <tuliren.git@outlook.com>
Co-authored-by: Teal Larson <LARSON.TEAL@GMAIL.COM>
Co-authored-by: Marcos Marx <marcosmarxm@users.noreply.github.com>
Co-authored-by: Ricky Renner <renner@amendllc.com>
Co-authored-by: Davin Chia <davinchia@gmail.com>
Co-authored-by: Brian Lai <51336873+brianjlai@users.noreply.github.com>
Co-authored-by: Augustin <augustin.lafanechere@gmail.com>
Co-authored-by: Serhii Chvaliuk <grubberr@gmail.com>
Co-authored-by: juliatournant <39640564+juliatournant@users.noreply.github.com>
Co-authored-by: Denys Davydov <davydov.den18@gmail.com>
Co-authored-by: Kyryl Skobylko <xpuska513@gmail.com>
Co-authored-by: VitaliiMaltsev <39538064+VitaliiMaltsev@users.noreply.github.com>
Co-authored-by: Oleksandr Sheheda <alexandr-shegeda@users.noreply.github.com>
Co-authored-by: Jonathan Pearlin <jonathan@airbyte.io>
Co-authored-by: Mohamed Magdy <mohamed.magdy@canary.is>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/file connectors/source/file-secure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Source File: ability to get HTTPS attachments
3 participants