-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Source RKI (Robert Koch-Institut): add message when no data available #15667
Conversation
@Zawar92 can you check the other files changes in the PR? |
@Zawar92 please check your commit. You're changing other files besides what you're describing in the PR. |
@marcosmarxm
|
not what your PR is doing. Check the files changed here in Github web |
Yes those files must have changed when I took the new pull from main. Then executed gradlew for:
|
You can run the command and remove the other files OR run |
861c87e
to
39b1a16
Compare
/test connector=connectors/source-rki-covid
Build FailedTest summary info:
|
/test connector=connectors/source-rki-covid
Build PassedTest summary info:
|
…le (#15667) * updated parse_response with a message. * updated test and executed gradlew * updated unit tests. * applied gradlew with no daemon for airbyte python format * change addProperties to true * update docs Co-authored-by: marcosmarxm <marcosmarxm@gmail.com>
What
In the connector source-rki-covid there are times when data is not available for a certain date. In order to avoid error condition added.
Related Issue
How
Adding the message when data not available for specific date.
Recommended reading order
x.java
y.python
🚨 User Impact 🚨
Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.
Pre-merge Checklist
Expand the relevant checklist and delete the others.
New Connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampledocs/integrations/README.md
airbyte-integrations/builds.md
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereUpdating a connector
Community member or Airbyter
airbyte_secret
./gradlew :airbyte-integrations:connectors:<name>:integrationTest
.README.md
bootstrap.md
. See description and examplesdocs/integrations/<source or destination>/<name>.md
including changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>
command is passing/publish
command described hereConnector Generator
-scaffold
in their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates
then checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.