Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Source RKI (Robert Koch-Institut): add message when no data available #15667

Merged
merged 6 commits into from
Aug 25, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -30,5 +30,5 @@ COPY source_rki_covid ./source_rki_covid
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]

LABEL io.airbyte.version=0.1.1
LABEL io.airbyte.version=0.1.2
LABEL io.airbyte.name=airbyte/source-rki-covid
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ def cursor_field(self) -> str:

def date_to_int(self, start_date) -> int:
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return 1
return diff.days

Expand All @@ -128,7 +128,9 @@ def read_records(self, stream_state: Mapping[str, Any] = None, **kwargs) -> Iter
yield from records

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
return response.json().get("data")
if response.json().get("data"):
return response.json().get("data")
return [{}]

def path(
self, stream_state: Mapping[str, Any] = None, stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
Expand Down Expand Up @@ -158,7 +160,7 @@ def cursor_field(self) -> str:

def date_to_int(self, start_date) -> int:
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return 1
return diff.days

Expand All @@ -179,7 +181,7 @@ def read_records(self, stream_state: Mapping[str, Any] = None, **kwargs) -> Iter
def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
if response.json().get("data"):
return response.json().get("data")
pass
return [{}]

def path(
self, stream_state: Mapping[str, Any] = None, stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
Expand Down Expand Up @@ -209,7 +211,7 @@ def cursor_field(self) -> str:

def date_to_int(self, start_date) -> int:
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return 1
return diff.days

Expand All @@ -228,7 +230,9 @@ def read_records(self, stream_state: Mapping[str, Any] = None, **kwargs) -> Iter
yield from records

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
return response.json().get("data")
if response.json().get("data"):
return response.json().get("data")
return [{}]

def path(
self, stream_state: Mapping[str, Any] = None, stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
Expand Down Expand Up @@ -258,7 +262,7 @@ def cursor_field(self) -> str:

def date_to_int(self, start_date) -> int:
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return 1
return diff.days

Expand All @@ -277,7 +281,9 @@ def read_records(self, stream_state: Mapping[str, Any] = None, **kwargs) -> Iter
yield from records

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
return response.json().get("data")
if response.json().get("data"):
return response.json().get("data")
return [{}]

def path(
self, stream_state: Mapping[str, Any] = None, stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
Expand Down Expand Up @@ -307,7 +313,7 @@ def cursor_field(self) -> str:

def date_to_int(self, start_date) -> int:
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return 1
return diff.days

Expand All @@ -326,7 +332,9 @@ def read_records(self, stream_state: Mapping[str, Any] = None, **kwargs) -> Iter
yield from records

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
return response.json().get("data").get("history")
if response.json().get("data"):
return response.json().get("data").get("history")
return [{}]

def path(
self, stream_state: Mapping[str, Any] = None, stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
Expand Down Expand Up @@ -356,7 +364,7 @@ def cursor_field(self) -> str:

def date_to_int(self, start_date) -> int:
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return 1
return diff.days

Expand All @@ -375,7 +383,9 @@ def read_records(self, stream_state: Mapping[str, Any] = None, **kwargs) -> Iter
yield from records

def parse_response(self, response: requests.Response, **kwargs) -> Iterable[Mapping]:
return response.json().get("data")
if response.json().get("data"):
return response.json().get("data")
return [{}]

def path(
self, stream_state: Mapping[str, Any] = None, stream_slice: Mapping[str, Any] = None, next_page_token: Mapping[str, Any] = None
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"title": "RKI Covid Spec",
"type": "object",
"required": ["start_date"],
"additionalProperties": false,
"additionalProperties": true,
"properties": {
"start_date": {
"type": "string",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

@fixture
def patch_incremental_german_history_cases(mocker):
# Mock abstract methods to enable instantiating abstract class
# Mock abstract methods to enable instantiating abstract class.
mocker.patch.object(GermanyHistoryCases, "primary_key", None)


Expand All @@ -27,13 +27,17 @@ def test_parse_response(patch_incremental_german_history_cases):
config = {"start_date": "2022-04-27"}
stream = GermanyHistoryCases(config)
response = requests.get("https://api.corona-zahlen.org/germany/history/cases/1")
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
if response.json().get("data"):
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
else:
expected_response = [{}]
assert stream.parse_response(response) == expected_response


def check_diff(start_date):
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return str(1)
return str(diff.days)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,17 @@ def test_parse_response(patch_incremental_german_history_deaths):
config = {"start_date": "2022-04-27"}
stream = GermanHistoryDeaths(config)
response = requests.get("https://api.corona-zahlen.org/germany/history/deaths/1")
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
if response.json().get("data"):
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
else:
expected_response = [{}]
assert stream.parse_response(response) == expected_response


def check_diff(start_date):
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return str(1)
return str(diff.days)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,17 @@ def test_parse_response(patch_incremental_german_history_frozenInc):
config = {"start_date": "2022-04-27"}
stream = GermanHistoryFrozenIncidence(config)
response = requests.get("https://api.corona-zahlen.org/germany/history/frozen-incidence/1")
expected_response = response.json().get("data").get("history")
assert stream.parse_response(response) == expected_response
if response.json().get("data").get("history"):
expected_response = response.json().get("data").get("history")
assert stream.parse_response(response) == expected_response
else:
expected_response = []
assert stream.parse_response(response) == expected_response


def check_diff(start_date):
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return str(1)
return str(diff.days)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,17 @@ def test_parse_response(patch_incremental_german_history_hospitalization):
config = {"start_date": "2022-04-27"}
stream = GermanHistoryHospitalization(config)
response = requests.get("https://api.corona-zahlen.org/germany/history/hospitalization/1")
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
if response.json().get("data"):
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
else:
expected_response = [{}]
assert stream.parse_response(response) == expected_response


def check_diff(start_date):
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return str(1)
return str(diff.days)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,17 @@ def test_parse_response(patch_incremental_german_history_incidence):
config = {"start_date": "2022-04-27"}
stream = GermanHistoryIncidence(config)
response = requests.get("https://api.corona-zahlen.org/germany/history/incidence/1")
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
if response.json().get("data"):
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
else:
expected_response = [{}]
assert stream.parse_response(response) == expected_response


def check_diff(start_date):
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return str(1)
return str(diff.days)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,17 @@ def test_parse_response(patch_incremental_german_history_recovered):
config = {"start_date": "2022-04-27"}
stream = GermanHistoryRecovered(config)
response = requests.get("https://api.corona-zahlen.org/germany/history/recovered/1")
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
if response.json().get("data"):
expected_response = response.json().get("data")
assert stream.parse_response(response) == expected_response
else:
expected_response = [{}]
assert stream.parse_response(response) == expected_response


def check_diff(start_date):
diff = datetime.now() - datetime.strptime(start_date, "%Y-%m-%d")
if diff.days == 0:
if diff.days <= 0:
return str(1)
return str(diff.days)

Expand Down
1 change: 1 addition & 0 deletions docs/integrations/sources/rki-covid.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,5 +53,6 @@ Select start date

| Version | Date | Pull Request | Subject |
| :--- | :--- | :--- | :--- |
| 0.1.2 | 2022-08-25 | [15667](https://github.com/airbytehq/airbyte/pull/15667) | Add message when no data available |
| 0.1.1 | 2022-05-30 | [11732](https://github.com/airbytehq/airbyte/pull/11732) | Fix docs |
| 0.1.0 | 2022-05-30 | [11732](https://github.com/airbytehq/airbyte/pull/11732) | Initial Release |