-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve airbyte-metrics support in the Helm chart #16166
Merged
xpuska513
merged 4 commits into
airbytehq:master
from
milesarmstrong:miles/16129-airbyte-metrics-helm
Sep 2, 2022
Merged
Improve airbyte-metrics support in the Helm chart #16166
xpuska513
merged 4 commits into
airbytehq:master
from
milesarmstrong:miles/16129-airbyte-metrics-helm
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
issues related to the platform
kubernetes
labels
Aug 31, 2022
milesarmstrong
force-pushed
the
miles/16129-airbyte-metrics-helm
branch
from
August 31, 2022 12:02
2f96e26
to
7854d02
Compare
xpuska513
approved these changes
Sep 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
letiescanciano
added a commit
that referenced
this pull request
Sep 5, 2022
* master: (47 commits) Add email to identify users analytics call (#16327) 🎉 Source Amazon Ads: improve `config.start_date` validation (#16191) Add comments about intermediate state emission (#16262) MySQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16216) MSSQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16215) Hide a bunch more destination with potential unsecure API access (#16320) Skip unit tests when run-tests is false (#16267) Hide Destination connections from UI (#16310) Add scheduled task to clean up old files from workspace (#16247) Source Google Analytics v4: Re-name google analytics connector (#16306) 🐛 Source Facebook Marketing: remove "end_date" from config if empty value (re-implement #16096) (#16222) Fix github action syntax (#16277) Re-name google analytics cionnectors (#16287) Bump Airbyte version from 0.40.3 to 0.40.4 (#16275) Hide ES and Redis destination connectors from Cloud (#16276) 15700 add tests for PokeAPI (#15701) Add ProtocolVersion to StandardDefs (#16237) 🪟 🔧 🧹 Migrate attempt `bytesSynced` to `totalStats.bytesEmitted` and cleanup `AttemptDetails` component (#16126) Improve behavior of password input field (#16011) Improve airbyte-metrics support in the Helm chart (#16166) ...
xpuska513
added a commit
that referenced
this pull request
Sep 9, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * add step to install unzip * fix incorrect command spelling(helm) * update slack notification sending for Airbyte CI workflow * Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * do a small testing for sake of science * Update test chart.yaml with note block * Revert changes for AC tests * fix: Include #16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs Co-authored-by: Davin Chia <davinchia@gmail.com>
xpuska513
added a commit
that referenced
this pull request
Sep 9, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * fix: add step to install unzip * fix incorrect command spelling(helm) * fix: update slack notification sending for Airbyte CI workflow * fix: Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * fix: do a small testing for sake of science * fix: Update test chart.yaml with note block * fix: Revert changes for AC tests * fix: Include #16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs * fix: update helm-docs * fix: revert changes to ingress Co-authored-by: Davin Chia <davinchia@gmail.com>
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Add a new airbyte-metrics Helm chart * Include metrics Chart as a dependency of the main airbyte Chart * Allow setting METRIC_CLIENT and OTEL_COLLECTOR_ENDPOINT from Helm values * Actually make metrics sub-chart disabled by default
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * add step to install unzip * fix incorrect command spelling(helm) * update slack notification sending for Airbyte CI workflow * Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * do a small testing for sake of science * Update test chart.yaml with note block * Revert changes for AC tests * fix: Include airbytehq#16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs Co-authored-by: Davin Chia <davinchia@gmail.com>
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * fix: add step to install unzip * fix incorrect command spelling(helm) * fix: update slack notification sending for Airbyte CI workflow * fix: Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * fix: do a small testing for sake of science * fix: Update test chart.yaml with note block * fix: Revert changes for AC tests * fix: Include airbytehq#16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs * fix: update helm-docs * fix: revert changes to ingress Co-authored-by: Davin Chia <davinchia@gmail.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Add a new airbyte-metrics Helm chart * Include metrics Chart as a dependency of the main airbyte Chart * Allow setting METRIC_CLIENT and OTEL_COLLECTOR_ENDPOINT from Helm values * Actually make metrics sub-chart disabled by default
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * add step to install unzip * fix incorrect command spelling(helm) * update slack notification sending for Airbyte CI workflow * Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * do a small testing for sake of science * Update test chart.yaml with note block * Revert changes for AC tests * fix: Include airbytehq#16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs Co-authored-by: Davin Chia <davinchia@gmail.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* fix: revert extraEnv. Move updated extraEnv to env_vars * fix: Add node pool selector feature for gke deployments * fix: hotfix. Fix webapp values and imagepullsecrets * fix: remove nodeSelector duplicate * fix: revert imagePullSecrets changes * fix nit * fix: fix bootloader imagepullsecrets * fix: fix image pull secrets again... * feat: add acceptance tests for helm * fix: add step to install unzip * fix incorrect command spelling(helm) * fix: update slack notification sending for Airbyte CI workflow * fix: Rename Helm E2E test report name * fix: Update helm charts * fix: fix temporal DB Port bug * fix nits * fix: do a small testing for sake of science * fix: Update test chart.yaml with note block * fix: Revert changes for AC tests * fix: Include airbytehq#16166 * fix: add metrics to the ci workflow * fix: revert changes for temporal service. move them to server service; * fix: revert fullstory deletion * fix: change way of defining image tag and make it to be set in global values. Add values.yaml.test for integration testing and local deployment * fix: udpate docs, update values.yaml * fix: fix helpers.tpl in all subcharts * Update chart docs * fix: update helm-docs * fix: revert changes to ingress Co-authored-by: Davin Chia <davinchia@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This change enables (optional) deployment of the airbyte metrics-reporter via a new Helm chart. It also allows configuration of metrics-related environment variables from the main airbyte Helm chart.
Resolving: #16129
How
METRIC_CLIENT
andOTEL_COLLECTOR_ENDPOINT
in theairbyte-env
ConfigMap.Recommended reading order
charts/airbyte-metrics
charts/airbyte/Chart.yaml
) and values (charts/airbyte/values.yaml
) in airbyte Helm chart.global.metrics
in (charts/airbyte/values.yaml
)