Add ProtocolVersion to StandardDefs #16237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the database read/write operations
pedroslopez
reviewed
Sep 1, 2022
| @@ -55,3 +55,6 @@ properties: | |||
| format: date | |||
| resourceRequirements: | |||
| "$ref": ActorDefinitionResourceRequirements.yaml | |||
| protocol_version: | |||
There was a problem hiding this comment.
just passing by, seems like we're using camelCase for most of these - should it be protocolVersion here?
There was a problem hiding this comment.
Good question, I think I saw a few comments about prefering snake_case over camelCase for the attributes in the models.
The generated output remains camelCase for the Java objects.
No strong opinion here.
There was a problem hiding this comment.
Ah yeah - main reason why I pointed this out is since at least specifically within these StandardXYZDefinitions schemas it seems like camel case is being used. Also no strong opinion, just think we should try to be consistent
There was a problem hiding this comment.
I'd go for file consistency there.
There was a problem hiding this comment.
Same conclusion, change on the way
gosusnp
deleted the
gosusnp/16201-add_protocol_version_to_actor_defs_apis
branch
letiescanciano
added a commit
that referenced
this pull request
Sep 5, 2022
* master: (47 commits) Add email to identify users analytics call (#16327) 🎉 Source Amazon Ads: improve `config.start_date` validation (#16191) Add comments about intermediate state emission (#16262) MySQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16216) MSSQL Source : Standardize spec.json for DB connectors that support log-based CDC replication (#16215) Hide a bunch more destination with potential unsecure API access (#16320) Skip unit tests when run-tests is false (#16267) Hide Destination connections from UI (#16310) Add scheduled task to clean up old files from workspace (#16247) Source Google Analytics v4: Re-name google analytics connector (#16306) 🐛 Source Facebook Marketing: remove "end_date" from config if empty value (re-implement #16096) (#16222) Fix github action syntax (#16277) Re-name google analytics cionnectors (#16287) Bump Airbyte version from 0.40.3 to 0.40.4 (#16275) Hide ES and Redis destination connectors from Cloud (#16276) 15700 add tests for PokeAPI (#15701) Add ProtocolVersion to StandardDefs (#16237) 🪟 🔧 🧹 Migrate attempt `bytesSynced` to `totalStats.bytesEmitted` and cleanup `AttemptDetails` component (#16126) Improve behavior of password input field (#16011) Improve airbyte-metrics support in the Helm chart (#16166) ...
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Add ProtocolVersion to StandardDefs This updates the database read/write operations * Fix letter case
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Add ProtocolVersion to StandardDefs This updates the database read/write operations * Fix letter case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enable storing and reading protocol_versions in actor definitions.
How
Add version to
StandardDestinationDefinitionandStandardSourceDefinition.Propagates to the database operations
Closes #16201