-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source Sendgrid: change start time param type to datetime string #16400
Source Sendgrid: change start time param type to datetime string #16400
Conversation
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
super().__init__(**kwargs) | ||
self._start_time = start_time or 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self._start_time = int(pendulum.parse(self._start_time).timestamp()) if isinstance(self._start_time, str) else start_time or 0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to re-declare here, I believe.
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
depends on #16429 |
/test connector=connectors/source-sendgrid
Build FailedTest summary info:
|
…time-param-type-to-datetime
/test connector=connectors/source-sendgrid
Build PassedTest summary info:
|
/publish connector=connectors/source-sendgrid
if you have connectors that successfully published but failed definition generation, follow step 4 here |
…bytehq#16400) * airbytehq#4842 Source Sendgrid: change start time param type to datetime string * airbytehq#4842 source sendgrid: upd changelog * airbytehq#4842 source sendgrid: fix SAT * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
…bytehq#16400) * airbytehq#4842 Source Sendgrid: change start time param type to datetime string * airbytehq#4842 source sendgrid: upd changelog * airbytehq#4842 source sendgrid: fix SAT * auto-bump connector version [ci skip] Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
What
Start Time in a spec should receive a human readable datetime string instead of timestamp