-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SATS: fix backwards compatibility #16429
SATS: fix backwards compatibility #16429
Conversation
NOTE
|
/test connector=bases/source-acceptance-test
Build PassedTest summary info:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davydov-d could you add a unit test to verify this behavior?
NOTE
|
/test connector=bases/source-acceptance-test
Build PassedTest summary info:
|
NOTE
|
@sherifnada sure, done. I've also separated spec validation from catalog validation because I believe the behavior should be different in these cases |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@davydov-d could you please explain your motivation for this change? Type widening sounds dangerous at first sight. Is it your approach to changing a spec type but still supporting the previous type?
@alafanechere Yes. here I need to change data type from integer to string but support legacy integer values as well. That's why here I'm letting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the clarification. LGTM
…ards-compatibility-test
NOTE
|
…ards-compatibility-test
…ility-test' of github.com:airbytehq/airbyte into ddavydov/source-acceptance-tests-fix-backwards-compatibility-test
NOTE
|
/publish connector=bases/source-acceptance-test auto-bump-version=false
if you have connectors that successfully published but failed definition generation, follow step 4 here |
* SATS: fix backwards compatibility * airbytehq#16429 source acceptance tests: modify validation for specs only * airbytehq#16429 source acceptance tests: add typing * SATs: fix changelog Co-authored-by: Augustin <augustin.lafanechere@gmail.com>
* SATS: fix backwards compatibility * airbytehq#16429 source acceptance tests: modify validation for specs only * airbytehq#16429 source acceptance tests: add typing * SATs: fix changelog Co-authored-by: Augustin <augustin.lafanechere@gmail.com>
What
SATs declare widening of a data type is ok but in reality tests do not pass in a
'integer'-> '[integer, string]'
type change. Fixing it here