Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude file from spotless styling to fix build #16423

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

lmossman
Copy link
Contributor

@lmossman lmossman commented Sep 8, 2022

What

This PR added the following json file to the repo, which is making our auto-formatting software unhappy: https://github.com/airbytehq/airbyte/blob/master/airbyte-webapp/src/test-utils/mock-data/mockDestinationDefinition.json

If someone tries to run ./gradlew format on master, the following changes are produced:

--- a/airbyte-webapp/src/test-utils/mock-data/mockDestinationDefinition.json
+++ b/airbyte-webapp/src/test-utils/mock-data/mockDestinationDefinition.json
@@ -146,7 +146,12 @@
           },
           {
             "title": "verify-full",
-            "required": ["mode", "ca_certificate", "client_certificate", "client_key"],
+            "required": [
+              "mode",
+              "ca_certificate",
+              "client_certificate",
+              "client_key"
+            ],
             "properties": {
               "mode": {
                 "enum": ["verify-full"],
@@ -218,7 +223,13 @@
           },
           {
             "title": "SSH Key Authentication",
-            "required": ["tunnel_method", "tunnel_host", "tunnel_port", "tunnel_user", "ssh_key"],
+            "required": [
+              "tunnel_method",
+              "tunnel_host",
+              "tunnel_port",
+              "tunnel_user",
+              "ssh_key"
+            ],

However, if you then try to commit these changes, the prettier pre-commit hook undoes those changes, resulting in an empty commit.

How

This PR is just a short-term fix to get the platform build back into a good state, by excluding that specific file from spotless styling so that ./gradlew format does not produce any diff for that file.

@lmossman lmossman marked this pull request as ready for review September 8, 2022 01:00
@lmossman lmossman merged commit b9d83a8 into master Sep 8, 2022
@lmossman lmossman deleted the lmossman/fix-formatting-build-issue branch September 8, 2022 01:04
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants