-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude webapp from spotless styling #16455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
eslint and prettier are only configured in airbyte-webapp. We should copy those over. Or symlink them? |
@krishnaglick it looks like we already have some cypress-specific eslint configuration in airbyte-webapp-e2e-tests: airbyte/airbyte-webapp-e2e-tests/package.json Lines 11 to 22 in f81c5aa
So I don't think we need to add more eslint configuration there. But I have added prettier to that module and symlinked the .prettierrc.js files as you recommended, and I ran prettier on that module and committed the changes to this PR
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* exclude webapp from spotless styling * also exclude airbyte-webapp-e2e-tests * add comma * add prettier to airbyte-webapp-e2e-tests * run prettier on airbyte-webapp-e2e-tests
* exclude webapp from spotless styling * also exclude airbyte-webapp-e2e-tests * add comma * add prettier to airbyte-webapp-e2e-tests * run prettier on airbyte-webapp-e2e-tests
What
This PR excludes the airbyte-webapp module from spotless styling. This module has its own auto-formatting plugins (e.g. prettier) and therefore does not also need spotless to run on it.
Having both auto-formatters running on this module can lead to inconsistencies and broken builds, such as the situation described in this PR: #16423
How
Excludes the airbyte-webapp module from the spotless target in the top-level build.gradle.
🚨 User Impact 🚨
No user impact.