fix: proplerly render extraContainers #16474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brad Clark <bdashrad@gmail.com>
|
|
Signed-off-by: Brad Clark <bdashrad@gmail.com>
|
It's unclear to me where the charts are actually stored, because changes in this code repo don't line up with the helm chart repo. I'm also happy to run the helm-docs commands to update the README if they are run in ci/cd. |
|
I have run chart-testing locally, and there are some additional changes it would like to see, around newlines in values.yaml, version pinning in https://github.com/airbytehq/airbyte/blob/master/charts/airbyte/Chart.yaml#L26. The airbyte-metrics chart is also missing from the helm chart repo, which causes further errors. chart-testing |
…standardize to match other charts in repo Signed-off-by: Brad Clark <bdashrad@gmail.com>
…traContainers-nindent
Charts from this repo are being packaged and then store in https://github.com/airbytehq/helm-charts repo |
I'll add chart-testing utility into a check workflow that will make sure everything's okay before approving PR(commit and PR have semantic format + cart-testing validation is successfull) Thanks for pointing out! |
Signed-off-by: Brad Clark <bdashrad@gmail.com>
xpuska513
changed the title
|
@bdashrad, everything LGTM, but before approving I'll clone your repo and deploy airbyte locally. |
|
Thanks @xpuska513, it looks like the chart version numbering has changed, so let me know what you'd like me to do there. |
bdashrad
commented
Sep 12, 2022
| ## requests: | ||
| ## memory: 256Mi | ||
| ## cpu: 250m | ||
| requests: {} |
There was a problem hiding this comment.
This aligns this section to be the same as the other charts in the repo.
xpuska513
approved these changes
Sep 13, 2022
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* fix: proplerly render extraContainers Signed-off-by: Brad Clark <bdashrad@gmail.com> * fix: ignore charts path Signed-off-by: Brad Clark <bdashrad@gmail.com> * feat: add support for extraContainers and standardize to match other charts in repo Signed-off-by: Brad Clark <bdashrad@gmail.com> * fix: fix rendered chart indentation Signed-off-by: Brad Clark <bdashrad@gmail.com> Signed-off-by: Brad Clark <bdashrad@gmail.com>
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* fix: proplerly render extraContainers Signed-off-by: Brad Clark <bdashrad@gmail.com> * fix: ignore charts path Signed-off-by: Brad Clark <bdashrad@gmail.com> * feat: add support for extraContainers and standardize to match other charts in repo Signed-off-by: Brad Clark <bdashrad@gmail.com> * fix: fix rendered chart indentation Signed-off-by: Brad Clark <bdashrad@gmail.com> Signed-off-by: Brad Clark <bdashrad@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brad Clark bdashrad@gmail.com
What
Fixes #16470
How
Apply proper indentation when rendering extraContainers
Recommended reading order
🚨 User Impact 🚨
Bug fix, no breaking changes
Pre-merge Checklist
Community member or Airbyter
Airbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereUpdating a connector
Community member or Airbyter
airbyte_secret./gradlew :airbyte-integrations:connectors:<name>:integrationTest.README.mdbootstrap.md. See description and examplesdocs/integrations/<source or destination>/<name>.mdincluding changelog. See changelog exampleAirbyter
If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.
/test connector=connectors/<name>command is passing/publishcommand described hereConnector Generator
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changesTests
Unit
Put your unit tests output here.
Integration
Put your integration tests output here.
Acceptance
Put your acceptance tests output here.