Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪟 🎨 Remove feedback modal from UI #16548

Merged
merged 10 commits into from
Sep 14, 2022
34 changes: 3 additions & 31 deletions airbyte-webapp/src/pages/OnboardingPage/components/FinalStep.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,12 @@
import React, { useEffect, useState } from "react";
import React from "react";
import { FormattedMessage } from "react-intl";
import styled from "styled-components";

import { H1 } from "components";

import { useConfig } from "config";
import Status from "core/statuses";
import { useOnboardingService } from "hooks/services/Onboarding/OnboardingService";
import { useConnectionList, useGetConnection, useSyncConnection } from "hooks/services/useConnectionHook";
import useWorkspace from "hooks/services/useWorkspace";
import SyncCompletedModal from "views/Feedback/SyncCompletedModal";

import HighlightedText from "./HighlightedText";
import ProgressBlock from "./ProgressBlock";
Expand All @@ -33,35 +30,12 @@ const Videos = styled.div`

const FinalStep: React.FC = () => {
const config = useConfig();
const { sendFeedback } = useWorkspace();
const { feedbackPassed, passFeedback, visibleUseCases, useCaseLinks, skipCase } = useOnboardingService();
const { visibleUseCases, useCaseLinks, skipCase } = useOnboardingService();
const { mutateAsync: syncConnection } = useSyncConnection();
const { connections } = useConnectionList();
const connection = useGetConnection(connections[0].connectionId, {
refetchInterval: 2500,
});
const [isOpen, setIsOpen] = useState(false);

useEffect(() => {
if (connection.latestSyncJobStatus === Status.SUCCEEDED && !feedbackPassed) {
setIsOpen(true);
}
}, [connection.latestSyncJobStatus, feedbackPassed]);

const onSkipFeedback = () => {
passFeedback();
setIsOpen(false);
};

const onSendFeedback = (feedback: string) => {
sendFeedback({
feedback,
source: connection.source,
destination: connection.destination,
});
passFeedback();
setIsOpen(false);
};

const onSync = () => syncConnection(connections[0]);

Expand All @@ -81,7 +55,7 @@ const FinalStep: React.FC = () => {
img="/videoCover.png"
/>
</Videos>
{!feedbackPassed && <ProgressBlock connection={connection} onSync={onSync} />}
<ProgressBlock connection={connection} onSync={onSync} />

<Title bold>
<FormattedMessage
Expand All @@ -95,8 +69,6 @@ const FinalStep: React.FC = () => {
{visibleUseCases?.map((item, key) => (
<UseCaseBlock key={item} count={key + 1} href={useCaseLinks[item]} onSkip={skipCase} id={item} />
))}

{isOpen ? <SyncCompletedModal onClose={onSkipFeedback} onPassFeedback={onSendFeedback} /> : null}
</>
);
};
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.