🪟 🎨 Remove feedback modal from UI

[dizel852]

What

Closes #16336

How

Removes Feedback modal after the successful run of the first connection

And display a message if the first sync was successful:
https://www.loom.com/share/3fe43d5183ef48a5b54190e7523df590

[dizel852]

Atm, some feedback functionality is left in the useWorkspace hook:

airbyte/airbyte-webapp/src/hooks/services/useWorkspace.tsx

Lines 48 to 65 in 5e9759b

	const sendFeedback = async ({
	feedback,
	source,
	destination,
	}: {
	feedback: string;
	source: SourceRead;
	destination: DestinationRead;
	}) => {
	analyticsService.track(Namespace.ONBOARDING, Action.FEEDBACK, {
	actionDescription: "Onboarding Feedback",
	feedback,
	connector_source_definition: source?.sourceName,
	connector_source_definition_id: source?.sourceDefinitionId,
	connector_destination_definition: destination?.destinationName,
	connector_destination_definition_id: destination?.destinationDefinitionId,
	});
	};

and in OnbordingService context:

airbyte/airbyte-webapp/src/hooks/services/Onboarding/OnboardingService.tsx

Lines 17 to 23 in 8076b56

	export const OnboardingServiceProvider: React.FC = ({ children }) => {
	const workspace = useCurrentWorkspace();
	const [feedbackPassed, setFeedbackPassed] = useLocalStorage<boolean>(`${workspace.workspaceId}/passFeedback`, false);
	const [skippedUseCases, setSkippedUseCases] = useLocalStorage<string[]>(
	`${workspace.workspaceId}/skippedUseCases`,
	[]
	);

@timroes should we completely remove the feedback functionality? Or we will use it somehow with Chameleon?

[timroes]

@dizel852 I'd remove the sendFeedback method from the useWorkspace (as well as the corresponding enum values from the analytic events), but I we should keep the logic about use-cases, there is no (current) plan to change those.

[dizel852]

@dizel852 I'd remove the sendFeedback method from the useWorkspace (as well as the corresponding enum values from the analytic events), but I we should keep the logic about use-cases, there is no (current) plan to change those.

@timroes I'm not sure I understand fully what you mean.
What logic about use cases should we keep?

[teallarson]

Code looks good and tested it locally.

There's at least one i18n string that can be removed too it looks like (onboarding.syncCompleted) and there may be more than one.

[timroes]

@dizel852 sorry in the OnboardingService a couple of additional lines got marked in your above comments, so I was refering to them (but now noticed that those were most likely only marked by misstake, and it's about the feedbackPassed above 😅).

I think that should be removed as well. I think we can just show the "your first sync succeeded message" on top of the onboarding page all the time (which is the only place we currently using the feedbackPassed as a flag).

[dizel852]

I think we can just show the "your first sync succeeded message" on top of the onboarding page all the time

@timroes Looks good?

[timroes]

Small semantic HTML nitpick: this is not really a header for anything, so I think we should not make this a h3 element but just a regular element. This is currently not possible with the Text component, so I'm happy moving this to another PR so we can merge this. cc @edmundito not sure if this is something we should maybe address in the component, that we can use "heading like" styles also for texts that are semantically not headings like in this case?

[timroes]

Code LGTM, tested locally (the version before my previous comments) everything works and looking as expected.