🎉 Source mixpanel: Use "Retry-After" header for backoff #16770

grubberr · 2022-09-15T09:15:03Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix https://github.com/airbytehq/alpha-beta-issues/issues/235

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-09-15T09:24:41Z

/test connector=connectors/source-source-mixpanel

🕑 connectors/source-source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3059292525
❌ connectors/source-source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3059292525
🐛

Build Failed

Test summary info:

Could not find result summary

grubberr · 2022-09-15T09:32:46Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3059346090
❌ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3059346090
🐛 https://gradle.com/s/2bbhcvm7woxpk

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-not]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
============= 24 passed, 1 skipped, 4 errors in 673.62s (0:11:13) ==============

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-09-15T10:26:27Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3059685518
❌ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3059685518
🐛 https://gradle.com/s/h6i3egkdcdcns

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_refs_exist_in_schema[inputs0]
ERROR test_core.py::TestDiscovery::test_defined_keyword_exist_in_schema[inputs0-allOf]
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
============= 25 passed, 1 skipped, 3 errors in 1781.00s (0:29:40) =============

grubberr · 2022-09-15T11:37:03Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3060119196
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3060119196
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              56      0   100%
source_mixpanel/streams/annotations.py           6      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/source.py                       57      1    98%
source_mixpanel/streams/engage.py               89      5    94%
source_mixpanel/streams/base.py                 74      8    89%
source_mixpanel/streams/cohorts.py              20      3    85%
source_mixpanel/streams/export.py               51      8    84%
source_mixpanel/streams/cohort_members.py       19      5    74%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          445     41    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
================== 28 passed, 1 skipped in 406.98s (0:06:46) ===================

grubberr · 2022-09-15T12:15:26Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/3060357999

Connector	Did it publish?	Were definitions generated?
connectors/source-mixpanel	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* master: (200 commits) 🪟 🧹 Display returned error messages on replication view (#16280) 🎉 Source mixpanel: Use "Retry-After" header for backoff (#16770) 🐛 Source google ads: mark custom query fields required (#15858) 🪟 🔧Remove useRouter hook (#16598) CDK: improve TypeTransformer to convert simple types to array of simple types (#16636) CDK: TypeTransformer - warning message more informative (#16695) Source MySQL: Add Python SAT to detect backwards breaking changes (#16445) remove eager (#16756) bump com.networknt:json-schema-validator to latest version (#16619) Remove Cloud from Kafka docs (#16753) Normalization Summaries table and read/write methods (#16655) comment out flaky test suite while it is being investigated (#16752) Update ConfigRepository to read protocol version (#16670) Use LOG4J2 to wrap connectors logs to JSON format (#15668) Update connector catalog (#16749) 🪟 🎨 Remove feedback modal from UI (#16548) Add missing env var for Kube overlays (#16747) Prepare for React v18 upgrade (#16694) 🪟 🐛 Fix direct job linking to work with pagination (#16517) Fix formatting (#16743) ...

) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

backoff_time added

cb625e9

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/connectors Connector related issues label Sep 15, 2022

octavia-squidington-iii added the connectors/source/mixpanel label Sep 15, 2022

mixpanel.md updated

1564d75

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 15, 2022

grubberr changed the title ~~🎉 Source mixpanel: sleep for "Retry-After" seconds~~ 🎉 Source mixpanel: Use "Retry-After" header for backoff Sep 15, 2022

grubberr self-assigned this Sep 15, 2022

backoff_time updated

5bec72a

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr requested a review from arsenlosenko September 15, 2022 12:12

arsenlosenko approved these changes Sep 15, 2022

View reviewed changes

auto-bump connector version [ci skip]

6f37dc6

grubberr merged commit e03f47e into master Sep 15, 2022

grubberr deleted the grubberr/alpha-beta-235-source-mixpanel branch September 15, 2022 12:40

octavia-squidington-iii mentioned this pull request Sep 15, 2022

Bump Airbyte version from 0.40.6 to 0.40.7 #16785

Merged

robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022

🎉 Source mixpanel: Use "Retry-After" header for backoff (airbytehq#16770

cc79dc4

) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022

🎉 Source mixpanel: Use "Retry-After" header for backoff (airbytehq#16770

303833f

) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source mixpanel: Use "Retry-After" header for backoff #16770

🎉 Source mixpanel: Use "Retry-After" header for backoff #16770

grubberr commented Sep 15, 2022 •

edited

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

🎉 Source mixpanel: Use "Retry-After" header for backoff #16770

🎉 Source mixpanel: Use "Retry-After" header for backoff #16770

Conversation

grubberr commented Sep 15, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

grubberr commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

grubberr commented Sep 15, 2022 • edited by github-actions bot Loading

Build Failed

grubberr commented Sep 15, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Sep 15, 2022 • edited by github-actions bot Loading

grubberr commented Sep 15, 2022 •

edited

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 15, 2022 •

edited by github-actions bot

Loading