🪟 🔧Remove useRouter hook #16598
Merged
🪟 🔧Remove useRouter hook #16598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
edmundito
suggested changes
Sep 12, 2022
| @@ -31,7 +32,8 @@ interface IProps { | |||
| } | |||
|
|
|||
| const ConnectionTable: React.FC<IProps> = ({ data, entity, onClickRow, onChangeStatus, onSync }) => { | |||
| const { query, push } = useRouter(); | |||
| const navigate = useNavigate(); | |||
| const query = useQuery() as { sortBy?: string; order?: SortOrderEnum }; | |||
There was a problem hiding this comment.
How come this needs to be cast?
There was a problem hiding this comment.
changed to generic type
| import { useMemo } from "react"; | ||
| import { useLocation } from "react-router-dom"; | ||
|
|
||
| export const useQuery = () => { |
There was a problem hiding this comment.
In order to avoid casting, you could use generics here:
export const useQuery = <T>() => {
Comment on lines
37
to
38
| const location = useLocation(); | ||
| const { pathname } = location; |
There was a problem hiding this comment.
Nit:
const { pathname } = location = useLocation();
edmundito
approved these changes
Sep 14, 2022
letiescanciano
added a commit
that referenced
this pull request
Sep 15, 2022
* master: (200 commits) 🪟 🧹 Display returned error messages on replication view (#16280) 🎉 Source mixpanel: Use "Retry-After" header for backoff (#16770) 🐛 Source google ads: mark custom query fields required (#15858) 🪟 🔧Remove useRouter hook (#16598) CDK: improve TypeTransformer to convert simple types to array of simple types (#16636) CDK: TypeTransformer - warning message more informative (#16695) Source MySQL: Add Python SAT to detect backwards breaking changes (#16445) remove eager (#16756) bump com.networknt:json-schema-validator to latest version (#16619) Remove Cloud from Kafka docs (#16753) Normalization Summaries table and read/write methods (#16655) comment out flaky test suite while it is being investigated (#16752) Update ConfigRepository to read protocol version (#16670) Use LOG4J2 to wrap connectors logs to JSON format (#15668) Update connector catalog (#16749) 🪟 🎨 Remove feedback modal from UI (#16548) Add missing env var for Kube overlays (#16747) Prepare for React v18 upgrade (#16694) 🪟 🐛 Fix direct job linking to work with pagination (#16517) Fix formatting (#16743) ...
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
* Removes useRouter hook * Removes params from useRouterQuery; Removes useRouterReplace hook * Fix comments * Fixes from comments * Fixes linter error
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
* Removes useRouter hook * Removes params from useRouterQuery; Removes useRouterReplace hook * Fix comments * Fixes from comments * Fixes linter error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #14557
Replaces #14869
How
As mentioned in the issue description, I removed
useRouterhook and replaced it in corresponding places with direct hooks for navigation, location, params, etc. I also added two custom hooks (useRouterQuery,useRouterReplace), that were initially inuseRouter, since they responsible for some logic, using direct hooks