🪟 🧹 Display returned error messages on replication view #16280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/platform
teallarson
force-pushed
the
teal/replication-view-error-messaging
branch
from
a3a2af3
to
50f9a76
Compare
teallarson
changed the title
teallarson
changed the title
teallarson
force-pushed
the
teal/replication-view-error-messaging
branch
from
8069365
to
26c2b93
Compare
krishnaglick
reviewed
Sep 9, 2022
airbyte-webapp/src/views/Connection/ConnectionForm/components/EditControls.tsx
Outdated
Show resolved
Hide resolved
airbyte-webapp/src/views/Connection/ConnectionForm/ConnectionForm.tsx
Outdated
Show resolved
Hide resolved
teallarson
force-pushed
the
teal/replication-view-error-messaging
branch
from
9a83690
to
154ebbb
Compare
krishnaglick
approved these changes
Sep 13, 2022
teallarson
force-pushed
the
teal/replication-view-error-messaging
branch
from
00241e8
to
e8c18bd
Compare
teallarson
force-pushed
the
teal/replication-view-error-messaging
branch
from
e8c18bd
to
02c7a01
Compare
letiescanciano
added a commit
that referenced
this pull request
Sep 15, 2022
* master: (200 commits) 🪟 🧹 Display returned error messages on replication view (#16280) 🎉 Source mixpanel: Use "Retry-After" header for backoff (#16770) 🐛 Source google ads: mark custom query fields required (#15858) 🪟 🔧Remove useRouter hook (#16598) CDK: improve TypeTransformer to convert simple types to array of simple types (#16636) CDK: TypeTransformer - warning message more informative (#16695) Source MySQL: Add Python SAT to detect backwards breaking changes (#16445) remove eager (#16756) bump com.networknt:json-schema-validator to latest version (#16619) Remove Cloud from Kafka docs (#16753) Normalization Summaries table and read/write methods (#16655) comment out flaky test suite while it is being investigated (#16752) Update ConfigRepository to read protocol version (#16670) Use LOG4J2 to wrap connectors logs to JSON format (#15668) Update connector catalog (#16749) 🪟 🎨 Remove feedback modal from UI (#16548) Add missing env var for Kube overlays (#16747) Prepare for React v18 upgrade (#16694) 🪟 🐛 Fix direct job linking to work with pagination (#16517) Fix formatting (#16743) ...
edmundito
reviewed
Sep 16, 2022
| .line { | ||
| min-width: 100%; | ||
| height: variables.$border-thin; | ||
| background: colors.$grey; |
There was a problem hiding this comment.
This should be $grey-100.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
closes #16244
Previously, we would always display a generic "Form is invalid" error for all error messages on Replication View due to bad ternary logic.
Now, we return whatever we get back or the standard validation error.
Success message unchanged:
Validation message unchanged:
Now show whatever was returned as the error message, including truncating it with CSS if it is excessively long:
How
Recommended reading order
ConnectionForm.tsx