Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.networknt:json-schema-validator to latest version #16619

Merged
merged 3 commits into from
Sep 14, 2022

Conversation

evantahler
Copy link
Contributor

@evantahler evantahler commented Sep 12, 2022

Closes #16406

I currently have a spec which contains a pretty large oneOf (~30 subschemas) and I'm being affected by networknt/json-schema-validator#361 in the json-schema-validator library.

Bumps com.networknt:json-schema-validator to latest version.

... all the tests seem to be passing.

Reviewers: Other than ensuring all the tests pass, what else should I check?

@github-actions github-actions bot added the area/connectors Connector related issues label Sep 12, 2022
@evantahler evantahler changed the title bump com.networknt:json-schema-validator to latest version Bump com.networknt:json-schema-validator to latest version Sep 12, 2022
@evantahler evantahler temporarily deployed to more-secrets September 12, 2022 23:31 Inactive
@evantahler evantahler temporarily deployed to more-secrets September 13, 2022 00:04 Inactive
@evantahler evantahler marked this pull request as ready for review September 13, 2022 16:43
@airbytehq airbytehq deleted a comment from github-actions bot Sep 13, 2022
@airbytehq airbytehq deleted a comment from github-actions bot Sep 13, 2022
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-e2e-test
  • source-e2e-test-cloud

@evantahler evantahler temporarily deployed to more-secrets September 13, 2022 16:45 Inactive
@evantahler
Copy link
Contributor Author

evantahler commented Sep 13, 2022

/test connector=connectors/source-e2e-test

🕑 connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/3046864165
✅ connectors/source-e2e-test https://github.com/airbytehq/airbyte/actions/runs/3046864165
No Python unittests run

Build Passed

Test summary info:

All Passed

Copy link
Contributor

@jdpgrailsdev jdpgrailsdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: As this is used in multiple places, it may make sense to add it to the dependency bundles in deps.toml to only have to reference/update the version in one place going forward.

@davinchia
Copy link
Contributor

davinchia commented Sep 14, 2022

/test connector=connectors/source-e2e-test-cloud

🕑 connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/3053953271
❌ connectors/source-e2e-test-cloud https://github.com/airbytehq/airbyte/actions/runs/3053953271
🐛 https://gradle.com/s/dwxcxdua5zc5s

Build Failed

Test summary info:

Could not find result summary

@davinchia
Copy link
Contributor

davinchia commented Sep 14, 2022

Same comment as Jonathan if you have time to implement!

We can add an entry similar to this and consume this just like this to centralise the declarations.

@evantahler
Copy link
Contributor Author

I couldn't get the TOML part to work.

// deps.toml
[versions]
json-schema-validator_version = "1.0.72"

[libraries]
json-schema-validator = { module = "com.networknt:json-schema-validator", version.ref = "json-schema-validator_version" }

// build.gradle
dependencies {
  implementation libs.json-schema-validator
}

produced

FAILURE: Build failed with an exception.

* Where:
Build file '/Users/evan/workspace/airbyte/airbyte/airbyte-json-validation/build.gradle' line: 6

* What went wrong:
A problem occurred evaluating project ':airbyte-json-validation'.
> Could not get unknown property 'schema' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

I'll merge this in as-is for now just to get things moving...

@evantahler evantahler merged commit c56ee8d into master Sep 14, 2022
@evantahler evantahler deleted the evan/bump-json-schema-validator branch September 14, 2022 22:41
@jdpgrailsdev
Copy link
Contributor

@evantahler It's a bit tricky. The dashes become dots (.) when referencing it in the build.gradle file: implementation libs.json.schema.validator.

letiescanciano added a commit that referenced this pull request Sep 15, 2022
* master: (200 commits)
  🪟 🧹 Display returned error messages on replication view (#16280)
  🎉 Source mixpanel: Use "Retry-After" header for backoff (#16770)
  🐛 Source google ads: mark custom query fields required (#15858)
  🪟 🔧Remove useRouter hook (#16598)
  CDK: improve TypeTransformer to convert simple types to array of simple types (#16636)
  CDK: TypeTransformer - warning message more informative (#16695)
  Source MySQL: Add Python SAT to detect backwards breaking changes (#16445)
  remove eager (#16756)
  bump com.networknt:json-schema-validator to latest version (#16619)
  Remove Cloud from Kafka docs (#16753)
  Normalization Summaries table and read/write methods (#16655)
  comment out flaky test suite while it is being investigated (#16752)
  Update ConfigRepository to read protocol version (#16670)
  Use LOG4J2 to wrap connectors logs to JSON format (#15668)
  Update connector catalog (#16749)
  🪟 🎨 Remove feedback modal from UI (#16548)
  Add missing env var for Kube overlays (#16747)
  Prepare for React v18 upgrade (#16694)
  🪟 🐛 Fix direct job linking to work with pagination (#16517)
  Fix formatting (#16743)
  ...
robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022
jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade json-schema-validator
4 participants