-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🎨 Remove feedback modal from UI #16548
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1dbfdcc
remove feedback modal components and from FinalStep component
dizel852 9fbac2d
Merge branch 'master' into vlad/16336-remove-feedback-modal
dizel852 10ed3da
create FirstSuccessfulSync component
dizel852 7732e3b
add FirstSuccessfulSync component to FinalStep
dizel852 f5e623f
remove sendFeedback functionality from useWorkspace hook
dizel852 725a1fe
remove sendFeedback functionality from Onboarding context
dizel852 20d861c
move svg image closer to component where it's used
dizel852 a660d6e
update .completedSyncText text style
dizel852 fa4f336
add data-testid to FirstSuccessfulSync component
dizel852 6aac476
Merge branch 'master' into vlad/16336-remove-feedback-modal
dizel852 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
...p/src/pages/OnboardingPage/components/FirstSuccessfulSync/FirstSuccessfulSync.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
@use "../../../../scss/colors"; | ||
@use "../../../../scss/variables"; | ||
|
||
.container { | ||
width: 100%; | ||
padding: 50px 78px 40px; | ||
background: colors.$dark-blue-900 url("stars-background.svg"); | ||
border-radius: variables.$border-radius-md; | ||
position: relative; | ||
} | ||
|
||
.rocket { | ||
position: absolute; | ||
width: 180px; | ||
transform: matrix(0.99, 0.12, -0.12, 0.99, 0, 0) rotate(-4.78deg); | ||
top: -54px; | ||
left: calc(50% - 261px / 2 + 24px); | ||
transition: 0.8s; | ||
} | ||
|
||
.completedSyncText { | ||
color: colors.$white; | ||
} |
17 changes: 17 additions & 0 deletions
17
...te-webapp/src/pages/OnboardingPage/components/FirstSuccessfulSync/FirstSuccessfulSync.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
import React from "react"; | ||
import { FormattedMessage } from "react-intl"; | ||
|
||
import { Text } from "components/base/Text"; | ||
|
||
import styles from "./FirstSuccessfulSync.module.scss"; | ||
|
||
export const FirstSuccessfulSync: React.FC = () => { | ||
return ( | ||
<div className={styles.container} data-testid="firstSuccessfulSync"> | ||
<Text as="h3" size="md" centered className={styles.completedSyncText}> | ||
<FormattedMessage id="onboarding.syncCompleted" /> | ||
</Text> | ||
<img className={styles.rocket} src="/rocket.png" alt="" /> | ||
</div> | ||
); | ||
}; |
1 change: 1 addition & 0 deletions
1
airbyte-webapp/src/pages/OnboardingPage/components/FirstSuccessfulSync/index.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
export * from "./FirstSuccessfulSync"; |
File renamed without changes
22 changes: 0 additions & 22 deletions
22
airbyte-webapp/src/views/Feedback/SyncCompletedModal/SyncCompletedModal.tsx
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
airbyte-webapp/src/views/Feedback/SyncCompletedModal/components/BadIcon.tsx
This file was deleted.
Oops, something went wrong.
33 changes: 0 additions & 33 deletions
33
airbyte-webapp/src/views/Feedback/SyncCompletedModal/components/FeedbackButton.tsx
This file was deleted.
Oops, something went wrong.
10 changes: 0 additions & 10 deletions
10
airbyte-webapp/src/views/Feedback/SyncCompletedModal/components/GoodIcon.tsx
This file was deleted.
Oops, something went wrong.
48 changes: 0 additions & 48 deletions
48
airbyte-webapp/src/views/Feedback/SyncCompletedModal/components/ModalBody.tsx
This file was deleted.
Oops, something went wrong.
36 changes: 0 additions & 36 deletions
36
airbyte-webapp/src/views/Feedback/SyncCompletedModal/components/ModalHeader.tsx
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
airbyte-webapp/src/views/Feedback/SyncCompletedModal/index.tsx
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small semantic HTML nitpick: this is not really a header for anything, so I think we should not make this a
h3
element but just a regular element. This is currently not possible with theText
component, so I'm happy moving this to another PR so we can merge this. cc @edmundito not sure if this is something we should maybe address in the component, that we can use "heading like" styles also for texts that are semantically not headings like in this case?