Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🪟 🎨 Remove feedback modal from UI #16548
🪟 🎨 Remove feedback modal from UI #16548
Changes from 6 commits
1dbfdcc
9fbac2d
10ed3da
7732e3b
f5e623f
725a1fe
20d861c
a660d6e
fa4f336
6aac476
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small semantic HTML nitpick: this is not really a header for anything, so I think we should not make this a
h3
element but just a regular element. This is currently not possible with theText
component, so I'm happy moving this to another PR so we can merge this. cc @edmundito not sure if this is something we should maybe address in the component, that we can use "heading like" styles also for texts that are semantically not headings like in this case?This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.