Need to also emit legacy state for read override connectors when state is not specified #16569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| """ | ||
| # vars(self.__class__) checks if the current class directly overrides the read() function | ||
| if "read" in vars(self.__class__): | ||
| return defaultdict(dict, state_obj) |
There was a problem hiding this comment.
Could you share why you call defaultdict with a dict default factory?
There was a problem hiding this comment.
Great question! Not sure if it actually makes a difference, but the original code before the changes also wrapped it in defaultdict so I wanted to preserve the same functionality. Reference to prior changes:
evantahler
approved these changes
Sep 12, 2022
|
/publish-cdk dry-run=false
|
robbinhan
pushed a commit
to robbinhan/airbyte
that referenced
this pull request
Sep 29, 2022
jhammarstedt
pushed a commit
to jhammarstedt/airbyte
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When fixing #16566 , I forgot to also emit the legacy format when state isn't specified.
How
Since we may need to conditionally emit the legacy format in more than one place, I refactored the condition into it's own function so it could be reused.
Tested again w/ the following conditions work with the correct state interpretation:
--statespecified in the read request: replicate all records, emit final state{}: replicate all records, emit final state[]: replicate all records, emit final state