🎉 Source mixpanel: Improved connector's input configuration validation #16570

grubberr · 2022-09-10T16:26:21Z

Signed-off-by: Sergey Chvalyuk grubberr@gmail.com

What

Try to fix this
https://github.com/airbytehq/alpha-beta-issues/issues/171

Validate and transform config.json on early stage for "check" and "read" commands

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

but regex keep old for backward compatability Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

start_date, end_date correctly typed

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-09-11T08:55:45Z

/test connector=connectors/source-source-mixpanel

grubberr · 2022-09-11T08:59:09Z

/test connector=connectors/source-source-mixpanel

🕑 connectors/source-source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3031209115
❌ connectors/source-source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3031209115
🐛

Build Failed

Test summary info:

Could not find result summary

grubberr · 2022-09-11T09:09:23Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3031242020
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3031242020
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              56      0   100%
source_mixpanel/streams/annotations.py           6      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/source.py                       57      1    98%
source_mixpanel/streams/engage.py               89      5    94%
source_mixpanel/streams/base.py                 72      7    90%
source_mixpanel/streams/cohorts.py              20      3    85%
source_mixpanel/streams/export.py               51      8    84%
source_mixpanel/streams/cohort_members.py       19      5    74%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          443     40    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1322    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
================== 28 passed, 1 skipped in 401.29s (0:06:41) ===================

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

grubberr · 2022-09-13T07:49:19Z

/test connector=connectors/source-mixpanel

🕑 connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3043255949
✅ connectors/source-mixpanel https://github.com/airbytehq/airbyte/actions/runs/3043255949
Python tests coverage:

Name                                         Stmts   Miss  Cover
----------------------------------------------------------------
source_mixpanel/streams/revenue.py              14      0   100%
source_mixpanel/streams/funnels.py              56      0   100%
source_mixpanel/streams/annotations.py           6      0   100%
source_mixpanel/streams/__init__.py              9      0   100%
source_mixpanel/property_transformation.py      19      0   100%
source_mixpanel/__init__.py                      2      0   100%
source_mixpanel/source.py                       57      1    98%
source_mixpanel/streams/engage.py               89      5    94%
source_mixpanel/streams/base.py                 72      7    90%
source_mixpanel/streams/cohorts.py              20      3    85%
source_mixpanel/streams/export.py               51      8    84%
source_mixpanel/streams/cohort_members.py       19      5    74%
source_mixpanel/testing.py                      29     11    62%
----------------------------------------------------------------
TOTAL                                          443     40    91%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       121     25    79%   21-23, 29-31, 36-43, 48-61, 208-216
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       110     48    56%   23-26, 32, 36, 39-64, 67-69, 72-74, 77-79, 82-84, 87-89, 92-110, 144-146
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1325    463    65%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_incremental.py:23: `future_state_path` not specified, skipping
================== 28 passed, 1 skipped in 596.85s (0:09:56) ===================

grubberr · 2022-09-13T08:34:23Z

/publish connector=connectors/source-mixpanel

🕑 Publishing the following connectors:
connectors/source-mixpanel
https://github.com/airbytehq/airbyte/actions/runs/3043553122

Connector	Did it publish?	Were definitions generated?
connectors/source-mixpanel	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

airbytehq#16570) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

extract to _validate_and_transform

2d4f1bd

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/connectors Connector related issues label Sep 10, 2022

octavia-squidington-iii added the connectors/source/mixpanel label Sep 10, 2022

grubberr added 6 commits September 10, 2022 21:18

fix tests

d504987

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

switch fully on pendulum

6d36142

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

description of start and end date changed

f7f434f

but regex keep old for backward compatability Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

region param not optional

18658cc

start_date, end_date correctly typed

bump 0.1.21

b4f808e

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

fix conftest.py

a44fb69

grubberr self-assigned this Sep 11, 2022

grubberr added 2 commits September 11, 2022 11:41

improve docs

1c65592

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

mixpanel.md updated

adae4bf

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

github-actions bot added the area/documentation Improvements or additions to documentation label Sep 11, 2022

grubberr changed the title ~~🎉 Source mixpanel: extract to _validate_and_transform~~ 🎉 Source mixpanel: Improved connector's input configuration validation Sep 11, 2022

grubberr requested a review from lazebnyi September 12, 2022 13:59

grubberr assigned lazebnyi and grubberr and unassigned grubberr and lazebnyi Sep 12, 2022

grubberr requested a review from arsenlosenko September 12, 2022 14:00

arsenlosenko approved these changes Sep 12, 2022

View reviewed changes

grubberr added 2 commits September 13, 2022 10:45

Merge branch 'master' into grubberr/oncall-171-source-mixpanel

f6cb2ba

updated regex to support empty value

bce60da

Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

auto-bump connector version [ci skip]

cdc3896

grubberr merged commit 5edc575 into master Sep 13, 2022

grubberr deleted the grubberr/oncall-171-source-mixpanel branch September 13, 2022 09:12

octavia-squidington-iii mentioned this pull request Sep 13, 2022

Bump Airbyte version from 0.40.5 to 0.40.6 #16656

Merged

robbinhan pushed a commit to robbinhan/airbyte that referenced this pull request Sep 29, 2022

🎉 Source mixpanel: Improved connector's input configuration validation (

15f664d

airbytehq#16570) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

jhammarstedt pushed a commit to jhammarstedt/airbyte that referenced this pull request Oct 31, 2022

🎉 Source mixpanel: Improved connector's input configuration validation (

1479fb4

airbytehq#16570) Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 Source mixpanel: Improved connector's input configuration validation #16570

🎉 Source mixpanel: Improved connector's input configuration validation #16570

grubberr commented Sep 10, 2022 •

edited

Loading

grubberr commented Sep 11, 2022

grubberr commented Sep 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 13, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 13, 2022 •

edited by github-actions bot

Loading

🎉 Source mixpanel: Improved connector's input configuration validation #16570

🎉 Source mixpanel: Improved connector's input configuration validation #16570

Conversation

grubberr commented Sep 10, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Tests

grubberr commented Sep 11, 2022

grubberr commented Sep 11, 2022 • edited by github-actions bot Loading

Build Failed

grubberr commented Sep 11, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Sep 13, 2022 • edited by github-actions bot Loading

Build Passed

grubberr commented Sep 13, 2022 • edited by github-actions bot Loading

grubberr commented Sep 10, 2022 •

edited

Loading

grubberr commented Sep 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 11, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 13, 2022 •

edited by github-actions bot

Loading

grubberr commented Sep 13, 2022 •

edited by github-actions bot

Loading