🪟 🔧 Add additional eslint rules

[timroes]

What

This adds two rules improving on TypeScript code:

• @typescript-eslint/no-unnecessary-type-assertion which prevents us from doing foo!.bar if foo can't be null/undefined and that way basically weakening type checks if it later would change to be able to be null/undefined.
• @typescript-eslint/await-thenable, which prevents us from using await for statements that are not returning a promise. I also removed all violations of this rule.

How

I needed to move the .eslintrc file to .eslintrc.js since I required access to __dirname for that path to work properly no matter if you run lint via the command line or via VSCode.

Since those new rules require eslint to properly parse our project to have all type information, they can only apply to files in src/ (which are part of out typescript project), thus they went into a separate overwrites.

[teallarson]

The rules look good but looks like there are some build things with the e2e tests failing.

[dizel852]

A great addition to existing rules! 👍
But I notice a few things:

1. E2E fails because of

2. The terminal is full of "Warning: An update to Formik inside a test was not wrapped in act(...)" warnings after the tests run. But tests are green.

[krishnaglick]

The changes from @typescript-eslint/await-thenable may have been partially done in error. It could be functions that were poorly typed, but async, are no longer being awaited.

[timroes]

The changes from @typescript-eslint/await-thenable may have been partially done in error. It could be functions that were poorly typed, but async, are no longer being awaited.

Could you please specify which removed await specifically you referring too, that where done in error?

[krishnaglick]

The changes from @typescript-eslint/await-thenable may have been partially done in error. It could be functions that were poorly typed, but async, are no longer being awaited.

Could you please specify which removed await specifically you referring too, that where done in error?

My statement was based on us having failing tests, so I hedged that was the reason. If tests are passing then it seems like we're good. 👍