🪟 🔧 Add additional eslint rules

airbyte-webapp/.eslintrc.js

@@ -0,0 +1,114 @@
+module.exports = {
+  extends: [
+    "react-app",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:jest/recommended",
+    "prettier",
+    "plugin:prettier/recommended",
+    "plugin:css-modules/recommended",
+    "plugin:jsx-a11y/recommended",
+  ],
+  plugins: ["react", "@typescript-eslint", "prettier", "unused-imports", "css-modules", "jsx-a11y"],
+  parserOptions: {
+    ecmaVersion: 2020,
+    sourceType: "module",
+    ecmaFeatures: {
+      jsx: true,
+    },
+  },
+  rules: {
+    "jsx-a11y/label-has-associated-control": "error",
+    curly: "warn",
+    "css-modules/no-undef-class": "off",
+    "css-modules/no-unused-class": ["error", { camelCase: true }],
+    "dot-location": "warn",
+    "dot-notation": "warn",
+    eqeqeq: "error",
+    "prettier/prettier": "warn",
+    "unused-imports/no-unused-imports": "warn",
+    "no-else-return": "warn",
+    "no-lonely-if": "warn",
+    "no-inner-declarations": "off",
+    "no-unused-vars": "off",
+    "no-useless-computed-key": "warn",
+    "no-useless-return": "warn",
+    "no-var": "warn",
+    "object-shorthand": ["warn", "always"],
+    "prefer-arrow-callback": "warn",
+    "prefer-const": "warn",
+    "prefer-destructuring": ["warn", { AssignmentExpression: { array: true } }],
+    "prefer-object-spread": "warn",
+    "prefer-template": "warn",
+    "spaced-comment": ["warn", "always", { markers: ["/"] }],
+    yoda: "warn",
+    "import/order": [
+      "warn",
+      {
+        "newlines-between": "always",
+        groups: ["type", "builtin", "external", "internal", ["parent", "sibling"], "index"],
+        pathGroupsExcludedImportTypes: ["builtin"],
+        pathGroups: [
+          {
+            pattern: "components{/**,}",
+            group: "internal",
+          },
+          {
+            pattern: "+(config|core|hooks|locales|packages|pages|services|types|utils|views){/**,}",
+            group: "internal",
+            position: "after",
+          },
+        ],
+        alphabetize: {
+          order: "asc" /* sort in ascending order. Options: ['ignore', 'asc', 'desc'] */,
+          caseInsensitive: true /* ignore case. Options: [true, false] */,
+        },
+      },
+    ],
+    "@typescript-eslint/array-type": ["warn", { default: "array-simple" }],
+    "@typescript-eslint/ban-ts-comment": [
+      "warn",
+      {
+        "ts-expect-error": "allow-with-description",
+      },
+    ],
+    "@typescript-eslint/ban-types": "warn",
+    "@typescript-eslint/consistent-indexed-object-style": ["warn", "record"],
+    "@typescript-eslint/consistent-type-definitions": ["warn", "interface"],
+    "@typescript-eslint/no-unused-vars": "warn",
+    "react/function-component-definition": [
+      "warn",
+      {
+        namedComponents: "arrow-function",
+        unnamedComponents: "arrow-function",
+      },
+    ],
+    "jest/consistent-test-it": ["warn", { fn: "it", withinDescribe: "it" }],
+    "react/jsx-boolean-value": "warn",
+    "react/jsx-curly-brace-presence": "warn",
+    "react/jsx-fragments": "warn",
+    "react/jsx-no-useless-fragment": ["warn", { allowExpressions: true }],
+    "react/self-closing-comp": "warn",
+  },
+  parser: "@typescript-eslint/parser",
+  overrides: [
+    {
+      files: ["scripts/**/*"],
+      rules: {
+        "@typescript-eslint/no-var-requires": "off",
+      },
+    },
+    {
+      // Only applies to files in src. Rules should be in here that are requiring type information
+      // and thus require the below parserOptions.
+      files: ["src/**/*"],
+      parserOptions: {
+        tsconfigRootDir: __dirname,
+        project: "./tsconfig.json",
+      },
+      rules: {
+        "@typescript-eslint/await-thenable": "warn",
+        "@typescript-eslint/no-unnecessary-type-assertion": "warn",
+      },
+    },
+  ],
+};

airbyte-webapp/build.gradle

@@ -22,7 +22,7 @@ node {
 
 npm_run_build {
     inputs.files commonConfigs
-    inputs.file '.eslintrc'
+    inputs.file '.eslintrc.js'
     inputs.dir 'public'
     inputs.dir 'src'
 

airbyte-webapp/src/hooks/useLoadingState.tsx

@@ -26,7 +26,7 @@ const useLoadingState = (): {
       setIsLoading(true);
       setShowFeedback(false);
 
-      await action();
+      action();
 
       setIsLoading(false);
       setShowFeedback(true);

airbyte-webapp/src/hooks/useTypesafeReducer.ts

@@ -13,7 +13,7 @@ function useTypesafeReducer<StateShape, Actions extends Record<string, (...args:
       return function (this: any) {
         return dispatcher(
           // eslint-disable-next-line prefer-rest-params
-          actionCreator.apply(this as any, arguments as any as any[])
+          actionCreator.apply(this, arguments as any as any[])
         );
       };
     }

airbyte-webapp/src/packages/cloud/lib/auth/GoogleAuthService.ts

@@ -100,7 +100,7 @@ export class GoogleAuthService {
   }
 
   async updateEmail(email: string, password: string): Promise<void> {
-    const user = await this.getCurrentUser();
+    const user = this.getCurrentUser();
 
     if (user) {
       await this.reauthenticate(email, password);

airbyte-webapp/src/packages/cloud/views/credits/CreditsPage/components/RemainingCredits.tsx

@@ -109,7 +109,7 @@ const RemainingCredits: React.FC<Props> = ({ selfServiceCheckoutEnabled }) => {
       successUrl: successUrl.href,
       cancelUrl: window.location.href,
     });
-    await analytics.track(Namespace.CREDITS, Action.CHECKOUT_START, {
+    analytics.track(Namespace.CREDITS, Action.CHECKOUT_START, {
       actionDescription: "Checkout Start",
     });
     // Forward to stripe as soon as we created a checkout session successfully

airbyte-webapp/src/pages/DestinationPage/pages/CreateDestinationPage/components/DestinationForm.tsx

@@ -73,7 +73,7 @@ export const DestinationForm: React.FC<DestinationFormProps> = ({
   };
 
   const onSubmitForm = async (values: { name: string; serviceType: string }) => {
-    await onSubmit({
+    onSubmit({
       ...values,
       destinationDefinitionId: destinationDefinitionSpecification?.destinationDefinitionId,
     });

airbyte-webapp/src/pages/SettingsPage/pages/ConnectorsPage/components/CreateConnectorModal.tsx

@@ -117,8 +117,8 @@ const CreateConnectorModal: React.FC<IProps> = ({ onClose, onSubmit, errorMessag
           validateOnBlur
           validateOnChange
           validationSchema={validationSchema}
-          onSubmit={async (values, { setSubmitting }) => {
-            await onSubmit(values);
+          onSubmit={(values, { setSubmitting }) => {
+            onSubmit(values);
             setSubmitting(false);
           }}
         >

airbyte-webapp/src/pages/SettingsPage/pages/NotificationPage/components/WebHookForm.tsx

@@ -97,11 +97,11 @@ const WebHookForm: React.FC<WebHookFormProps> = ({ webhook, onSubmit, successMes
       validateOnBlur
       validateOnChange={false}
       validationSchema={webhookValidationSchema}
-      onSubmit={async (values: WebhookPayload) => {
+      onSubmit={(values: WebhookPayload) => {
         if (equal(webhook, values)) {
-          await onTest(values);
+          onTest(values);
         } else {
-          await onSubmit(values);
+          onSubmit(values);
         }
       }}
     >

airbyte-webapp/src/pages/SourcesPage/pages/CreateSourcePage/components/SourceForm.tsx

@@ -69,8 +69,8 @@ export const SourceForm: React.FC<SourceFormProps> = ({
     });
   };
 
-  const onSubmitForm = async (values: ServiceFormValues) => {
-    await onSubmit({
+  const onSubmitForm = (values: ServiceFormValues) => {
+    onSubmit({
       ...values,
       sourceDefinitionId: sourceDefinitionSpecification?.sourceDefinitionId,
     });

airbyte-webapp/src/services/workspaces/WorkspacesService.tsx

@@ -38,7 +38,7 @@ const useSelectWorkspace = (): ((workspace?: string | null | Workspace) => void)
       } else {
         navigate(`/${RoutePaths.Workspaces}/${workspace}`);
       }
-      await queryClient.removeQueries(SCOPE_WORKSPACE);
+      queryClient.removeQueries(SCOPE_WORKSPACE);
     },
     [navigate, queryClient]
   );

airbyte-webapp/src/test-utils/testutils.tsx

@@ -50,7 +50,7 @@ export async function render<
 
   let renderResult: RenderResult<Q, Container>;
   await act(async () => {
-    renderResult = await rtlRender<Q, Container>(<div>{ui}</div>, { wrapper: Wrapper, ...renderOptions });
+    renderResult = rtlRender<Q, Container>(<div>{ui}</div>, { wrapper: Wrapper, ...renderOptions });
   });
 
   // eslint-disable-next-line @typescript-eslint/no-non-null-assertion

airbyte-webapp/src/views/Connector/ConnectorCard/ConnectorCard.tsx

@@ -89,7 +89,7 @@ export const ConnectorCard: React.FC<ConnectorCardCreateProps | ConnectorCardEdi
 
     try {
       await testConnectorWithTracking();
-      await onSubmit(values);
+      onSubmit(values);
       setSaved(true);
     } catch (e) {
       setErrorStatusRequest(e);

airbyte-webapp/src/views/Connector/ServiceForm/ServiceForm.tsx

@@ -303,9 +303,9 @@ const ServiceForm: React.FC<ServiceFormProps> = (props) => {
   );
 
   const onFormSubmit = useCallback(
-    async (values: ServiceFormValues) => {
+    (values: ServiceFormValues) => {
       const valuesToSend = getValues(values);
-      await onSubmit(valuesToSend);
+      onSubmit(valuesToSend);
 
       clearFormChange(formId);
     },

airbyte-webapp/src/views/Connector/ServiceForm/components/Sections/auth/useOauthFlowAdapter.tsx

@@ -87,7 +87,7 @@ function useFormikOauthAdapter(connector: ConnectorDefinitionSpecification): {
         return acc;
       }, {} as Record<string, unknown>);
 
-      await run(oauthInputParams);
+      run(oauthInputParams);
     },
   };
 }

airbyte-webapp/src/views/Settings/PreferencesForm/PreferencesForm.tsx

@@ -83,8 +83,8 @@ const PreferencesForm: React.FC<PreferencesFormProps> = ({
       validateOnBlur
       validateOnChange={false}
       validationSchema={preferencesValidationSchema}
-      onSubmit={async (values) => {
-        await onSubmit(values);
+      onSubmit={(values) => {
+        onSubmit(values);
       }}
     >
       {({ isSubmitting, values, handleChange, setFieldValue, resetForm, isValid, dirty }) => (