Source Fauna: add seed file information #17355

marcosmarxm · 2022-09-28T20:51:27Z

What

Publish PR #15274
Format files and add info to seed file.

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

marcosmarxm · 2022-09-28T22:28:13Z

/test connector=connectors/source-fauna

🕑 connectors/source-fauna https://github.com/airbytehq/airbyte/actions/runs/3147298689
✅ connectors/source-fauna https://github.com/airbytehq/airbyte/actions/runs/3147298689
Python tests coverage:

Name                        Stmts   Miss  Cover
-----------------------------------------------
source_fauna/__init__.py        2      0   100%
source_fauna/serialize.py      37      1    97%
source_fauna/source.py        243     50    79%
-----------------------------------------------
TOTAL                         282     51    82%
	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          10      4    60%   15-18
	 source_acceptance_test/config.py                        83      6    93%   78-80, 84-86
	 source_acceptance_test/conftest.py                     164    164     0%   6-282
	 source_acceptance_test/plugin.py                        48     48     0%   6-104
	 source_acceptance_test/tests/test_core.py              329    111    66%   39, 50-58, 63-70, 74-75, 79-80, 164, 202-219, 228-236, 240-245, 251, 284-289, 327-334, 374-376, 379, 439-448, 477-478, 484, 487, 520-530, 543-568, 573-577
	 source_acceptance_test/tests/test_full_refresh.py       52      2    96%   34, 65
	 source_acceptance_test/tests/test_incremental.py       152     26    83%   21-23, 29-31, 36-43, 48-61, 239, 250-258
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  77     17    78%   15-16, 24-30, 47-54, 64, 67
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-67, 70-72, 75-77, 80-82, 85-87, 90-92, 95-113, 147-149
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1358    466    66%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:51: The previous connector image could not be retrieved.
SKIPPED [2] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:229: The previous connector image could not be retrieved.
======================== 41 passed, 3 skipped in 37.47s ========================

marcosmarxm · 2022-09-28T23:03:23Z

/publish connector=connectors/source-fauna

🕑 Publishing the following connectors:
connectors/source-fauna
https://github.com/airbytehq/airbyte/actions/runs/3147453700

Connector	Did it publish?	Were definitions generated?
connectors/source-fauna	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

* Applied suggestions to improve docs * Cleaned up the docs * Apply suggestions from code review Co-authored-by: Ewan Edwards <46354154+faunaee@users.noreply.github.com> * Update airbyte-integrations/connectors/source-fauna/source_fauna/spec.yaml Co-authored-by: Ewan Edwards <46354154+faunaee@users.noreply.github.com> Co-authored-by: Ewan Edwards <46354154+faunaee@users.noreply.github.com>

* Run ./gradlew :airbyte-integrations:connectors:source-fauna:flakeCheck * Fix all the warnings * Set additionalProperties to true to adhere to acceptance tests

* Remove custom fields from source.py * Remove custom fields from spec.yaml * Collections that support incremental sync are found correctly * Run formatter * Index values and termins are verified * Stripped additional_columns from collection config and check() * We now search for an index at the start of each sync * Add default for missing data in collection * Add a log message about the index chosen to sync an incremental stream * Add an example for a configured incremental catalog * Check test now validates the simplified check function * Remove collection name from spec.yaml and CollectionConfig * Update test_util.py to ahere to the new config * Update the first discover test to validate that we can find indexes correctly * Remove other discover tests, as they no longer apply * Full refresh test now works with simplified expanded columns * Remove unused imports * Incremental test now adheres to the find_index_for_stream system * Database test passes, so now all unit tests pass again * Remove extra fields from required section * ttl is nullable * Data defaults to an empty object * Update tests to reflect ttl and data select changes * Fix expected records. All unit tests and acceptance tests pass * Cleanup docs for find_index_for_stream * Update setup guide to reflect multiple collections

…lumns

* Add fauna source * Update changelog to include the correct PR * Improve docs (airbytehq#1) * Applied suggestions to improve docs (airbytehq#2) * Applied suggestions to improve docs * Cleaned up the docs * Apply suggestions from code review Co-authored-by: Ewan Edwards <46354154+faunaee@users.noreply.github.com> * Update airbyte-integrations/connectors/source-fauna/source_fauna/spec.yaml Co-authored-by: Ewan Edwards <46354154+faunaee@users.noreply.github.com> Co-authored-by: Ewan Edwards <46354154+faunaee@users.noreply.github.com> * Flake Checker (airbytehq#3) * Run ./gradlew :airbyte-integrations:connectors:source-fauna:flakeCheck * Fix all the warnings * Set additionalProperties to true to adhere to acceptance tests * Remove custom fields (airbytehq#4) * Remove custom fields from source.py * Remove custom fields from spec.yaml * Collections that support incremental sync are found correctly * Run formatter * Index values and termins are verified * Stripped additional_columns from collection config and check() * We now search for an index at the start of each sync * Add default for missing data in collection * Add a log message about the index chosen to sync an incremental stream * Add an example for a configured incremental catalog * Check test now validates the simplified check function * Remove collection name from spec.yaml and CollectionConfig * Update test_util.py to ahere to the new config * Update the first discover test to validate that we can find indexes correctly * Remove other discover tests, as they no longer apply * Full refresh test now works with simplified expanded columns * Remove unused imports * Incremental test now adheres to the find_index_for_stream system * Database test passes, so now all unit tests pass again * Remove extra fields from required section * ttl is nullable * Data defaults to an empty object * Update tests to reflect ttl and data select changes * Fix expected records. All unit tests and acceptance tests pass * Cleanup docs for find_index_for_stream * Update setup guide to reflect multiple collections * Add docs to install the fauna shell * Update examples and README to conform to the removal of additional columns * add seed file * auto-bump connector version [ci skip] * add icon in seed Co-authored-by: Neil Macneale <neil.macneale.v@gmail.com> Co-authored-by: Ewan Edwards <46354154+faunaee@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

evantahler · 2022-11-17T01:21:25Z

airbyte-config/init/src/main/resources/seed/source_definitions.yaml

+- name: Fauna
+  sourceDefinitionId: 3825db3e-c94b-42ac-bd53-b5a9507ace2b
+  dockerRepository: airbyte/source-fauna
+  dockerImageTag: dev
+  documentationUrl: https://docs.airbyte.com/integrations/sources/fauna
+  icon: fauna.svg
+  sourceType: database
+  releaseStage: alpha


@marcosmarxm I don't think a "dev" version exists. This should be something like v0.1.2.

https://github.com/airbytehq/airbyte/blob/master/airbyte-integrations/connectors/source-fauna/Dockerfile#L37 should be changed to be a real version number

@evantahler my bad! I think latest changes from #19534 fix it! thanks for catching this.

github-actions bot added area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Sep 28, 2022

octavia-squidington-iv added the connectors/source/fauna label Sep 28, 2022

macmv and others added 11 commits September 29, 2022 09:36

Add fauna source

b683e5c

Update changelog to include the correct PR

63df60e

Improve docs (#1)

4524821

Flake Checker (#3)

009be0f

* Run ./gradlew :airbyte-integrations:connectors:source-fauna:flakeCheck * Fix all the warnings * Set additionalProperties to true to adhere to acceptance tests

Add docs to install the fauna shell

ed5fc1a

Update examples and README to conform to the removal of additional co…

9d665c1

…lumns

add seed file

3ba4652

auto-bump connector version [ci skip]

151cbfd

add icon in seed

a047527

marcosmarxm force-pushed the marcos/pub-pr-15274 branch from 78b27bf to a047527 Compare September 29, 2022 13:36

marcosmarxm temporarily deployed to more-secrets September 29, 2022 13:38 Inactive

Merge branch 'master' into marcos/pub-pr-15274

a4028ed

github-actions bot removed area/documentation Improvements or additions to documentation area/connectors Connector related issues labels Sep 29, 2022

marcosmarxm changed the title ~~New Source Fauna~~ Source Fauna: add seed file information Sep 29, 2022

marcosmarxm merged commit 8fc5dcb into master Sep 29, 2022

marcosmarxm deleted the marcos/pub-pr-15274 branch September 29, 2022 13:39

marcosmarxm temporarily deployed to more-secrets September 29, 2022 13:40 Inactive

octavia-squidington-iii mentioned this pull request Oct 5, 2022

Bump Airbyte version from 0.40.10 to 0.40.11 #17610

Merged

evantahler reviewed Nov 17, 2022

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Source Fauna: add seed file information #17355

Source Fauna: add seed file information #17355

marcosmarxm commented Sep 28, 2022 •

edited

Loading

marcosmarxm commented Sep 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 28, 2022 •

edited by github-actions bot

Loading

evantahler Nov 17, 2022 •

edited

Loading

marcosmarxm Nov 17, 2022

Source Fauna: add seed file information #17355

Source Fauna: add seed file information #17355

Conversation

marcosmarxm commented Sep 28, 2022 • edited Loading

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Sep 28, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Sep 28, 2022 • edited by github-actions bot Loading

evantahler Nov 17, 2022 • edited Loading

Choose a reason for hiding this comment

marcosmarxm Nov 17, 2022

Choose a reason for hiding this comment

marcosmarxm commented Sep 28, 2022 •

edited

Loading

marcosmarxm commented Sep 28, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Sep 28, 2022 •

edited by github-actions bot

Loading

evantahler Nov 17, 2022 •

edited

Loading