Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source Fauna: fix unit tests #19534

Merged
merged 5 commits into from
Nov 17, 2022
Merged

Source Fauna: fix unit tests #19534

merged 5 commits into from
Nov 17, 2022

Conversation

sherifnada
Copy link
Contributor

@sherifnada sherifnada commented Nov 17, 2022 •
edited
Loading

What

Fixes type errors preventing the unit tests from passing

@akashkulk
Copy link
Contributor

akashkulk commented Nov 17, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-fauna

🕑 connectors/source-fauna https://github.com/airbytehq/airbyte/actions/runs/3489527913
❌ connectors/source-fauna https://github.com/airbytehq/airbyte/actions/runs/3489527913
🐛 https://gradle.com/s/sevb3ka74oucw

Build Failed

Test summary info:

=========================== short test summary info ============================
ERROR test_core.py::TestDiscovery::test_defined_cursors_exist_in_schema[inputs0]
============= 45 passed, 31 warnings, 1 error in 80.09s (0:01:20) ==============

@octavia-squidington-iv octavia-squidington-iv added the area/documentation Improvements or additions to documentation label Nov 17, 2022
@akashkulk
Copy link
Contributor

akashkulk commented Nov 17, 2022 •
edited by github-actions bot
Loading

/publish connector=connectors/source-fauna run-tests=false

🕑 Publishing the following connectors:
connectors/source-fauna
https://github.com/airbytehq/airbyte/actions/runs/3490128788


Connector Did it publish? Were definitions generated?
connectors/source-fauna ✅ ✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets November 17, 2022 16:45 Inactive
@akashkulk akashkulk self-requested a review November 17, 2022 17:06
@akashkulk akashkulk merged commit b1dfeed into master Nov 17, 2022
@akashkulk akashkulk deleted the sherif/fix-fauna branch November 17, 2022 17:30
@marcosmarxm marcosmarxm mentioned this pull request Nov 17, 2022
Merged
37 tasks
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
akashkulk added a commit that referenced this pull request Dec 2, 2022
@sherifnada @akashkulk @octavia-squidington-iii
Source Fauna: fix unit tests (#19534)
4f8545f 
* Source Fauna: fix unit tests

* Bump version in dockerfile

* Update fauna.md

* auto-bump connector version

Co-authored-by: Akash Kulkarni <113392464+akashkulk@users.noreply.github.com>
Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashkulk akashkulk akashkulk approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/fauna
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sherifnada @akashkulk @octavia-squidington-iii @octavia-squidington-iv