mssql-source:upgrade debezium version to 1.9.6 #18732

subodh1810 · 2022-10-31T20:20:48Z

Tested this locally.

Created a brand new connector via image built with these changes. Both first sync and subsequent syncs worked as expected.
Created a connector on version 0.4.24 and ran a sync and then changed the connector to use the dev image which included changes from this PR and the sync continued to work as expected proving this is backward compatible.

subodh1810 · 2022-10-31T20:21:04Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3364486254
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3364486254
No Python unittests run

Build Passed

Test summary info:

All Passed

github-actions · 2022-11-01T12:10:44Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-mysql-strict-encrypt%0A- source-mysql%0A- source-mssql%0A- source-mssql-strict-encrypt%0A- source-postgres

github-actions · 2022-11-01T12:12:55Z

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

source-postgres%0A- source-mysql-strict-encrypt%0A- source-mysql%0A- source-mssql-strict-encrypt%0A- source-mssql

subodh1810 · 2022-11-01T12:13:07Z

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3369303923
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3369303923
No Python unittests run

Build Passed

Test summary info:

All Passed

subodh1810 · 2022-11-01T12:13:14Z

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3369303642
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3369303642
No Python unittests run

Build Passed

Test summary info:

All Passed

subodh1810 · 2022-11-01T12:13:19Z

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3369304555
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3369304555
No Python unittests run

Build Passed

Test summary info:

All Passed

akashkulk · 2022-11-02T18:49:15Z

Thanks Subodh - could you quickly summarize the main changes in the PR description in this PR, and the ones needed to happen to upgrade the ms-sql connector to dbz 1.9.6?

rodireich · 2022-11-03T16:10:11Z

airbyte-integrations/bases/debezium-v1-9-6/build.gradle

@@ -11,7 +11,7 @@ dependencies {

    implementation 'io.debezium:debezium-api:1.9.6.Final'
    implementation 'io.debezium:debezium-embedded:1.9.6.Final'
-//    implementation 'io.debezium:debezium-connector-sqlserver:1.9.2.Final'
+    implementation 'io.debezium:debezium-connector-sqlserver:1.9.6.Final'


I just wanted to make sure that what was forgotten in Postgres (TINYINT(1)?) is taken care of here.

akashkulk · 2022-11-03T16:02:36Z

...v1-9-6/src/main/java/io/airbyte/integrations/debezium/internals/FirstRecordWaitTimeUtil.java

+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+public class FirstRecordWaitTimeUtil {


Can you add a brief class comment here?

subodh1810 · 2022-11-04T12:49:23Z

/publish connector=connectors/source-mssql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mssql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3393917020

Connector	Did it publish?	Were definitions generated?
connectors/source-mssql-strict-encrypt	❌	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

subodh1810 · 2022-11-04T12:49:41Z

/publish connector=connectors/source-mssql

🕑 Publishing the following connectors:
connectors/source-mssql
https://github.com/airbytehq/airbyte/actions/runs/3393919330

Connector	Did it publish?	Were definitions generated?
connectors/source-mssql	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

github-actions · 2022-11-04T12:49:53Z

Affected Connector Report

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to do the following as needed:

Run integration tests
Bump connector version
Add changelog
Publish the new version

⚠ Sources (5)

Connector	Version	Changelog	Publish
`source-mssql`	`0.4.25`	✅	✅
`source-mssql-strict-encrypt`	`0.4.25`	✅	⚠ (not in seed)
`source-mysql`	`1.0.11`	✅	✅
`source-mysql-strict-encrypt`	`1.0.11`	✅	⚠ (not in seed)
`source-postgres`	`1.0.22`	✅	✅

See "Actionable Items" below for how to resolve warnings and errors.

✅ Destinations (0)

Connector	Version	Changelog	Publish

See "Actionable Items" below for how to resolve warnings and errors.

Actionable Items

(click to expand)

Category	Status	Actionable Item
Version	❌ mismatch	The version of the connector is different from its normal variant. Please bump the version of the connector.
	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
Changelog	⚠ doc not found	The connector does not seem to have a documentation file. This can be normal (e.g. basic connector like `source-jdbc` is not published or documented). Please double-check to make sure that it is not a bug.
	❌ changelog missing	There is no chnagelog for the current version of the connector. If you are the author of the current version, please add a changelog.
Publish	⚠ not in seed	The connector is not in the seed file (e.g. `source_definitions.yaml`), so its publication status cannot be checked. This can be normal (e.g. some connectors are cloud-specific, and only listed in the cloud seed file). Please double-check to make sure that it is not a bug.
	❌ diff seed version	The connector exists in the seed file, but the latest version is not listed there. This usually means that the latest version is not published. Please use the `/publish` command to publish the latest version.

subodh1810 · 2022-11-04T16:57:45Z

/publish connector=connectors/source-mssql-strict-encrypt

🕑 Publishing the following connectors:
connectors/source-mssql-strict-encrypt
https://github.com/airbytehq/airbyte/actions/runs/3395634068

Connector	Did it publish?	Were definitions generated?
connectors/source-mssql-strict-encrypt	✅	❌

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

DoNotPanicUA · 2022-11-21T14:43:46Z

/test connector=connectors/source-mssql

mssql-source:upgrade debezium version to 1.9.6

edc1985

subodh1810 self-assigned this Oct 31, 2022

more improvements

8e2cd5a

github-actions bot added the area/connectors Connector related issues label Nov 1, 2022

octavia-squidington-iv added connectors/source/mssql connectors/source/mysql labels Nov 1, 2022

Merge branch 'master' into upgrade-debezium-version-mssql-source

29e87d7

subodh1810 linked an issue Nov 1, 2022 that may be closed by this pull request

Upgrade MSSQL debezium version to 1.9.6 #15248

Closed

subodh1810 marked this pull request as ready for review November 2, 2022 09:54

subodh1810 requested a review from a team as a code owner November 2, 2022 09:54

subodh1810 requested review from akashkulk and rodireich November 2, 2022 09:55

subodh1810 mentioned this pull request Nov 2, 2022

cleanup: delete debezium 1-4-2 module #18733

Merged

rodireich approved these changes Nov 3, 2022

View reviewed changes

akashkulk approved these changes Nov 3, 2022

View reviewed changes

subodh1810 added 2 commits November 4, 2022 18:16

Merge branch 'master' into upgrade-debezium-version-mssql-source

f435717

upgrade version

b5e596a

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 4, 2022

octavia-squidington-iv added the connectors/source/mssql-strict-encrypt label Nov 4, 2022

auto-bump connector version

6168130

octavia-squidington-iii temporarily deployed to more-secrets November 4, 2022 13:46 Inactive

fix test

311cd36

subodh1810 temporarily deployed to more-secrets November 4, 2022 16:59 Inactive

subodh1810 merged commit fe3f459 into master Nov 4, 2022

subodh1810 deleted the upgrade-debezium-version-mssql-source branch November 4, 2022 17:32

github-actions bot mentioned this pull request Nov 15, 2022

Bump helm chart version reference to 0.40.43 #19453

Closed

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

mssql-source:upgrade debezium version to 1.9.6 #18732

mssql-source:upgrade debezium version to 1.9.6 #18732

subodh1810 commented Oct 31, 2022 •

edited

Loading

subodh1810 commented Oct 31, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

subodh1810 commented Nov 1, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 1, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 1, 2022 •

edited by github-actions bot

Loading

akashkulk commented Nov 2, 2022

rodireich Nov 3, 2022

akashkulk Nov 3, 2022

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 4, 2022 •

edited

Loading

⚠ Sources (5)

✅ Destinations (0)

Actionable Items

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading

DoNotPanicUA commented Nov 21, 2022

mssql-source:upgrade debezium version to 1.9.6 #18732

mssql-source:upgrade debezium version to 1.9.6 #18732

Conversation

subodh1810 commented Oct 31, 2022 • edited Loading

subodh1810 commented Oct 31, 2022 • edited by github-actions bot Loading

Build Passed

github-actions bot commented Nov 1, 2022

github-actions bot commented Nov 1, 2022

subodh1810 commented Nov 1, 2022 • edited by github-actions bot Loading

Build Passed

subodh1810 commented Nov 1, 2022 • edited by github-actions bot Loading

Build Passed

subodh1810 commented Nov 1, 2022 • edited by github-actions bot Loading

Build Passed

akashkulk commented Nov 2, 2022

rodireich Nov 3, 2022

Choose a reason for hiding this comment

akashkulk Nov 3, 2022

Choose a reason for hiding this comment

subodh1810 commented Nov 4, 2022 • edited by github-actions bot Loading

subodh1810 commented Nov 4, 2022 • edited by github-actions bot Loading

github-actions bot commented Nov 4, 2022 • edited Loading

Affected Connector Report

⚠ Sources (5)

✅ Destinations (0)

Actionable Items

subodh1810 commented Nov 4, 2022 • edited by github-actions bot Loading

DoNotPanicUA commented Nov 21, 2022

subodh1810 commented Oct 31, 2022 •

edited

Loading

subodh1810 commented Oct 31, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 1, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 1, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 1, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading

github-actions bot commented Nov 4, 2022 •

edited

Loading

subodh1810 commented Nov 4, 2022 •

edited by github-actions bot

Loading