Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: delete debezium 1-4-2 module #18733

Merged
merged 6 commits into from
Nov 4, 2022
Merged

cleanup: delete debezium 1-4-2 module #18733

merged 6 commits into from
Nov 4, 2022

Conversation

subodh1810
Copy link
Contributor

@subodh1810 subodh1810 commented Oct 31, 2022 •
edited
Loading

The module is not used. All the 3 DBs (Postgres, MySQL and MSSQL) have been upgraded to use the 1-9-6 module so this can be deleted. This PR makes me happy! :D

Should only be merged after #18732 is merged

@subodh1810 subodh1810 self-assigned this Oct 31, 2022
@subodh1810
Copy link
Contributor Author

subodh1810 commented Oct 31, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3364505767
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3364505767
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions github-actions bot added the area/connectors Connector related issues label Oct 31, 2022
@subodh1810
Copy link
Contributor Author

subodh1810 commented Oct 31, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3364506144
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3364506144
No Python unittests run

Build Passed

Test summary info:

All Passed

@subodh1810
Copy link
Contributor Author

subodh1810 commented Oct 31, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3364506551
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3364506551
No Python unittests run

Build Passed

Test summary info:

All Passed

@subodh1810 subodh1810 changed the base branch from master to upgrade-debezium-version-mssql-source October 31, 2022 20:24
@github-actions
Copy link
Contributor

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mssql-strict-encrypt%0A- source-postgres%0A- source-mssql%0A- source-mysql

@subodh1810 subodh1810 temporarily deployed to more-secrets October 31, 2022 20:26 Inactive
@github-actions github-actions bot removed the area/connectors Connector related issues label Nov 1, 2022
@subodh1810
Copy link
Contributor Author

subodh1810 commented Nov 1, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3369305851
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3369305851
No Python unittests run

Build Passed

Test summary info:

All Passed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2022

NOTE ⚠️ Changes in this PR affect the following connectors. Make sure to run corresponding integration tests:

  • source-mssql%0A- source-mysql-strict-encrypt%0A- source-postgres%0A- source-mssql-strict-encrypt%0A- source-mysql

@subodh1810
Copy link
Contributor Author

subodh1810 commented Nov 1, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3369306050
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3369306050
No Python unittests run

Build Passed

Test summary info:

All Passed

@subodh1810
Copy link
Contributor Author

subodh1810 commented Nov 1, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3369306563
❌ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3369306563
🐛 https://gradle.com/s/wtihkztv3fcvk

Build Failed

Test summary info:

Could not find result summary

@subodh1810 subodh1810 temporarily deployed to more-secrets November 1, 2022 12:15 Inactive
@subodh1810
Copy link
Contributor Author

subodh1810 commented Nov 1, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3369701980
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3369701980
No Python unittests run

Build Passed

Test summary info:

All Passed

@subodh1810 subodh1810 marked this pull request as ready for review November 2, 2022 09:55
@rodireich
Copy link
Contributor

🥳

akashkulk
akashkulk approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@akashkulk akashkulk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Unrelated question : I see a directory for dbz v-1-9-2 here. Where exactly is that used (if at all)?

@subodh1810
Copy link
Contributor Author

@akashkulk where do you see 1-9-2? We were on 1-9-2 before but it shouldnt exist anymore. Can you point it out

@akashkulk
Copy link
Contributor

@akashkulk where do you see 1-9-2? We were on 1-9-2 before but it shouldnt exist anymore. Can you point it out

Nevermind, I think it's some local generated files that haven't gotten deleted:
https://www.loom.com/i/8a3417bd3a8c456283b562ba990394cf

Base automatically changed from upgrade-debezium-version-mssql-source to master November 4, 2022 17:32
@subodh1810 subodh1810 requested a review from a team as a code owner November 4, 2022 17:32
@subodh1810
Copy link
Contributor Author

subodh1810 commented Nov 4, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mssql

🕑 connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3395873797
✅ connectors/source-mssql https://github.com/airbytehq/airbyte/actions/runs/3395873797
No Python unittests run

Build Passed

Test summary info:

All Passed

@subodh1810
Copy link
Contributor Author

subodh1810 commented Nov 4, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-postgres

🕑 connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3395874582
✅ connectors/source-postgres https://github.com/airbytehq/airbyte/actions/runs/3395874582
No Python unittests run

Build Passed

Test summary info:

All Passed

@subodh1810
Copy link
Contributor Author

subodh1810 commented Nov 4, 2022 •
edited by github-actions bot
Loading

/test connector=connectors/source-mysql

🕑 connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3395876410
✅ connectors/source-mysql https://github.com/airbytehq/airbyte/actions/runs/3395876410
No Python unittests run

Build Passed

Test summary info:

All Passed

@subodh1810 subodh1810 temporarily deployed to more-secrets November 4, 2022 17:36 Inactive
tuliren
tuliren approved these changes Nov 4, 2022
View reviewed changes
Copy link
Contributor

@tuliren tuliren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@subodh1810 subodh1810 merged commit 3468516 into master Nov 4, 2022
@subodh1810 subodh1810 deleted the delete-debezium-1-4-2 branch November 4, 2022 18:54
letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/experiment-add-source-in-signup
c3edfb7 
* master: (69 commits)
  🪟 🐛 Fix wrong geography dropdown type #19021
  SAT: basic read on full catalog when `test_strictness_level == high` (#18937)
  Unhide DynamoDB destination (#18994)
  Fixed tests for destination connectors (#19007)
  🐛 Source Facebook Marketing: handle FacebookBadObjectError (#18971)
  Edit multi-cloud docs (#18972)
  🪟 🎉 Load credits consumption separate (#18986)
  Bmoric/extract source api (#18944)
  Migrating InvalidCursorException -> ConfigErrorException  (#18995)
  🪟 🎨 Fix banner link color (#18978)
  Handling configuration exceptions in IntegrationRunner (#18989)
  Add new workspace api endpoint (#18983)
  Add normalization to destination definition and actor definition table (#18300)
  Fix oauth controller (#18981)
  Fix migration dev center schema dump by run db-specific initialization script (#18984)
  fix master build failure (#18982)
  cleanup: delete debezium 1-4-2 module (#18733)
  Remove unused job persistence methods. (#18952)
  Hash filenames of extracted CSS (#18976)
  Fix typo in source code comment DataDaog ==> Datadog (#18911)
  ...
letiescanciano added a commit that referenced this pull request Nov 7, 2022
@letiescanciano
Merge branch 'master' into leti/move-oauth-to-the-top
6c7a97f 
* master: (73 commits)
  🪟 🐛 Fix wrong geography dropdown type #19021
  SAT: basic read on full catalog when `test_strictness_level == high` (#18937)
  Unhide DynamoDB destination (#18994)
  Fixed tests for destination connectors (#19007)
  🐛 Source Facebook Marketing: handle FacebookBadObjectError (#18971)
  Edit multi-cloud docs (#18972)
  🪟 🎉 Load credits consumption separate (#18986)
  Bmoric/extract source api (#18944)
  Migrating InvalidCursorException -> ConfigErrorException  (#18995)
  🪟 🎨 Fix banner link color (#18978)
  Handling configuration exceptions in IntegrationRunner (#18989)
  Add new workspace api endpoint (#18983)
  Add normalization to destination definition and actor definition table (#18300)
  Fix oauth controller (#18981)
  Fix migration dev center schema dump by run db-specific initialization script (#18984)
  fix master build failure (#18982)
  cleanup: delete debezium 1-4-2 module (#18733)
  Remove unused job persistence methods. (#18952)
  Hash filenames of extracted CSS (#18976)
  Fix typo in source code comment DataDaog ==> Datadog (#18911)
  ...
@github-actions github-actions bot mentioned this pull request Nov 15, 2022
Closed
@octavia-squidington-iii octavia-squidington-iii mentioned this pull request Nov 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashkulk akashkulk akashkulk approved these changes

@tuliren tuliren tuliren approved these changes

@rodireich rodireich rodireich approved these changes

Assignees

@subodh1810 subodh1810

Labels
connectors/source/mssql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@subodh1810 @rodireich @akashkulk @tuliren @octavia-squidington-iv