🎉 New Source: Polygon Stocks #18842

Harshil0512 · 2022-11-02T09:28:27Z

What

The Following PR adds a Low Code CDK Source for Polygon-Stocks-API provided by https://polygon.io/

How

The PR uses the configuration based CDK and implements full refresh syncs of the following streams :

stock_api_stream

🚨 User Impact 🚨

No Changes To Existing Code

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Harshil0512 · 2022-11-02T09:30:28Z

Issue related to this PR :

airbytehq/connector-contest#261

marcosmarxm · 2022-11-02T11:13:59Z

@Harshil0512 please check your commits there is something wrong with it.

Harshil0512 · 2022-11-02T12:40:24Z

@marcosmarxm may I know what is wrong with the commit ? is there something wrong with the files which I created or something with the files belongs to your repository updated due to my commit?

marcosmarxm · 2022-11-02T12:54:08Z

You're pushing files that don't make part of the pull request goal. Take a look.

Harshil0512 · 2022-11-02T13:01:37Z

Okay let me see and update it

Harshil0512 · 2022-11-02T13:27:59Z

@marcosmarxm can you please check the files now?

marcosmarxm

Hello @Harshil0512, Marcos from Airbyte here 👋 . We received more than 25 new contributions along the weekend. One is yours 🎉 thank so much for! Our team is limited and maybe the review process can take longer than expected. As described in the Airbyte's Hacktoberfest your contribution was submitted before November 2nd and it is eligible to win the prize. The review process will validate other requirements. I ask to you patience until someone from the team review it.

Because I reviewed some contributions for Hacktoberfest so far I saw some common patterns you can check in advance:

Make sure you have added connector documentation to /docs/integrations/
Remove the file catalog from /integration_tests
Edit the sample_config.json inside /integration_tests
For the configured_catalog you can use only json_schema: {}
Add title to all properties in the spec.yaml
Make sure the documentationUrl in the spec.yaml redirect to Airbyte's future connector page, eg: connector Airtable the documentationUrl: https://docs.airbyte.com/integrations/sources/airtable
Review now new line at EOF (end-of-file) for all files.

If possible send to me a DM in Slack with the tests credentials, this process will make easier to us run integration tests and publish your connector. If you only has production keys, make sure to create a bootstrap.md explaining how to get the keys.

Harshil0512 · 2022-11-03T02:45:23Z

Okat let me review the files once again. Thank you.

marcosmarxm · 2022-11-04T08:56:03Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

Harshil0512 · 2022-11-04T14:49:30Z

Sure No Problem @marcosmarxm

Harshil0512 · 2022-11-05T10:45:10Z

I performed the changes mentioned in the review changes

Harshil0512 · 2022-11-07T16:01:25Z

Hello! I'm going to be out of the office this Friday and won't be able to review your contribution again today, I return next Monday. So far, most contributions look solid and are almost done to be approved. As said in Chris' comment all contributions made before 2-November are eligible to receive the prize and have 2 weeks to merge the contributions. But I ensure next week we're going to have your contribution merged. If you have questions about the implementation you can send them in #hacktoberfest-2022 in Airbyte's Slack.

Sorry the inconvenience and see you again next week, thank you so much for your contribution!

Are you there @marcosmarxm

marcosmarxm

Some comments.

marcosmarxm · 2022-11-08T00:07:52Z

...grations/connectors/source-polygon-stock-api/source_polygon_stock_api/polygon_stock_api.yaml

+    $options:
+      name: "stock_api"
+      primary_key: "id"
+      path: "/v2/aggs/ticker/{{ config['stocksTicker'] }}/range/{{ config['multiplier'] }}/{{ config['timespan'] }}/{{ config['from'] }}/{{ config['to'] }}?adjusted={{ config['adjusted'] }}&sort={{ config['sort'] }}&limit=120&apiKey={{ config['apiKey'] }}"


Please overwrite the request parameter component.
Please implement the DateStreamSlicer to enable incremental syncs.
Always sort by desc to read first old to newest data.

This is still to be done I'll finish this soon.

marcosmarxm · 2022-11-08T00:08:21Z

...grations/connectors/source-polygon-stock-api/source_polygon_stock_api/polygon_stock_api.yaml

+streams:
+  - "*ref(definitions.stock_api_stream)"


Are you going to add only this endpoint? I saw other endpoints in the API docs.

Yes as I thought it is the most important end point as per my point of view

marcosmarxm · 2022-11-08T00:08:58Z

airbyte-integrations/connectors/source-polygon-stock-api/source_polygon_stock_api/spec.yaml

+    from:
+      type: string
+      description: The beginning date for the aggregate window.
+      examples:
+        - "2020-10-14"
+    to:
+      type: string
+      description: The target date for the aggregate window.
+      examples:
+        - "2020-10-14"


Change from to start_date and to to end_date is more used by Airbyte's connectors.

marcosmarxm · 2022-11-08T00:09:12Z

airbyte-integrations/connectors/source-polygon-stock-api/source_polygon_stock_api/spec.yaml

+        - IBM
+        - MSFT
+    multiplier:
+      type: integer


Add title to your parameters.

marcosmarxm · 2022-11-08T00:09:41Z

airbyte-integrations/connectors/source-polygon-stock-api/source_polygon_stock_api/spec.yaml

+    - multiplier
+    - timespan
+    - from
+    - to


to or end_date is not required if you implement the datestream slicer.

Harshil0512 · 2022-11-08T19:29:01Z

Okay I'll work on that and will keep you updated

marcosmarxm · 2022-11-16T21:23:25Z

@Harshil0512 I had a problem when pushing some change to your branch :( I'll finish your work at #19504 Thanks so much for the contribution

@RealChrisSean same problem real, sorry!!!

Harshil0512 requested a review from a team as a code owner November 2, 2022 09:28

github-actions bot added area/api Related to the api area/connectors Connector related issues area/platform issues related to the platform area/server area/worker Related to worker labels Nov 2, 2022

Harshil0512 mentioned this pull request Nov 2, 2022

New Source : Polygon-Stocks-API airbytehq/connector-contest#261

Closed

marcosmarxm added the hacktober label Nov 2, 2022

github-actions bot removed area/server area/platform issues related to the platform area/worker Related to worker area/api Related to the api labels Nov 2, 2022

marcosmarxm removed the request for review from a team November 2, 2022 18:32

marcosmarxm removed the connectors/source/mysql label Nov 2, 2022

marcosmarxm removed connectors/source/postgres connectors/destination/mongodb connectors/destination/redis connectors/source/relational-db connectors/source/mysql-strict-encrypt connectors/source/weather-api labels Nov 2, 2022

marcosmarxm requested changes Nov 2, 2022

View reviewed changes

github-actions bot added the area/documentation Improvements or additions to documentation label Nov 5, 2022

marcosmarxm changed the title ~~Polygon-Stocks-API~~ 🎉 New Source: Polygon Nov 7, 2022

marcosmarxm changed the title ~~🎉 New Source: Polygon~~ 🎉 New Source: Polygon Stocks Nov 7, 2022

marcosmarxm requested changes Nov 8, 2022

View reviewed changes

marcosmarxm closed this Nov 16, 2022

marcosmarxm force-pushed the master branch from d37dea1 to 310b518 Compare November 16, 2022 21:20

octavia-squidington-iv removed area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 16, 2022

marcosmarxm mentioned this pull request Nov 16, 2022

New Connector Polygon #19504

Merged

37 tasks

airbyteio temporarily deployed to more-secrets November 16, 2022 21:25 Inactive

airbyteio temporarily deployed to more-secrets November 16, 2022 21:34 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🎉 New Source: Polygon Stocks #18842

🎉 New Source: Polygon Stocks #18842

Harshil0512 commented Nov 2, 2022

Harshil0512 commented Nov 2, 2022

marcosmarxm commented Nov 2, 2022

Harshil0512 commented Nov 2, 2022

marcosmarxm commented Nov 2, 2022

Harshil0512 commented Nov 2, 2022

Harshil0512 commented Nov 2, 2022

marcosmarxm left a comment

Harshil0512 commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

Harshil0512 commented Nov 4, 2022

Harshil0512 commented Nov 5, 2022

Harshil0512 commented Nov 7, 2022

marcosmarxm left a comment

marcosmarxm Nov 8, 2022

Harshil0512 Nov 13, 2022

marcosmarxm Nov 8, 2022

Harshil0512 Nov 13, 2022

marcosmarxm Nov 8, 2022

Harshil0512 Nov 13, 2022

marcosmarxm Nov 8, 2022

Harshil0512 Nov 13, 2022

marcosmarxm Nov 8, 2022

Harshil0512 commented Nov 8, 2022

marcosmarxm commented Nov 16, 2022

		streams:
		- "*ref(definitions.stock_api_stream)"

🎉 New Source: Polygon Stocks #18842

🎉 New Source: Polygon Stocks #18842

Conversation

Harshil0512 commented Nov 2, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

Harshil0512 commented Nov 2, 2022

marcosmarxm commented Nov 2, 2022

Harshil0512 commented Nov 2, 2022

marcosmarxm commented Nov 2, 2022

Harshil0512 commented Nov 2, 2022

Harshil0512 commented Nov 2, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

Harshil0512 commented Nov 3, 2022

marcosmarxm commented Nov 4, 2022

Harshil0512 commented Nov 4, 2022

Harshil0512 commented Nov 5, 2022

Harshil0512 commented Nov 7, 2022

marcosmarxm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Harshil0512 commented Nov 8, 2022

marcosmarxm commented Nov 16, 2022