New Connector Polygon #19504

marcosmarxm · 2022-11-16T21:22:07Z

What

Merge contribution: #18842

How

Describe the solution

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

Pre-merge Checklist

Expand the relevant checklist and delete the others.

New Connector

Community member or Airbyter

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub by running the /publish command described here
After the connector is published, connector added to connector index as described here
Seed specs have been re-generated by building the platform and committing the changes to the seed spec files, as described here

Updating a connector

Community member or Airbyter

Grant edit access to maintainers (instructions)
Secrets in the connector's spec are annotated with airbyte_secret
Unit & integration tests added and passing. Community members, please provide proof of success locally e.g: screenshot or copy-paste unit, integration, and acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run ./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
Code reviews completed
Documentation updated
- Connector's README.md
- Connector's bootstrap.md. See description and examples
- Changelog updated in docs/integrations/<source or destination>/<name>.md including changelog. See changelog example
PR name follows PR naming conventions

Airbyter

If this is a community PR, the Airbyte engineer reviewing this PR is responsible for the below items.

Create a non-forked branch based on this PR and test the below items on it
Build is successful
If new credentials are required for use in CI, add them to GSM. Instructions.
/test connector=connectors/<name> command is passing
New Connector version released on Dockerhub and connector version bumped by running the /publish command described here

Connector Generator

Issue acceptance criteria met
PR name follows PR naming conventions
If adding a new generator, add it to the list of scaffold modules being tested
The generator test modules (all connectors with -scaffold in their name) have been updated with the latest scaffold by running ./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplates then checking in your changes
Documentation which references the generator is updated as needed

Tests

Unit

Put your unit tests output here.

Integration

Put your integration tests output here.

Acceptance

Put your acceptance tests output here.

Polygon-Stocks-API is the API provided by https://polygon.io/ to get details about the stock

Add title to your parameters is done Change from to start_date and to to end_date is done

marcosmarxm · 2022-11-16T21:22:30Z

/test connector=connectors/source-polygon-stock-api

🕑 connectors/source-polygon-stock-api https://github.com/airbytehq/airbyte/actions/runs/3483223527
❌ connectors/source-polygon-stock-api https://github.com/airbytehq/airbyte/actions/runs/3483223527
🐛 https://gradle.com/s/tzh2mni46z53y

Build Failed

Test summary info:

=========================== short test summary info ============================
FAILED test_core.py::TestDiscovery::test_primary_keys_exist_in_schema[inputs0]
FAILED test_core.py::TestBasicRead::test_read[inputs0] - AssertionError: Prim...
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:88: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:358: The previous connector image could not be retrieved.
=================== 2 failed, 24 passed, 3 skipped in 23.13s ===================

marcosmarxm · 2022-11-16T21:44:28Z

/test connector=connectors/source-polygon-stock-api

🕑 connectors/source-polygon-stock-api https://github.com/airbytehq/airbyte/actions/runs/3483363015
✅ connectors/source-polygon-stock-api https://github.com/airbytehq/airbyte/actions/runs/3483363015
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       139      5    96%   87, 93, 235, 239-240
	 source_acceptance_test/conftest.py                     196     92    53%   35, 41-43, 48, 54, 60, 66, 72-74, 93, 98-100, 106-108, 114-115, 120-121, 126, 132, 141-150, 156-161, 176, 200, 231, 237, 243-248, 256-261, 269-282, 287-293, 300-311, 318-334
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              394    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 293, 331-348, 357-365, 369-374, 380, 413-418, 456-463, 506-508, 511, 576-584, 596-599, 604, 660-661, 667, 670, 706-716, 729-754
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 37      2    95%   57-58
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       112     50    55%   23-26, 32, 36, 39-68, 71-73, 76-78, 81-83, 86-88, 91-93, 96-114, 148-150
	 source_acceptance_test/utils/json_schema_helper.py     105     13    88%   30-31, 38, 41, 65-68, 96, 120, 190-192
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1557    349    78%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:63: Skipping TestIncremental.test_two_sequential_reads: This connector does not implement incremental sync
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:88: The previous connector image could not be retrieved.
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/tests/test_core.py:358: The previous connector image could not be retrieved.
======================== 26 passed, 3 skipped in 22.81s ========================

marcosmarxm · 2022-11-16T21:59:54Z

/publish connector=connectors/source-polygon-stock-api

🕑 Publishing the following connectors:
connectors/source-polygon-stock-api
https://github.com/airbytehq/airbyte/actions/runs/3483452840

Connector	Did it publish?	Were definitions generated?
connectors/source-polygon-stock-api	✅	✅

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

Harshil0512 · 2022-11-17T06:46:43Z

Are there any more changes or this PR is connected ? @marcosmarxm

Harshil0512 · 2022-11-26T15:58:51Z

Hello @marcosmarxm may I know the status of my PR? is there any problem or everthing's working fine?

* Weather API CDK Added * Polygon-Stocks-API CDK Added Polygon-Stocks-API is the API provided by https://polygon.io/ to get details about the stock * spec.yaml updated * Files Changes Resolved * Review Changes Are Performed * Some Requested Changes Are Done Add title to your parameters is done Change from to start_date and to to end_date is done * correct schema * add polygon to source def * run format * correct primary key * auto-bump connector version Co-authored-by: Harshil Khamar <harshilkhamar1@gmail.com> Co-authored-by: Harshil Khamar <73790584+Harshil0512@users.noreply.github.com> Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>

Harshil0512 and others added 12 commits November 2, 2022 12:15

Weather API CDK Added

021d314

Polygon-Stocks-API CDK Added

055be42

Polygon-Stocks-API is the API provided by https://polygon.io/ to get details about the stock

spec.yaml updated

84196aa

Merge branch 'airbytehq:master' into master

fcbe39d

Merge branch 'airbytehq:master' into master

9036340

Files Changes Resolved

a8a203e

Merge branch 'airbytehq:master' into master

57b33ed

Merge branch 'airbytehq:master' into master

96a99cb

Review Changes Are Performed

660a569

Some Requested Changes Are Done

2cce81a

Add title to your parameters is done Change from to start_date and to to end_date is done

Merge branch 'airbytehq:master' into master

d37dea1

correct schema

ed29b33

octavia-squidington-iv added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/polygon-stock-api labels Nov 16, 2022

marcosmarxm mentioned this pull request Nov 16, 2022

🎉 New Source: Polygon Stocks #18842

Closed

36 tasks

add polygon to source def

85ef41b

marcosmarxm temporarily deployed to more-secrets November 16, 2022 21:27 Inactive

run format

b1b885d

marcosmarxm temporarily deployed to more-secrets November 16, 2022 21:35 Inactive

correct primary key

01fca3e

marcosmarxm temporarily deployed to more-secrets November 16, 2022 21:46 Inactive

auto-bump connector version

c2500f1

octavia-squidington-iii temporarily deployed to more-secrets November 16, 2022 22:19 Inactive

Merge branch 'master' into marcos/new-connector-polygon

1e82f87

marcosmarxm temporarily deployed to more-secrets November 16, 2022 22:24 Inactive

Merge branch 'master' into marcos/new-connector-polygon

3046cd3

marcosmarxm temporarily deployed to more-secrets November 16, 2022 22:51 Inactive

marcosmarxm merged commit 1421ba7 into master Nov 16, 2022

marcosmarxm deleted the marcos/new-connector-polygon branch November 16, 2022 22:55

github-actions bot mentioned this pull request Nov 17, 2022

Bump helm chart version reference to 0.40.44 #19546

Merged

octavia-squidington-iii mentioned this pull request Nov 18, 2022

Bump Airbyte version from 0.40.18 to 0.40.19 #19579

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Connector Polygon #19504

New Connector Polygon #19504

marcosmarxm commented Nov 16, 2022

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

Harshil0512 commented Nov 17, 2022

Harshil0512 commented Nov 26, 2022

New Connector Polygon #19504

New Connector Polygon #19504

Conversation

marcosmarxm commented Nov 16, 2022

What

How

Recommended reading order

🚨 User Impact 🚨

Pre-merge Checklist

Community member or Airbyter

Airbyter

Community member or Airbyter

Airbyter

Tests

marcosmarxm commented Nov 16, 2022 • edited by github-actions bot Loading

Build Failed

marcosmarxm commented Nov 16, 2022 • edited by github-actions bot Loading

Build Passed

marcosmarxm commented Nov 16, 2022 • edited by github-actions bot Loading

Harshil0512 commented Nov 17, 2022

Harshil0512 commented Nov 26, 2022

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading

marcosmarxm commented Nov 16, 2022 •

edited by github-actions bot

Loading