Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎉Source Zenloop: migrate to lowcode #19624

Merged
merged 13 commits into from
Dec 9, 2022

Conversation

lazebnyi
Copy link
Collaborator

What

#18709

How

Migrate to low code, set up tests, edit docs etc

@octavia-squidington-iv octavia-squidington-iv added connectors/source/zenloop area/connectors Connector related issues area/documentation Improvements or additions to documentation labels Nov 18, 2022
@girarda girarda requested a review from brianjlai November 18, 2022 23:50
@lazebnyi lazebnyi requested review from girarda and sherifnada and removed request for grubberr and artem1205 November 29, 2022 11:55
@lazebnyi lazebnyi changed the title Source Zenloop: migrate to lowcode 🎉Source Zenloop: migrate to lowcode Dec 6, 2022
@lazebnyi lazebnyi requested a review from girarda December 7, 2022 13:22
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2022 13:37 — with GitHub Actions Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2022 13:37 — with GitHub Actions Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2022 16:50 — with GitHub Actions Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2022 16:50 — with GitHub Actions Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2022 22:07 — with GitHub Actions Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 9, 2022

/test connector=connectors/source-zenloop

🕑 connectors/source-zenloop https://github.com/airbytehq/airbyte/actions/runs/3661208501
✅ connectors/source-zenloop https://github.com/airbytehq/airbyte/actions/runs/3661208501
Python tests coverage:

	 Name                                                 Stmts   Miss  Cover   Missing
	 ----------------------------------------------------------------------------------
	 source_acceptance_test/base.py                          12      4    67%   16-19
	 source_acceptance_test/config.py                       140      5    96%   87, 93, 238, 242-243
	 source_acceptance_test/conftest.py                     208     92    56%   36, 42-44, 49, 54, 77, 83, 89-91, 110, 115-117, 123-125, 131-132, 137-138, 143, 149, 158-167, 173-178, 193, 217, 248, 254, 262-267, 275-280, 288-301, 306-312, 319-330, 337-353
	 source_acceptance_test/plugin.py                        69     25    64%   22-23, 31, 36, 120-140, 144-148
	 source_acceptance_test/tests/test_core.py              398    111    72%   53, 58, 87-95, 100-107, 111-112, 116-117, 299, 337-354, 363-371, 375-380, 386, 419-424, 462-469, 512-514, 517, 582-590, 602-605, 610, 666-667, 673, 676, 712-722, 735-760
	 source_acceptance_test/tests/test_incremental.py       158     14    91%   52-59, 64-77, 240
	 source_acceptance_test/utils/asserts.py                 39      2    95%   62-63
	 source_acceptance_test/utils/common.py                  94     10    89%   16-17, 32-38, 72, 75
	 source_acceptance_test/utils/compare.py                 62     23    63%   21-51, 68, 97-99
	 source_acceptance_test/utils/connector_runner.py       133     33    75%   24-27, 46-47, 50-54, 57-58, 73-75, 78-80, 83-85, 88-90, 93-95, 124-125, 159-161, 208
	 source_acceptance_test/utils/json_schema_helper.py     107     13    88%   30-31, 38, 41, 65-68, 96, 120, 192-194
	 ----------------------------------------------------------------------------------
	 TOTAL                                                 1599    332    79%

Build Passed

Test summary info:

All Passed

@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2022 22:27 — with GitHub Actions Inactive
@lazebnyi lazebnyi temporarily deployed to more-secrets December 9, 2022 22:27 — with GitHub Actions Inactive
@lazebnyi
Copy link
Collaborator Author

lazebnyi commented Dec 9, 2022

/publish connector=connectors/source-zenloop run-tests=false

🕑 Publishing the following connectors:
connectors/source-zenloop
https://github.com/airbytehq/airbyte/actions/runs/3661273821


Connector Did it publish? Were definitions generated?
connectors/source-zenloop

if you have connectors that successfully published but failed definition generation, follow step 4 here ▶️

@lazebnyi lazebnyi merged commit 17c767a into master Dec 9, 2022
@lazebnyi lazebnyi deleted the lazebnyi/18709-source-zenloop-migrate-to-lowcode branch December 9, 2022 22:56
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 9, 2022 22:57 — with GitHub Actions Inactive
@octavia-squidington-iii octavia-squidington-iii temporarily deployed to more-secrets December 9, 2022 22:58 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/source/zenloop
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants